Skip to contentSkip to conversation

sched: Remove obsolete comment in sched_init()

PATCH In review Jayson R. King 2 participants 5 messages Oct 5, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sched: Remove obsolete comment in sched_init()

Remove the comment about calling alloc_bootmem() as it is not called here since commit 36b7b6d465489c4754c4fd66fcec6086eba87896.

---
 kernel/sched.c |    4 ----
 1 file changed, 4 deletions(-)
kernel/sched.c +0 -4
index 1535f38..d68ac0e 100644
@@ -9334,10 +9334,6 @@ void __init sched_init(void)
 #ifdef CONFIG_CPUMASK_OFFSTACK
        alloc_size += num_possible_cpus() * cpumask_size();
 #endif
-       /*
-        * As sched_init() is called before page_alloc is setup,
-        * we use alloc_bootmem().
-        */
        if (alloc_size) {
                ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);
 
#1 lore raw
Quoted 13 lines · Jayson R. King

Remove the comment about calling alloc_bootmem() as it is not called here since commit 36b7b6d465489c4754c4fd66fcec6086eba87896.

---
 kernel/sched.c |    4 ----
 1 file changed, 4 deletions(-)
kernel/sched.c +0 -0
index 1535f38..d68ac0e 100644

kernel/sched.c void __init sched_init(void) · line 9338

Quoted 9 lines
kernel/sched.c +0 -4
@@ -9334,10 +9334,6 @@ void __init sched_init(void)
 #ifdef CONFIG_CPUMASK_OFFSTACK
        alloc_size += num_possible_cpus() * cpumask_size();
 #endif
-       /*
-        * As sched_init() is called before page_alloc is setup,
-        * we use alloc_bootmem().
-        */
        if (alloc_size) {
                ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);

Looks good. The patch is whitespace damaged though (all tabs are spaces)
- please consult Documentation/email-clients.txt and resend the patch.

Thanks,

Ingo

#2 lore raw

PATCH 1/1 sched: Remove obsolete comment in sched_init()

Remove the comment about calling alloc_bootmem() as it is not called here since commit 36b7b6d465489c4754c4fd66fcec6086eba87896.

---
 sched.c |    4 ----
 1 file changed, 4 deletions(-)
kernel/sched.c +0 -4
index 1535f38..d68ac0e 100644
@@ -9334,10 +9334,6 @@ void __init sched_init(void)
 #ifdef CONFIG_CPUMASK_OFFSTACK
 	alloc_size += num_possible_cpus() * cpumask_size();
 #endif
-	/*
-	 * As sched_init() is called before page_alloc is setup,
-	 * we use alloc_bootmem().
-	 */
 	if (alloc_size) {
 		ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);
 
#4 lore raw
In reply to Jayson R. King
Commit-ID:  cf82ff7ea7695b0e82ba07bc5e9f1bd03a74e1aa
Gitweb:     http://git.kernel.org/tip/cf82ff7ea7695b0e82ba07bc5e9f1bd03a74e1aa
Author:     Jayson R. King <[email protected]>
AuthorDate: Mon, 5 Oct 2009 05:21:26 -0500
Committer:  Ingo Molnar <[email protected]>
CommitDate: Mon, 5 Oct 2009 21:37:22 +0200

sched: Remove obsolete comment in sched_init()

Remove the comment about calling alloc_bootmem() as it is not called here since commit 36b7b6d465489c4754c4fd66fcec6086eba87896.

Cc Peter Zijlstra <[email protected]>
Cc Jiri Kosina <[email protected]>

LKML-Reference: <[email protected]>

---
 kernel/sched.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
kernel/sched.c +0 -4
index 830967e..a56446d 100644
@@ -9322,10 +9322,6 @@ void __init sched_init(void)
 #ifdef CONFIG_CPUMASK_OFFSTACK
 	alloc_size += num_possible_cpus() * cpumask_size();
 #endif
-	/*
-	 * As sched_init() is called before page_alloc is setup,
-	 * we use alloc_bootmem().
-	 */
 	if (alloc_size) {
 		ptr = (unsigned long)kzalloc(alloc_size, GFP_NOWAIT);