Skip to contentSkip to conversation

ixj: Fix test in ixj_selfprobe()

PATCH In review Roel Kluin 2 participants 2 messages Oct 6, 2009 – Oct 13, 2009

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 ixj: Fix test in ixj_selfprobe()

Not makes it a bool before the comparison.

---
Was below intended?

drivers/telephony/ixj.c +1 -1
index 40de151..da3c9a0 100644
@@ -6831,7 +6831,7 @@ static int ixj_selfprobe(IXJ *j)
 	} else {
 		switch (j->cardtype) {
 		case QTI_PHONEJACK:
-			if (!j->dsp.low != 0x20) {
+			if (j->dsp.low != 0x20) {
 				j->dsp.high = 0x80;
 				j->dsp.low = 0x20;
 				ixj_WriteDSPCommand(0x3800, j);
#1 lore raw
Quoted 11 lines · On Tue, 06 Oct 2009 17:47:16 +0200 Roel Kluin <[email protected]> wrote:

Not makes it a bool before the comparison.

---
Was below intended?

drivers/telephony/ixj.c +0 -0
index 40de151..da3c9a0 100644

drivers/telephony/ixj.c static int ixj_selfprobe(IXJ *j) · line 6837

Quoted 8 lines
drivers/telephony/ixj.c +1 -1
@@ -6831,7 +6831,7 @@ static int ixj_selfprobe(IXJ *j)
 	} else {
 		switch (j->cardtype) {
 		case QTI_PHONEJACK:
-			if (!j->dsp.low != 0x20) {
+			if (j->dsp.low != 0x20) {
 				j->dsp.high = 0x80;
 				j->dsp.low = 0x20;
 				ixj_WriteDSPCommand(0x3800, j);

gee, I can't tell. Presumably it'd be safer to just delete the test - it's a no-op at present and that code is well-tested, lol.