Skip to contentSkip to conversation

hwmon: Disable s3c-hwmon build for S3C64xx

PATCH New Maurus Cuelenaere 3 participants 4 messages Oct 7, 2009 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): mailman.3211.1254922769.2256.linux-arm-kernel@lists.infradead.org

#1 lore raw

PATCH 1/1 hwmon: Disable s3c-hwmon build for S3C64xx

Op 07-10-09 15:39, linux-arm-kernel-request at lists.infradead.org schreef:

Quoted 14 lines

The s3c-hwmon driver depends on the arch/arm implementation of the core ADC support for the chip. Since the S3C64xx version has not yet been merged disable building of the driver on S3C64xx for now.

---
  drivers/hwmon/Kconfig |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)
drivers/hwmon/Kconfig +0 -0
index 4d0d0cd..87184b5 100644

drivers/hwmon/Kconfig config SENSORS_SHT15

Quoted 9 lines
drivers/hwmon/Kconfig +1 -2
@@ -684,7 +684,7 @@ config SENSORS_SHT15
 
  config SENSORS_S3C
  	tristate "S3C24XX/S3C64XX Inbuilt ADC"
-	depends on ARCH_S3C2410 || ARCH_S3C64XX
+	depends on ARCH_S3C2410
  	help
  	  If you say yes here you get support for the on-board ADCs of
  	  the Samsung S3C24XX or S3C64XX series of SoC
-- 1.6.4.3

Have you seen this?

http://lists.infradead.org/pipermail/linux-arm-kernel/2009-October/001787.html

Regards,

Maurus Cuelenaere

#3 lore raw

PATCH 1/1 hwmon: Disable s3c-hwmon build for S3C64xx

Hi Mark,

Quoted 8 lines · Mark Brown
Quoted 3 lines · Maurus Cuelenaere

Have you seen this?

http://lists.infradead.org/pipermail/linux-arm-kernel/2009-October/001787.html

Yes, but it doesn't look like 2.6.32 material at this point (and the fix patch was originally posted in August).

I thought it'd be merged into the patch adding the driver, that's why I didn't pick it back then. But it did not happen, so I've applied your patch now and will send it to Linus soon.

Signature · 1 line
Jean Delvare
#4 lore raw

PATCH 1/1 hwmon: Disable s3c-hwmon build for S3C64xx

Quoted 3 lines · Jean Delvare

I thought it'd be merged into the patch adding the driver, that's why I didn't pick it back then. But it did not happen, so I've applied your patch now and will send it to Linus soon.

Thanks. The driver patch had already been applied at the time I posted (I noticed the issue through running -next rather than code review).