SN: unsigned cannot be less than 0 in sn_hwperf_ioctl()
PATCH 1/1 SN: unsigned cannot be less than 0 in sn_hwperf_ioctl()
struct sn_hwperf_ioctl_args member arg (u64) cannot be less than 0.
Signed-off-by Roel Kluin <[email protected]>
---
// vi arch/ia64/include/asm/sn/sn2/sn_hwperf.h +73 struct sn_hwperf_ioctl_args {
u64 arg; /* argument, usually an object id */
u64 sz; /* size of transfer */
void *ptr; /* pointer to source/target */
u32 v0; /* second return value */
};
arch/ia64/sn/kernel/sn2/sn_hwperf.c +4 -3
@@ -786,17 +786,18 @@ sn_hwperf_ioctl(struct inode *in, struct file *fp, u32 op, unsigned long arg)break ;case SN_HWPERF_GET_OBJ_NODE : -if (a.sz !=sizeof (u64) || a.arg <0 ) { + i = a.arg; +if (a.sz !=sizeof (u64) || i <0 ) { r = -EINVAL ; goto error; }if ((r =sn_hwperf_enum_objects (&nobj, &objs)) =0 ) { -if (a.arg >= nobj) { +if (i >= nobj) { r = -EINVAL ;vfree (objs); goto error; } -if (objs[(i = a.arg)].id != a.arg) { +if (objs[i].id != a.arg) {for (i =0 ; i < nobj; i++) {if (objs[i].id = a.arg)break ;