TI DaVinci DVEVM: Add Config option for 64 bit Support
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 TI DaVinci DVEVM: Add Config option for 64 bit Support
Quoted 14 lines · s-paulraj at ti.com
From: Sandeep Paulraj <[email protected]>
Adding the
CONFIG_SYS_64BIT_VSPRINTFin the DVEVM config.Signed-off-by Sandeep Paulraj <[email protected]>--- include/configs/davinci_dvevm.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)include/configs/davinci_dvevm.h +0
-0
include/configs/davinci_dvevm.h line 144
Quoted 7 lines
include/configs/davinci_dvevm.h +1
-0@@ -138,6 +138,7 @@#define CONFIG_SYS_NAND_HW_ECC #define CONFIG_SYS_MAX_NAND_DEVICE 1/* Max number of NAND devices */ #define CONFIG_ENV_OFFSET 0x0/* Block 0--not used by bootcode */ +#define CONFIG_SYS_64BIT_VSPRINTF /* needed for nand_util.c */ #define DEF_BOOTM ""#elif defined(CONFIG_SYS_USE_NOR )#ifdef CONFIG_NOR_UART_BOOT
Please add a comment in the commit log why
the change is needed.
Tom
Paulraj
PATCH 1/1 TI DaVinci DVEVM: Add Config option for 64 bit Support
Quoted 30 lines
-----Original Message-----
From: Tom Rix [mailto:tom at bumblecow.com]
Sent: Sunday, October 11, 2009 1:26 PM
To: Paulraj, Sandeep; u-boot at lists.denx.de
Subject: Re: [PATCH] TI DaVinci DVEVM: Add Config option for 64 bit SupportReview
Quoted 10 lines · s-paulraj at ti.com
From: Sandeep Paulraj <[email protected]>
Adding the
CONFIG_SYS_64BIT_VSPRINTFin the DVEVM config.Signed-off-by Sandeep Paulraj <[email protected]>--- include/configs/davinci_dvevm.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)(quoted diff) +0
-0
b/include/configs/davinci_dvevm.hinclude/configs/davinci_dvevm.h line 139
Quoted 6 lines
index f7d2399..b045e80 100644
include/configs/davinci_dvevm.h +0
-0@@ -138,6 +138,7 @@#define CONFIG_SYS_NAND_HW_ECC #define CONFIG_SYS_MAX_NAND_DEVICE 1/* Max number of NAND devices */
include/configs/davinci_dvevm.h line 140
Quoted 1 line
include/configs/davinci_dvevm.h +0
-0#define CONFIG_ENV_OFFSET 0x0/* Block 0--not used by bootcode */
Quoted 8 lines
include/configs/davinci_dvevm.h line 144
Quoted 4 lines
include/configs/davinci_dvevm.h +1
-0+#define CONFIG_SYS_64BIT_VSPRINTF /* needed for nand_util.c */ #define DEF_BOOTM ""#elif defined(CONFIG_SYS_USE_NOR )#ifdef CONFIG_NOR_UART_BOOT Please add a comment in the commit log why the change is needed.
Tom
OK. I'll add the comment and push.
The reason is without that when we want to say erase a NAND block, it will give weird outputs like erasing block at 0x00000000.
So basically the MTD NAND driver will find the bad block but we get this incorrect message as this option is not set.
Other symptoms are after for e.g we complete an erase NAND operation, we will get a message which says, 0x4026432% completed or something like that.
Thanks,
Sandeep
PATCH 1/1 TI DaVinci DVEVM: Add Config option for 64 bit Support
Quoted 39 lines · Sandeep
Quoted 28 lines
-----Original Message-----
From: Tom Rix [mailto:tom at bumblecow.com]
Sent: Sunday, October 11, 2009 1:26 PM
To: Paulraj, Sandeep; u-boot at lists.denx.de
Subject: Re: [PATCH] TI DaVinci DVEVM: Add Config option for 64 bit SupportReview
Quoted 10 lines · s-paulraj at ti.com
From: Sandeep Paulraj <[email protected]>
Adding the
CONFIG_SYS_64BIT_VSPRINTFin the DVEVM config.Signed-off-by Sandeep Paulraj <[email protected]>--- include/configs/davinci_dvevm.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)(quoted diff) +0
-0
b/include/configs/davinci_dvevm.hinclude/configs/davinci_dvevm.h line 139
Quoted 6 lines
index f7d2399..b045e80 100644
include/configs/davinci_dvevm.h +0
-0@@ -138,6 +138,7 @@#define CONFIG_SYS_NAND_HW_ECC #define CONFIG_SYS_MAX_NAND_DEVICE 1/* Max number of NAND devices */
include/configs/davinci_dvevm.h line 140
Quoted 1 line
include/configs/davinci_dvevm.h +0
-0#define CONFIG_ENV_OFFSET 0x0/* Block 0--not used by bootcode Quoted 8 lines
*/
include/configs/davinci_dvevm.h line 144
Quoted 4 lines
include/configs/davinci_dvevm.h +1
-0+#define CONFIG_SYS_64BIT_VSPRINTF /* needed for nand_util.c */ #define DEF_BOOTM ""#elif defined(CONFIG_SYS_USE_NOR )#ifdef CONFIG_NOR_UART_BOOT Please add a comment in the commit log why the change is needed.
TomOK. I'll add the comment and push.
Quoted 11 lines
The reason is without that when we want to say erase a NAND block, it will give weird outputs like erasing block at
0x00000000.So basically the MTD NAND driver will find the bad block but we get this incorrect message as this option is not set.
Other symptoms are after for e.g we complete an erase NAND operation, we will get a message which says, 0x4026432% completed or something like that.
Thanks,
Sandeep
This is a good reason!
It says what the problem is and what this change to the config will correct.
Add the same comment to other similar patches you submitted and they will all be good to go.
Ack
Tom