Skip to contentSkip to conversation

tracing/filters: Fix memory leak when setting a filter

PATCH In review Li Zefan 1 participant 2 messages Oct 13, 2009 Tracing

lore
Share & tools
lore

Li Zefan

author
#0 lore raw

PATCH 1/1 tracing/filters: Fix memory leak when setting a filter

Every time we set a filter, we leak memory allocated by postfix_append_operand() and postfix_append_op().

---
 kernel/trace/trace_events_filter.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
kernel/trace/trace_events_filter.c +2 -1
index 2324578..98a6cc5 100644
@@ -933,8 +933,9 @@ static void postfix_clear(struct filter_parse_state *ps)
 
 	while (!list_empty(&ps->postfix)) {
 		elt = list_first_entry(&ps->postfix, struct postfix_elt, list);
-		kfree(elt->operand);
 		list_del(&elt->list);
+		kfree(elt->operand);
+		kfree(elt);
 	}
 }
 
Signature · 1 line
1.6.3
#1 lore raw
Commit-ID:  8ad807318fcd62aba0e18c7c7fbfcc1af3fcdbab
Gitweb:     http://git.kernel.org/tip/8ad807318fcd62aba0e18c7c7fbfcc1af3fcdbab
Author:     Li Zefan <[email protected]>
AuthorDate: Tue, 13 Oct 2009 09:28:57 +0800
Committer:  Ingo Molnar <[email protected]>
CommitDate: Tue, 13 Oct 2009 08:05:17 +0200

tracing/filters: Fix memory leak when setting a filter

Every time we set a filter, we leak memory allocated by postfix_append_operand() and postfix_append_op().

Cc Steven Rostedt <[email protected]>
Cc Frederic Weisbecker <[email protected]>
Cc Tom Zanussi <[email protected]>
Cc <[email protected]> # for v2.6.31.x

LKML-Reference: <[email protected]>

---
 kernel/trace/trace_events_filter.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
kernel/trace/trace_events_filter.c +2 -1
index 2324578..98a6cc5 100644
@@ -933,8 +933,9 @@ static void postfix_clear(struct filter_parse_state *ps)
 
 	while (!list_empty(&ps->postfix)) {
 		elt = list_first_entry(&ps->postfix, struct postfix_elt, list);
-		kfree(elt->operand);
 		list_del(&elt->list);
+		kfree(elt->operand);
+		kfree(elt);
 	}
 }