Skip to contentSkip to conversation

staging: Complete sched.h removal from interrupt.h

PATCH In review Jeff Mahoney 2 participants 3 messages Oct 12, 2009 – Oct 13, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: Complete sched.h removal from interrupt.h

Commit d43c36dc removed sched.h from interrupt.h and distributed sched.h to users which needed it. This finishes it up for staging.

---
 drivers/staging/b3dfg/b3dfg.c              |    1 +
 drivers/staging/hv/osd.c                   |    1 +
 drivers/staging/iio/industrialio-core.c    |    2 ++
 drivers/staging/poch/poch.c                |    1 +
 drivers/staging/sep/sep_driver.c           |    1 +
 drivers/staging/vme/bridges/vme_ca91cx42.c |    1 +
 drivers/staging/vme/bridges/vme_tsi148.c   |    1 +
 7 files changed, 8 insertions(+)
drivers/staging/b3dfg/b3dfg.c +1 -0
@@ -33,6 +33,7 @@
 #include <linux/cdev.h>
 #include <linux/list.h>
 #include <linux/poll.h>
+#include <linux/sched.h>
 #include <linux/wait.h>
 #include <linux/mm.h>
 #include <linux/uaccess.h>
drivers/staging/hv/osd.c +1 -0
@@ -30,6 +30,7 @@
 #include <linux/ioport.h>
 #include <linux/irq.h>
 #include <linux/interrupt.h>
+#include <linux/sched.h>
 #include <linux/wait.h>
 #include <linux/spinlock.h>
 #include <linux/workqueue.h>
drivers/staging/iio/industrialio-core.c +2 -0
@@ -19,6 +19,8 @@
 #include <linux/interrupt.h>
 #include <linux/poll.h>
 #include <linux/cdev.h>
+#include <linux/sched.h>
+#include <linux/wait.h>
 #include "iio.h"
 #include "trigger_consumer.h"
 
drivers/staging/poch/poch.c +1 -0
@@ -20,6 +20,7 @@
 #include <linux/init.h>
 #include <linux/ioctl.h>
 #include <linux/io.h>
+#include <linux/sched.h>
 
 #include "poch.h"
 
drivers/staging/sep/sep_driver.c +1 -0
@@ -38,6 +38,7 @@
 #include <linux/mm.h>
 #include <linux/poll.h>
 #include <linux/wait.h>
+#include <linux/sched.h>
 #include <linux/pci.h>
 #include <linux/firmware.h>
 #include <asm/ioctl.h>
drivers/staging/vme/bridges/vme_ca91cx42.c +1 -0
@@ -25,6 +25,7 @@
 #include <linux/poll.h>
 #include <linux/interrupt.h>
 #include <linux/spinlock.h>
+#include <linux/sched.h>
 #include <asm/time.h>
 #include <asm/io.h>
 #include <asm/uaccess.h>
drivers/staging/vme/bridges/vme_tsi148.c +1 -0
@@ -25,6 +25,7 @@
 #include <linux/dma-mapping.h>
 #include <linux/interrupt.h>
 #include <linux/spinlock.h>
+#include <linux/sched.h>
 #include <asm/time.h>
 #include <asm/io.h>
 #include <asm/uaccess.h>
Signature · 2 lines
Jeff Mahoney
SUSE Labs
#1 lore raw

Hi Jeff,

Quoted 2 lines
 drivers/staging/iio/industrialio-core.c    |    2 ++

...

drivers/staging/iio/industrialio-core.c line 26

Quoted 11 lines
drivers/staging/iio/industrialio-core.c +2 -0
@@ -19,6 +19,8 @@
 #include <linux/interrupt.h>
 #include <linux/poll.h>
 #include <linux/cdev.h>
+#include <linux/sched.h>
+#include <linux/wait.h>
 #include "iio.h"
 #include "trigger_consumer.h"
 

Greg has already picked up a patch for this one, but might make more sense to drop
that and merge all these fixes as one. Original patch only added sched.h though.
Is wait.h due to a similar issue that is going to bite in the future? (could chase this
down but as you added it seemed easier to ask!)

Thanks,

Jonathan

#2 lore raw
Quoted 14 lines · Jonathan Cameron

Hi Jeff,

Quoted 2 lines
 drivers/staging/iio/industrialio-core.c    |    2 ++

...

Quoted 10 lines
drivers/staging/iio/industrialio-core.c +2 -0
@@ -19,6 +19,8 @@
 #include <linux/interrupt.h>
 #include <linux/poll.h>
 #include <linux/cdev.h>
+#include <linux/sched.h>
+#include <linux/wait.h>
 #include "iio.h"
 #include "trigger_consumer.h"
Quoted 8 lines
Quoted 1 line

Greg has already picked up a patch for this one, but might make more sense to drop
that and merge all these fixes as one. Original patch only added sched.h though.
Is wait.h due to a similar issue that is going to bite in the future? (could chase this
down but as you added it seemed easier to ask!)

Nope, I think iio was probably the first driver I saw this build failure in and observed that it was in the wait queue code. It's not necessary, though it doesn't cost anything either since wait.h is already included somewhere.

-Jeff

Signature · 2 lines
Jeff Mahoney
SUSE Labs