PCI legacy I/O port free driver - Making MegaRAID SAS driver

PATCH In review Noriyuki Fujii 3 participants 4 messages Oct 14, 2009 – Dec 1, 2009 SCSI

lore

Share & tools

lore

Noriyuki Fujii

author

2009-10-14 01:05 UTC #0 lore raw

PATCH 1/1 PCI legacy I/O port free driver - Making MegaRAID SAS driver

Hi,

Here's my 2nd try of the following post.

http://marc.info/?l=linux-scsi&m=124962265606425&w=2

I made a patch for MegaRAID sas driver to make PCI legacy I/O port free.

The way to make PCI legacy I/O port free is the same as Fusion-MPT driver's and it has been merged into 2.6.30.4.

This has already been fixed in e1000 and lpfc.

As a result of the above, the driver can handle its device even when there are a huge number of PCI devices being used on the system and no I/O port region assigned to the device.

I'm not in the linux-scsi mailing list.
Please reply to the following address.

E-Mail: [email protected]

Thanks,
Noriyuki Fujii

megaraid_sasMod.c renamed from megaraid_sasOrg.c +9 -5

@@ -2573,7 +2573,9 @@ static int megasas_init_mfi(struct megas
 		instance->base_addr = pci_resource_start(instance->pdev, 0);
 	}
 
-	if (pci_request_regions(instance->pdev, "megasas: LSI")) {
+        if (pci_request_selected_regions(instance->pdev,
+					 pci_select_bars(instance->pdev, IORESOURCE_MEM),
+					 "megasas: LSI")) {
 		printk(KERN_DEBUG "megasas: IO memory region busy!\n");
 		return -EBUSY;
 	}

@@ -2719,7 +2721,8 @@ static int megasas_init_mfi(struct megas
 	iounmap(instance->reg_set);
 
       fail_ioremap:
-	pci_release_regions(instance->pdev);
+        pci_release_selected_regions(instance->pdev,
+				     pci_select_bars(instance->pdev, IORESOURCE_MEM));
 
 	return -EINVAL;
 }

@@ -2739,7 +2742,8 @@ static void megasas_release_mfi(struct m
 
 	iounmap(instance->reg_set);
 
-	pci_release_regions(instance->pdev);
+        pci_release_selected_regions(instance->pdev,
+				     pci_select_bars(instance->pdev, IORESOURCE_MEM));
 }
 
 /**

@@ -3049,7 +3053,7 @@ megasas_probe_one(struct pci_dev *pdev, 
 	/*
 	 * PCI prepping: enable device set bus mastering and dma mask
 	 */
-	rval = pci_enable_device(pdev);
+        rval = pci_enable_device_mem(pdev);
 
 	if (rval) {
 		return rval;

@@ -3343,7 +3347,7 @@ megasas_resume(struct pci_dev *pdev)
 	/*
 	 * PCI prepping: enable device set bus mastering and dma mask
 	 */
-	rval = pci_enable_device(pdev);
+        rval = pci_enable_device_mem(pdev);
 
 	if (rval) {
 		printk(KERN_INFO "megasas: Enable device failed\n");

Yang, Bo

2009-11-30 19:29 UTC #1 lore raw

Noriyuki,

The patch looks good for us. ACK.

Bo Yang

-----Original Message-----
From: Noriyuki Fujii [mailto:[email protected]]
Sent: Tuesday, October 13, 2009 9:04 PM
To: DL-MegaRAID Linux; [email protected]
Subject: [PATCH 2nd try] PCI legacy I/O port free driver - Making MegaRAID SAS driver

Hi,

Here's my 2nd try of the following post.

http://marc.info/?l=linux-scsi&m=124962265606425&w=2

I made a patch for MegaRAID sas driver to make PCI legacy I/O port free.

The way to make PCI legacy I/O port free is the same as Fusion-MPT driver's and it has been merged into 2.6.30.4.

This has already been fixed in e1000 and lpfc.

As a result of the above, the driver can handle its device even when there are a huge number of PCI devices being used on the system and no I/O port region assigned to the device.

I'm not in the linux-scsi mailing list.
Please reply to the following address.

E-Mail: [email protected]

Thanks,
Noriyuki Fujii

James Bottomley

2009-11-30 20:49 UTC #2 lore raw

In reply to Noriyuki Fujii

Quoted 11 lines · Noriyuki Fujii

Hi,
Here's my 2nd try of the following post.
http://marc.info/?l=linux-scsi&m=124962265606425&w=2
I made a patch for MegaRAID sas driver to make PCI legacy I/O port free.
The way to make PCI legacy I/O port free is the same as Fusion-MPT driver's and it has been merged into 2.6.30.4.

Quoted 8 lines

This has already been fixed in e1000 and lpfc.
As a result of the above, the driver can handle its device even when there are a huge number of PCI devices being used on the system and no I/O port region assigned to the device.
I'm not in the linux-scsi mailing list.
Please reply to the following address.

I need a Signed-off-by for this (see Documentation/SubmittingPatches).

Quoted 10 lines

E-Mail: [email protected]
Thanks,
Noriyuki Fujii
plain text document attachment (linux-2.6-scsi-megaraid-sas-make-legacy-i-o-port-free.patch)

megaraid_sasMod.c static int megasas_init_mfi(struct megas · line 2576

Quoted 5 lines

megaraid_sasMod.c renamed from megaraid_sasOrg.c +1 -1

@@ -2573,7 +2573,9 @@ static int megasas_init_mfi(struct megas
 		instance->base_addr = pci_resource_start(instance->pdev, 0);
 	}
 
-	if (pci_request_regions(instance->pdev, "megasas: LSI")) {
+        if (pci_request_selected_regions(instance->pdev,

This is taking away a tab and substituting spaces ... our style is to use tabs. You can run the patch through scripts/checkpatch.pl and it will advise on problems like this.

James

Noriyuki Fujii

author

2009-12-01 01:16 UTC #3 lore raw

James,

Quoted 5 lines

I need a Signed-off-by for this (see Documentation/SubmittingPatches).
This is taking away a tab and substituting spaces ... our style is to use tabs. You can run the patch through scripts/checkpatch.pl and it will advise on problems like this.

I've already posted the patch obeying the community rules. Could you see the following URL?

http://marc.info/?l=linux-scsi&m=125870212508167&w=2

Thanks,
Noriyuki Fujii

Quoted 52 lines · Noriyuki Fujii

Quoted 11 lines
Hi,
Here's my 2nd try of the following post.
http://marc.info/?l=linux-scsi&m=124962265606425&w=2
I made a patch for MegaRAID sas driver to make PCI legacy I/O port free.
The way to make PCI legacy I/O port free is the same as Fusion-MPT driver's and it has been merged into 2.6.30.4.
Quoted 8 lines
This has already been fixed in e1000 and lpfc.
As a result of the above, the driver can handle its device even when there are a huge number of PCI devices being used on the system and no I/O port region assigned to the device.
I'm not in the linux-scsi mailing list.
Please reply to the following address.
I need a Signed-off-by for this (see Documentation/SubmittingPatches).
Quoted 10 lines
E-Mail: [email protected]
Thanks,
Noriyuki Fujii
plain text document attachment (linux-2.6-scsi-megaraid-sas-make-legacy-i-o-port-free.patch)
megaraid_sasMod.c static int megasas_init_mfi(struct megas · line 2576
Quoted 5 lines
megaraid_sasMod.c renamed from megaraid_sasOrg.c +1 -1
@@ -2573,7 +2573,9 @@ static int megasas_init_mfi(struct megas
 		instance->base_addr = pci_resource_start(instance->pdev, 0);
 	}
 
-	if (pci_request_regions(instance->pdev, "megasas: LSI")) {
+        if (pci_request_selected_regions(instance->pdev,
This is taking away a tab and substituting spaces ... our style is to use tabs. You can run the patch through scripts/checkpatch.pl and it will advise on problems like this.
James
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html