Skip to contentSkip to conversation

TI DaVinci: Fix DM6467 EVM Compilation Warning

PATCH New s-paulraj at ti.com 3 participants 3 messages Oct 13, 2009 – Oct 14, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 TI DaVinci: Fix DM6467 EVM Compilation Warning

From: Sandeep Paulraj <[email protected]>

Due to new TI boards being added to U-Boot, the hardware.h is getting very messy. The warning being fixed is due to the EMIF addresses being redefined.

The long term solution(after 2009.11) to this is to have SOC specific header files.

---
 include/asm-arm/arch-davinci/hardware.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/asm-arm/arch-davinci/hardware.h +2 -0
index ac32510..acf12ea 100644
@@ -71,10 +71,12 @@ typedef volatile unsigned int *	dv_reg_p;
 #define DAVINCI_SPI_BASE			(0x01c66800)
 #define DAVINCI_GPIO_BASE			(0x01c67000)
 #define DAVINCI_VPSS_REGS_BASE			(0x01c70000)
+#if !defined(CONFIG_SOC_DM646X)
 #define DAVINCI_ASYNC_EMIF_DATA_CE0_BASE	(0x02000000)
 #define DAVINCI_ASYNC_EMIF_DATA_CE1_BASE	(0x04000000)
 #define DAVINCI_ASYNC_EMIF_DATA_CE2_BASE	(0x06000000)
 #define DAVINCI_ASYNC_EMIF_DATA_CE3_BASE	(0x08000000)
+#endif
 #define DAVINCI_DDR_BASE			(0x80000000)
 
 #ifdef CONFIG_SOC_DM644X
Signature · 1 line
1.6.0.4
#1 lore raw

PATCH 1/1 TI DaVinci: Fix DM6467 EVM Compilation Warning

Quoted 21 lines · s-paulraj at ti.com

From: Sandeep Paulraj <[email protected]>

Due to new TI boards being added to U-Boot, the hardware.h is getting very messy. The warning being fixed is due to the EMIF addresses being redefined.

The long term solution(after 2009.11) to this is to have SOC specific header files.

---
 include/asm-arm/arch-davinci/hardware.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/asm-arm/arch-davinci/hardware.h +0 -0
index ac32510..acf12ea 100644
@@ -71,10 +71,12 @@ typedef volatile unsigned int *	dv_reg_p;
 #define DAVINCI_SPI_BASE			(0x01c66800)
 #define DAVINCI_GPIO_BASE			(0x01c67000)

include/asm-arm/arch-davinci/hardware.h typedef volatile unsigned int * dv_reg_p; · line 82

Quoted 10 lines
include/asm-arm/arch-davinci/hardware.h +2 -0
 #define DAVINCI_VPSS_REGS_BASE			(0x01c70000)
+#if !defined(CONFIG_SOC_DM646X)
 #define DAVINCI_ASYNC_EMIF_DATA_CE0_BASE	(0x02000000)
 #define DAVINCI_ASYNC_EMIF_DATA_CE1_BASE	(0x04000000)
 #define DAVINCI_ASYNC_EMIF_DATA_CE2_BASE	(0x06000000)
 #define DAVINCI_ASYNC_EMIF_DATA_CE3_BASE	(0x08000000)
+#endif
 #define DAVINCI_DDR_BASE			(0x80000000)
 
 #ifdef CONFIG_SOC_DM644X

You have already pushed this so mostly this is for the future.. This can be cleaned up so the default #defines are set only if they are not already defined by the board.
Or handled with the board files are you are planning. Tom

#2 lore raw

PATCH 1/1 TI DaVinci: Fix DM6467 EVM Compilation Warning

Quoted 42 lines

-----Original Message-----
From: Tom Rix [mailto:tom at bumblecow.com]
Sent: Tuesday, October 13, 2009 9:49 PM
To: Paulraj, Sandeep
Cc: u-boot at lists.denx.de
Subject: Re: [U-Boot] [PATCH] TI DaVinci: Fix DM6467 EVM Compilation Warning

include/asm-

Quoted 15 lines · s-paulraj at ti.com

From: Sandeep Paulraj <[email protected]>

Due to new TI boards being added to U-Boot, the hardware.h is getting very messy. The warning being fixed is due to the EMIF addresses being redefined.

The long term solution(after 2009.11) to this is to have SOC specific header files.

---
 include/asm-arm/arch-davinci/hardware.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)
include/asm- renamed from include/asm-arm/arch-davinci/hardware.h +0 -0

arm/arch-davinci/hardware.h

Quoted 15 lines

index ac32510..acf12ea 100644

include/asm-arm/arch-davinci/hardware.h +2 -0
@@ -71,10 +71,12 @@ typedef volatile unsigned int *	dv_reg_p;
 #define DAVINCI_SPI_BASE			(0x01c66800)
 #define DAVINCI_GPIO_BASE			(0x01c67000)
 #define DAVINCI_VPSS_REGS_BASE			(0x01c70000)
+#if !defined(CONFIG_SOC_DM646X)
 #define DAVINCI_ASYNC_EMIF_DATA_CE0_BASE	(0x02000000)
 #define DAVINCI_ASYNC_EMIF_DATA_CE1_BASE	(0x04000000)
 #define DAVINCI_ASYNC_EMIF_DATA_CE2_BASE	(0x06000000)
 #define DAVINCI_ASYNC_EMIF_DATA_CE3_BASE	(0x08000000)
+#endif
 #define DAVINCI_DDR_BASE			(0x80000000)
 
Quoted 6 lines

include/asm-arm/arch-davinci/hardware.h typedef volatile unsigned int * dv_reg_p; · line 82

Quoted 1 line
include/asm-arm/arch-davinci/hardware.h +0 -0
 #ifdef CONFIG_SOC_DM644X

You have already pushed this so mostly this is for the future.. This can be cleaned up so the default #defines are set only if they are not already defined by the board.
Or handled with the board files are you are planning.

I will clean it up soon. But this will be considered a feature and thus cannot make it to 2009.11; hence this quick fix solution.

In fact I might work on the clean up this weekend and even send for review but even if accepted, I will have to keep it in my next

Quoted 1 line

Tom

Sandeep