avr32 portmux : fix incorrect port mask
PATCH 1/1 avr32 portmux : fix incorrect port mask
The portmux peripheral pin selection code used when setting up the MACB1 ethernet port has a small (but critical !!) typo.
--- cpu/at32ap/at32ap700x/portmux.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
cpu/at32ap/at32ap700x/portmux.c +1 -1
@@ -122,7 +122,7 @@ void portmux_enable_macb1(unsigned long flags, unsigned long drive_strength) portd_mask |= (1 <<15 );/* SPD */ /* REVISIT: Some pins are probably pure outputs */ -portmux_select_peripheral (PORTMUX_PORT_D , portc_mask, +portmux_select_peripheral (PORTMUX_PORT_D , portd_mask,PORTMUX_FUNC_B ,PORTMUX_BUSKEEPER );portmux_select_peripheral (PORTMUX_PORT_C , portc_mask,PORTMUX_FUNC_B ,PORTMUX_BUSKEEPER );
PATCH 1/1 avr32 portmux : fix incorrect port mask
Quoted 3 lines · On Mon, 19 Oct 2009 10:49:00 +0100 Mark Jackson <[email protected]> wrote:
The portmux peripheral pin selection code used when setting up the MACB1 ethernet port has a small (but critical !!) typo.
It does? Where is this fixed in the patch?
Quoted 10 lines
Signed-off-by Mark Jackson <[email protected]>--- cpu/at32ap/at32ap700x/portmux.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)cpu/at32ap/at32ap700x/portmux.c +0
-0
cpu/at32ap/at32ap700x/portmux.c void portmux_enable_macb1(unsigned long flags, unsigned long drive_strength) · line 125
Quoted 5 lines
cpu/at32ap/at32ap700x/portmux.c +1
-1@@ -122,7 +122,7 @@ void portmux_enable_macb1(unsigned long flags, unsigned long drive_strength) portd_mask |= (1 <<15 );/* SPD */ /* REVISIT: Some pins are probably pure outputs */ - portmux_select_peripheral(PORTMUX_PORT_D, portc_mask, + portmux_select_peripheral(PORTMUX_PORT_D, portd_mask,
This replaces portc_mask with portd_mask, which looks indeed correcter.
<snipp>
Signature · 2 lines
Best regards, Hans-Christian Egtvedt
PATCH 1/1 avr32 portmux : fix incorrect port mask
Quoted 8 lines · Hans-Christian Egtvedt
Quoted 3 lines · On Mon, 19 Oct 2009 10:49:00 +0100 Mark Jackson <[email protected]> wrote:
The portmux peripheral pin selection code used when setting up the MACB1 ethernet port has a small (but critical !!) typo.
It does? Where is this fixed in the patch?
Not sure what you mean ...
Quoted 13 lines
Quoted 13 lines
Signed-off-by Mark Jackson <[email protected]>--- cpu/at32ap/at32ap700x/portmux.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)cpu/at32ap/at32ap700x/portmux.c +0
-0@@ -122,7 +122,7 @@ void portmux_enable_macb1(unsigned long flags, unsigned long drive_strength) portd_mask |= (1 <<15 );/* SPD */
Quoted 5 lines
cpu/at32ap/at32ap700x/portmux.c void portmux_enable_macb1(unsigned long flags, unsigned long drive_strength) · line 125
Quoted 3 lines
cpu/at32ap/at32ap700x/portmux.c +1
-1/* REVISIT: Some pins are probably pure outputs */ - portmux_select_peripheral(PORTMUX_PORT_D, portc_mask, + portmux_select_peripheral(PORTMUX_PORT_D, portd_mask,This replaces
portc_maskwithportd_mask, which looks indeed correcter.
... and this looks like a simple typo to me !?!
Mark
PATCH 1/1 avr32 portmux : fix incorrect port mask
Quoted 4 lines · On Mon, 19 Oct 2009 11:35:40 +0100 Mark Jackson <[email protected]> wrote:
Quoted 3 lines · Hans-Christian Egtvedt
On Mon, 19 Oct 2009 10:49:00 +0100
Mark Jackson <[email protected]> wrote:
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
The portmux peripheral pin selection code used when setting up the MACB1 ethernet port has a small (but critical !!) typo.
It does? Where is this fixed in the patch?
Not sure what you mean ...
Aha, rereading I get it, I thought you were fixing an actual "!!" typo somewhere in the code.
<snipp>
Signature · 2 lines
Best regards, Hans-Christian Egtvedt
PATCH 1/1 avr32 portmux : fix incorrect port mask
Quoted 10 lines · Hans-Christian Egtvedt
Quoted 7 lines · On Mon, 19 Oct 2009 11:35:40 +0100 Mark Jackson <[email protected]> wrote:
Quoted 6 lines · Hans-Christian Egtvedt
Quoted 3 lines · On Mon, 19 Oct 2009 10:49:00 +0100 Mark Jackson <[email protected]> wrote:
The portmux peripheral pin selection code used when setting up the MACB1 ethernet port has a small (but critical !!) typo.
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
It does? Where is this fixed in the patch?
Not sure what you mean ...
Aha, rereading I get it, I thought you were fixing an actual "!!" typo somewhere in the code.
Ho, ho ... I guess my comment is a bit misleading :-)