Skip to contentSkip to conversation

ep93xx: remove dead code in ep93xx_gpio_ab_irq_handler()

PATCH New H Hartley Sweeten 2 participants 2 messages Oct 13, 2009 – Oct 21, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ep93xx: remove dead code in ep93xx_gpio_ab_irq_handler()

Remove unnecessary code in ep93xx_gpio_ab_irq_handler().

The desc calculation for gpio port B was left in when the following commit was merged.

commit d8aa0251f12546e9bd1e9ee1d9782d6492819a04

Author: Dmitry Baryshkov <[email protected]>
Date:   Thu Oct 9 13:36:24 2008 +0100
    [ARM] 5298/1: Drop desc_handle_irq()

It's not needed so remove it.

---

arch/arm/mach-ep93xx/core.c +0 -1
index f95dc16..b4357c3 100644
@@ -206,7 +206,6 @@ static void ep93xx_gpio_ab_irq_handler(unsigned int irq, struct irq_desc *desc)
 	for (i = 0; i < 8; i++) {
 		if (status & (1 << i)) {
 			int gpio_irq = gpio_to_irq(EP93XX_GPIO_LINE_B(0)) + i;
-			desc = irq_desc + gpio_irq;
 			generic_handle_irq(gpio_irq);
 		}
 	} 
#1 lore raw

PATCH 1/1 ep93xx: remove dead code in ep93xx_gpio_ab_irq_handler()

Quoted 24 lines · H Hartley Sweeten

Remove unnecessary code in ep93xx_gpio_ab_irq_handler().

The desc calculation for gpio port B was left in when the following commit was merged.

commit d8aa0251f12546e9bd1e9ee1d9782d6492819a04

Author: Dmitry Baryshkov <[email protected]>
Date:   Thu Oct 9 13:36:24 2008 +0100
    [ARM] 5298/1: Drop desc_handle_irq()

It's not needed so remove it.

---

arch/arm/mach-ep93xx/core.c +0 -0
index f95dc16..b4357c3 100644

arch/arm/mach-ep93xx/core.c static void ep93xx_gpio_ab_irq_handler(unsigned int irq, struct irq_desc *desc) · line 211

Quoted 7 lines
arch/arm/mach-ep93xx/core.c +0 -1
@@ -206,7 +206,6 @@ static void ep93xx_gpio_ab_irq_handler(unsigned int irq, struct irq_desc *desc)
 	for (i = 0; i < 8; i++) {
 		if (status & (1 << i)) {
 			int gpio_irq = gpio_to_irq(EP93XX_GPIO_LINE_B(0)) + i;
-			desc = irq_desc + gpio_irq;
 			generic_handle_irq(gpio_irq);
 		}
 	} 

~Ryan

Signature · 7 lines
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon         		5 Amuri Park, 404 Barbadoes St
ryan at bluewatersys.com         	PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com	New Zealand
Phone: +64 3 3779127		Freecall: Australia 1800 148 751
Fax:   +64 3 3779135			  USA 1800 261 2934