VLAN does not work with niu driver
Subsystems (2)
PATCH 1/1 VLAN does not work with niu driver
Signature · 1 line
--
Quoted 1 line
From
f301748d3156437d65305f14288c7d5711861980Mon Sep 17 00:00:00 2001
From: Joyce Yu <[email protected]>
Date: Wed, 21 Oct 2009 05:35:46 -0700
Subject: [PATCH] VLAN_ETH_HLEN should be used to make sure that the whole MAC header was copied to the head buffer in the Vlan packets case
--- drivers/net/niu.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/niu.c +1 -1
@@ -3545,7 +3545,7 @@ static int niu_process_rx_pkt(struct napi_struct *napi, struct niu *np, rp->rcr_index = index;skb_reserve (skb,NET_IP_ALIGN ); -__pskb_pull_tail (skb,min (len,NIU_RXPULL_MAX )); +__pskb_pull_tail (skb,min (len,VLAN_ETH_HLEN )); rp->rx_packets++; rp->rx_bytes += skb->len;
Signature · 1 line
1.6.4
David Miller
maintainerYou still forgot your Signed-off-by: tag...
It was in the patch. Was an empty line needed after the body of the explanation? I will send out one with an empty line between body of the explanation and signed-off-by tag.
Thanks,
Joyce
From f301748d3156437d65305f14288c7d5711861980 Mon Sep 17 00:00:00 2001
From: Joyce Yu <[email protected]>
Date: Wed, 21 Oct 2009 05:35:46 -0700
Subject: [PATCH] VLAN_ETH_HLEN should be used to make sure that the whole MAC header was copied to the head buffer in the Vlan packets case
--- drivers/net/niu.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/net/niu.c +1 -1
@@ -3545,7 +3545,7 @@ static int niu_process_rx_pkt(struct napi_struct *napi, struct niu *np, rp->rcr_index = index;skb_reserve (skb,NET_IP_ALIGN ); -__pskb_pull_tail (skb,min (len,NIU_RXPULL_MAX )); +__pskb_pull_tail (skb,min (len,VLAN_ETH_HLEN )); rp->rx_packets++; rp->rx_bytes += skb->len;
Quoted 5 lines · David Miller
You still forgot your Signed-off-by: tag...
--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
David Miller
maintainerFrom: Joyce Yu <[email protected]>
Date: Wed, 21 Oct 2009 16:28:45 -0700
Quoted 3 lines
It was in the patch. Was an empty line needed after the body of the explanation? I will send out one with an empty line between body of the explanation and signed-off-by tag.
It should be of the form:
--------------------
Subject: Summary description of patch.
Full patch description.
The patch.
--------------------