airo: Reorder tests, check bounds before element

PATCH New Roel Kluin 1 participant 1 message Oct 26, 2009 Networking drivers (wireless)

lore

Share & tools

lore

Roel Kluin

author

2009-10-26 14:17 UTC #0 lore raw

PATCH 1/1 airo: Reorder tests, check bounds before element

Test whether index is within bounds before reading the element

Signed-off-by Roel Kluin <[email protected]>

---
 drivers/net/wireless/airo.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

drivers/net/wireless/airo.c +2 -3

index 7116a1a..abf896a 100644
@@ -4790,9 +4790,8 @@ static int proc_stats_rid_open( struct inode *inode,
 static int get_dec_u16( char *buffer, int *start, int limit ) {
 	u16 value;
 	int valid = 0;
-	for( value = 0; buffer[*start] >= '0' &&
-		     buffer[*start] <= '9' &&
-		     *start < limit; (*start)++ ) {
+	for (value = 0; *start < limit && buffer[*start] >= '0' &&
+			buffer[*start] <= '9'; (*start)++) {
 		valid = 1;
 		value *= 10;
 		value += buffer[*start] - '0';