can: sja1000: fix bug using library functions for skb allocation
Subsystems (3)
PATCH 1/1 can: sja1000: fix bug using library functions for skb allocation
Commit 7b6856a0 "can: provide library functions for skb allocation" did not properly remove two lines of the SJA1000 driver resulting in a 'skb_over_panic' when calling skb_put, as reported by Kurt.
Signed-off-by Kurt Van Dijck <[email protected]>
Signed-off-by Wolfgang Grandegger <[email protected]>
--- drivers/net/can/sja1000/sja1000.c | 2 -- 1 file changed, 2 deletions(-)
drivers/net/can/sja1000/sja1000.c +0 -2
@@ -321,8 +321,6 @@ static void sja1000_rx(struct net_deviceif (fi &FI_RTR ) id |=CAN_RTR_FLAG ; - cf = (struct can_frame *)skb_put (skb,sizeof (struct can_frame )); -memset (cf,0 ,sizeof (struct can_frame )); cf->can_id = id; cf->can_dlc = dlc;for (i =0 ; i < dlc; i++)
From: Wolfgang Grandegger <[email protected]>
Date: Mon, 26 Oct 2009 16:46:12 +0100
Quoted 6 lines
Commit
7b6856a0"can: provide library functions for skb allocation" did not properly remove two lines of the SJA1000 driver resulting in a 'skb_over_panic' when callingskb_put, as reported by Kurt.Signed-off-by Kurt Van Dijck <[email protected]>Signed-off-by Wolfgang Grandegger <[email protected]>
Applied, thanks.