gitk: fix typo when diffing committed -> staged
PATCH 1/1 gitk: fix typo when diffing committed -> staged
When highlighting a commit, using the context menu over the staged changes and then selecting "Diff this -> selected" the diff was empty. The same happened when highlighting the staged changes and using "Diff selected -> this" over a commit.
Signed-off-by Jens Lehmann <[email protected]>
---
I became aware of this issue while testing the submodule patch sent earlier. Looks just like a copy & paste typo.
gitk-git/gitk | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
gitk-git/gitk +1 -1
@@ -7224,7 +7224,7 @@ proc diffcmd {ids flags} { set cmd [concat | git diff-index --cached $flags] if {[llength $ids] > 1} { # comparing index with specific revision - if {$i == 0} { + if {$j == 0} { lappend cmd -R [lindex $ids 1] } else { lappend cmd [lindex $ids 0]
Signature · 1 line
1.6.5.2.181.gd6f41.dirty
Paul Mackerras
AppliedQuoted 6 lines · Jens Lehmann
When highlighting a commit, using the context menu over the staged changes and then selecting "Diff this -> selected" the diff was empty. The same happened when highlighting the staged changes and using "Diff selected -> this" over a commit.
Signed-off-by Jens Lehmann <[email protected]>
Thanks, applied.
Paul.