Skip to contentSkip to conversation

phylib printouts

DISCUSSION Kristoffer Glembo 1 participant 1 message Oct 28, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

Hi,

There are some printouts in the phy abstraction library using pr_info().
Personally I would prefer if they used pr_debug() instead.

Especially the pr_info("%s: probed\n", bus->name) in mdiobus_register() since in some cases I can't tolerate a console printout while the link is down (we have an ethernet debug link and read the UART output through the link).

Of course this is a very specific case but in general in embedded systems (which I think is where the phylib is mainly used) I prefer the driver and other kernel code to be rather silent if not debugging.

Any opinions? :)

Best regards,
Kristoffer Glembo