alsa: echoaudio - pci id cleanup
PATCH 1/1 alsa: echoaudio - pci id cleanup
using the PCI_VENDOR_ID_MOTOROLA definition instead of the value 0x1057 makes code a bit cleaner.
--- sound/pci/echoaudio/darla20.c | 3 ++- sound/pci/echoaudio/darla24.c | 6 ++++-- sound/pci/echoaudio/echo3g.c | 3 ++- sound/pci/echoaudio/gina20.c | 3 ++- sound/pci/echoaudio/gina24.c | 12 ++++++++---- sound/pci/echoaudio/indigo.c | 3 ++- sound/pci/echoaudio/indigodj.c | 3 ++- sound/pci/echoaudio/indigodjx.c | 3 ++- sound/pci/echoaudio/indigoio.c | 3 ++- sound/pci/echoaudio/indigoiox.c | 3 ++- sound/pci/echoaudio/layla20.c | 6 ++++-- sound/pci/echoaudio/layla24.c | 3 ++- sound/pci/echoaudio/mia.c | 6 ++++-- sound/pci/echoaudio/mona.c | 18 ++++++++++++------ 14 files changed, 50 insertions(+), 25 deletions(-)
sound/pci/echoaudio/darla20.c +2 -1
@@ -64,7 +64,8 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x1801 ,0xECC0 ,0x0010 ,0 ,0 ,0 },/* DSP 56301 Darla20 rev.0 */ +/* DSP 56301 Darla20 rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0010 ,0 ,0 ,0 }, {0 ,} };
sound/pci/echoaudio/darla24.c +4 -2
@@ -68,8 +68,10 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x1801 ,0xECC0 ,0x0040 ,0 ,0 ,0 },/* DSP 56301 Darla24 rev.0 */ - {0x1057 ,0x1801 ,0xECC0 ,0x0041 ,0 ,0 ,0 },/* DSP 56301 Darla24 rev.1 */ +/* DSP 56301 Darla24 rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0040 ,0 ,0 ,0 }, +/* DSP 56301 Darla24 rev.1 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0041 ,0 ,0 ,0 }, {0 ,} };
sound/pci/echoaudio/echo3g.c +2 -1
@@ -82,7 +82,8 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x3410 ,0xECC0 ,0x0100 ,0 ,0 ,0 },/* Echo 3G */ +/* Echo 3G */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0100 ,0 ,0 ,0 }, {0 ,} };
sound/pci/echoaudio/gina20.c +2 -1
@@ -68,7 +68,8 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x1801 ,0xECC0 ,0x0020 ,0 ,0 ,0 },/* DSP 56301 Gina20 rev.0 */ +/* DSP 56301 Gina20 rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0020 ,0 ,0 ,0 }, {0 ,} };
sound/pci/echoaudio/gina24.c +8 -4
@@ -86,10 +86,14 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x1801 ,0xECC0 ,0x0050 ,0 ,0 ,0 },/* DSP 56301 Gina24 rev.0 */ - {0x1057 ,0x1801 ,0xECC0 ,0x0051 ,0 ,0 ,0 },/* DSP 56301 Gina24 rev.1 */ - {0x1057 ,0x3410 ,0xECC0 ,0x0050 ,0 ,0 ,0 },/* DSP 56361 Gina24 rev.0 */ - {0x1057 ,0x3410 ,0xECC0 ,0x0051 ,0 ,0 ,0 },/* DSP 56361 Gina24 rev.1 */ +/* DSP 56301 Gina24 rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0050 ,0 ,0 ,0 }, +/* DSP 56301 Gina24 rev.1 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0051 ,0 ,0 ,0 }, +/* DSP 56361 Gina24 rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0050 ,0 ,0 ,0 }, +/* DSP 56361 Gina24 rev.1 */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0051 ,0 ,0 ,0 }, {0 ,} };
sound/pci/echoaudio/indigo.c +2 -1
@@ -69,7 +69,8 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x3410 ,0xECC0 ,0x0090 ,0 ,0 ,0 },/* Indigo */ +/* Indigo */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0090 ,0 ,0 ,0 }, {0 ,} };
sound/pci/echoaudio/indigodj.c +2 -1
@@ -69,7 +69,8 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x3410 ,0xECC0 ,0x00B0 ,0 ,0 ,0 },/* Indigo DJ*/ +/* Indigo DJ*/ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x00B0 ,0 ,0 ,0 }, {0 ,} };
sound/pci/echoaudio/indigodjx.c +2 -1
@@ -69,7 +69,8 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x3410 ,0xECC0 ,0x00E0 ,0 ,0 ,0 },/* Indigo DJx*/ +/* Indigo DJx*/ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x00E0 ,0 ,0 ,0 }, {0 ,} };
sound/pci/echoaudio/indigoio.c +2 -1
@@ -70,7 +70,8 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x3410 ,0xECC0 ,0x00A0 ,0 ,0 ,0 },/* Indigo IO*/ +/* Indigo IO*/ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x00A0 ,0 ,0 ,0 }, {0 ,} };
sound/pci/echoaudio/indigoiox.c +2 -1
@@ -70,7 +70,8 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x3410 ,0xECC0 ,0x00D0 ,0 ,0 ,0 },/* Indigo IOx */ +/* Indigo IOx */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x00D0 ,0 ,0 ,0 }, {0 ,} };
sound/pci/echoaudio/layla20.c +4 -2
@@ -77,8 +77,10 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x1801 ,0xECC0 ,0x0030 ,0 ,0 ,0 },/* DSP 56301 Layla20 rev.0 */ - {0x1057 ,0x1801 ,0xECC0 ,0x0031 ,0 ,0 ,0 },/* DSP 56301 Layla20 rev.1 */ +/* DSP 56301 Layla20 rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0030 ,0 ,0 ,0 }, +/* DSP 56301 Layla20 rev.1 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0031 ,0 ,0 ,0 }, {0 ,} };
sound/pci/echoaudio/layla24.c +2 -1
@@ -88,7 +88,8 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x3410 ,0xECC0 ,0x0060 ,0 ,0 ,0 },/* DSP 56361 Layla24 rev.0 */ +/* DSP 56361 Layla24 rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0060 ,0 ,0 ,0 }, {0 ,} };
sound/pci/echoaudio/mia.c +4 -2
@@ -77,8 +77,10 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x3410 ,0xECC0 ,0x0080 ,0 ,0 ,0 },/* DSP 56361 Mia rev.0 */ - {0x1057 ,0x3410 ,0xECC0 ,0x0081 ,0 ,0 ,0 },/* DSP 56361 Mia rev.1 */ +/* DSP 56361 Mia rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0080 ,0 ,0 ,0 }, +/* DSP 56361 Mia rev.1 */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0081 ,0 ,0 ,0 }, {0 ,} };
sound/pci/echoaudio/mona.c +12 -6
@@ -93,12 +93,18 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x1801 ,0xECC0 ,0x0070 ,0 ,0 ,0 },/* DSP 56301 Mona rev.0 */ - {0x1057 ,0x1801 ,0xECC0 ,0x0071 ,0 ,0 ,0 },/* DSP 56301 Mona rev.1 */ - {0x1057 ,0x1801 ,0xECC0 ,0x0072 ,0 ,0 ,0 },/* DSP 56301 Mona rev.2 */ - {0x1057 ,0x3410 ,0xECC0 ,0x0070 ,0 ,0 ,0 },/* DSP 56361 Mona rev.0 */ - {0x1057 ,0x3410 ,0xECC0 ,0x0071 ,0 ,0 ,0 },/* DSP 56361 Mona rev.1 */ - {0x1057 ,0x3410 ,0xECC0 ,0x0072 ,0 ,0 ,0 },/* DSP 56361 Mona rev.2 */ +/* DSP 56301 Mona rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0070 ,0 ,0 ,0 }, +/* DSP 56301 Mona rev.1 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0071 ,0 ,0 ,0 }, +/* DSP 56301 Mona rev.2 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0072 ,0 ,0 ,0 }, +/* DSP 56361 Mona rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0070 ,0 ,0 ,0 }, +/* DSP 56361 Mona rev.1 */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0071 ,0 ,0 ,0 }, +/* DSP 56361 Mona rev.2 */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0072 ,0 ,0 ,0 }, {0 ,} };
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
At Sat, 17 Oct 2009 11:48:23 +0200,
Quoted 5 lines · Tim Blechmann
using the
PCI_VENDOR_ID_MOTOROLAdefinition instead of the value0x1057makes code a bit cleaner.Signed-off-by Tim Blechmann <[email protected]>
Well, I'm not always fond of this. The only merit is that you can avoid a typo. But, if you look for a device from the source code from lspci, this kind of change makes it hard.
thanks,
Takashi
Quoted 254 lines
--- sound/pci/echoaudio/darla20.c | 3 ++- sound/pci/echoaudio/darla24.c | 6 ++++-- sound/pci/echoaudio/echo3g.c | 3 ++- sound/pci/echoaudio/gina20.c | 3 ++- sound/pci/echoaudio/gina24.c | 12 ++++++++---- sound/pci/echoaudio/indigo.c | 3 ++- sound/pci/echoaudio/indigodj.c | 3 ++- sound/pci/echoaudio/indigodjx.c | 3 ++- sound/pci/echoaudio/indigoio.c | 3 ++- sound/pci/echoaudio/indigoiox.c | 3 ++- sound/pci/echoaudio/layla20.c | 6 ++++-- sound/pci/echoaudio/layla24.c | 3 ++- sound/pci/echoaudio/mia.c | 6 ++++-- sound/pci/echoaudio/mona.c | 18 ++++++++++++------ 14 files changed, 50 insertions(+), 25 deletions(-)[1.1.2 0001-alsa-echoaudio-pci-id-cleanup.patch <text/x-patch (quoted-printable)>]
sound/pci/echoaudio/darla20.c +2
-1@@ -64,7 +64,8 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x1801 ,0xECC0 ,0x0010 ,0 ,0 ,0 },/* DSP 56301 Darla20 rev.0 */ +/* DSP 56301 Darla20 rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0010 ,0 ,0 ,0 }, {0 ,} };sound/pci/echoaudio/darla24.c +4
-2@@ -68,8 +68,10 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x1801 ,0xECC0 ,0x0040 ,0 ,0 ,0 },/* DSP 56301 Darla24 rev.0 */ - {0x1057 ,0x1801 ,0xECC0 ,0x0041 ,0 ,0 ,0 },/* DSP 56301 Darla24 rev.1 */ +/* DSP 56301 Darla24 rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0040 ,0 ,0 ,0 }, +/* DSP 56301 Darla24 rev.1 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0041 ,0 ,0 ,0 }, {0 ,} };sound/pci/echoaudio/echo3g.c +2
-1@@ -82,7 +82,8 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x3410 ,0xECC0 ,0x0100 ,0 ,0 ,0 },/* Echo 3G */ +/* Echo 3G */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0100 ,0 ,0 ,0 }, {0 ,} };sound/pci/echoaudio/gina20.c +2
-1@@ -68,7 +68,8 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x1801 ,0xECC0 ,0x0020 ,0 ,0 ,0 },/* DSP 56301 Gina20 rev.0 */ +/* DSP 56301 Gina20 rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0020 ,0 ,0 ,0 }, {0 ,} };sound/pci/echoaudio/gina24.c +8
-4@@ -86,10 +86,14 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x1801 ,0xECC0 ,0x0050 ,0 ,0 ,0 },/* DSP 56301 Gina24 rev.0 */ - {0x1057 ,0x1801 ,0xECC0 ,0x0051 ,0 ,0 ,0 },/* DSP 56301 Gina24 rev.1 */ - {0x1057 ,0x3410 ,0xECC0 ,0x0050 ,0 ,0 ,0 },/* DSP 56361 Gina24 rev.0 */ - {0x1057 ,0x3410 ,0xECC0 ,0x0051 ,0 ,0 ,0 },/* DSP 56361 Gina24 rev.1 */ +/* DSP 56301 Gina24 rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0050 ,0 ,0 ,0 }, +/* DSP 56301 Gina24 rev.1 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0051 ,0 ,0 ,0 }, +/* DSP 56361 Gina24 rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0050 ,0 ,0 ,0 }, +/* DSP 56361 Gina24 rev.1 */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0051 ,0 ,0 ,0 }, {0 ,} };sound/pci/echoaudio/indigo.c +2
-1@@ -69,7 +69,8 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x3410 ,0xECC0 ,0x0090 ,0 ,0 ,0 },/* Indigo */ +/* Indigo */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0090 ,0 ,0 ,0 }, {0 ,} };sound/pci/echoaudio/indigodj.c +2
-1@@ -69,7 +69,8 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x3410 ,0xECC0 ,0x00B0 ,0 ,0 ,0 },/* Indigo DJ*/ +/* Indigo DJ*/ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x00B0 ,0 ,0 ,0 }, {0 ,} };sound/pci/echoaudio/indigodjx.c +2
-1@@ -69,7 +69,8 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x3410 ,0xECC0 ,0x00E0 ,0 ,0 ,0 },/* Indigo DJx*/ +/* Indigo DJx*/ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x00E0 ,0 ,0 ,0 }, {0 ,} };sound/pci/echoaudio/indigoio.c +2
-1@@ -70,7 +70,8 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x3410 ,0xECC0 ,0x00A0 ,0 ,0 ,0 },/* Indigo IO*/ +/* Indigo IO*/ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x00A0 ,0 ,0 ,0 }, {0 ,} };sound/pci/echoaudio/indigoiox.c +2
-1@@ -70,7 +70,8 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x3410 ,0xECC0 ,0x00D0 ,0 ,0 ,0 },/* Indigo IOx */ +/* Indigo IOx */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x00D0 ,0 ,0 ,0 }, {0 ,} };sound/pci/echoaudio/layla20.c +4
-2@@ -77,8 +77,10 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x1801 ,0xECC0 ,0x0030 ,0 ,0 ,0 },/* DSP 56301 Layla20 rev.0 */ - {0x1057 ,0x1801 ,0xECC0 ,0x0031 ,0 ,0 ,0 },/* DSP 56301 Layla20 rev.1 */ +/* DSP 56301 Layla20 rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0030 ,0 ,0 ,0 }, +/* DSP 56301 Layla20 rev.1 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0031 ,0 ,0 ,0 }, {0 ,} };sound/pci/echoaudio/layla24.c +2
-1@@ -88,7 +88,8 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x3410 ,0xECC0 ,0x0060 ,0 ,0 ,0 },/* DSP 56361 Layla24 rev.0 */ +/* DSP 56361 Layla24 rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0060 ,0 ,0 ,0 }, {0 ,} };sound/pci/echoaudio/mia.c +4
-2@@ -77,8 +77,10 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x3410 ,0xECC0 ,0x0080 ,0 ,0 ,0 },/* DSP 56361 Mia rev.0 */ - {0x1057 ,0x3410 ,0xECC0 ,0x0081 ,0 ,0 ,0 },/* DSP 56361 Mia rev.1 */ +/* DSP 56361 Mia rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0080 ,0 ,0 ,0 }, +/* DSP 56361 Mia rev.1 */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0081 ,0 ,0 ,0 }, {0 ,} };sound/pci/echoaudio/mona.c +12
-6@@ -93,12 +93,18 @@ static const struct firmware card_fw[] = { };static struct pci_device_id snd_echo_ids[] = { - {0x1057 ,0x1801 ,0xECC0 ,0x0070 ,0 ,0 ,0 },/* DSP 56301 Mona rev.0 */ - {0x1057 ,0x1801 ,0xECC0 ,0x0071 ,0 ,0 ,0 },/* DSP 56301 Mona rev.1 */ - {0x1057 ,0x1801 ,0xECC0 ,0x0072 ,0 ,0 ,0 },/* DSP 56301 Mona rev.2 */ - {0x1057 ,0x3410 ,0xECC0 ,0x0070 ,0 ,0 ,0 },/* DSP 56361 Mona rev.0 */ - {0x1057 ,0x3410 ,0xECC0 ,0x0071 ,0 ,0 ,0 },/* DSP 56361 Mona rev.1 */ - {0x1057 ,0x3410 ,0xECC0 ,0x0072 ,0 ,0 ,0 },/* DSP 56361 Mona rev.2 */ +/* DSP 56301 Mona rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0070 ,0 ,0 ,0 }, +/* DSP 56301 Mona rev.1 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0071 ,0 ,0 ,0 }, +/* DSP 56301 Mona rev.2 */ + {PCI_VENDOR_ID_MOTOROLA ,0x1801 ,0xECC0 ,0x0072 ,0 ,0 ,0 }, +/* DSP 56361 Mona rev.0 */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0070 ,0 ,0 ,0 }, +/* DSP 56361 Mona rev.1 */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0071 ,0 ,0 ,0 }, +/* DSP 56361 Mona rev.2 */ + {PCI_VENDOR_ID_MOTOROLA ,0x3410 ,0xECC0 ,0x0072 ,0 ,0 ,0 }, {0 ,} };[1.2 OpenPGP digital signature <application/pgp-signature (7bit)>]
[2 <text/plain; us-ascii (7bit)>]
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
Quoted 11 lines · Takashi Iwai
At Sat, 17 Oct 2009 11:48:23 +0200,
Quoted 5 lines · Tim Blechmann
using the
PCI_VENDOR_ID_MOTOROLAdefinition instead of the value0x1057makes code a bit cleaner.Signed-off-by Tim Blechmann <[email protected]>Well, I'm not always fond of this. The only merit is that you can avoid a typo. But, if you look for a device from the source code from lspci, this kind of change makes it hard.
it helps, if this device is referred to by PCI_VENDOR_ID_MOTOROLA instead of 0x1057, as it is done somewhere in the cardbus code ...
but since it is a rather cosmetic fix, feel free to drop the patch ...
tim
Signature · 5 lines
[email protected] http://tim.klingt.org You don't have to call it music if the term shocks you. John Cage
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel