/proc/sys/kernel/pty/nr broken, possibly since 2.6.28
I just noticed that /proc/sys/kernel/pty/nr is broken, and the most likely culprit seems to be the series of checkins that include 8b0a88d5 and bf970ee4, during the 2.6.28 merge window. This is thus a regression. I haven't verified that the bug really goes that far back -- I should do a bisection -- but it is at least present in 2.6.30.9 and 2.6.32-rc6.
The symptom is that /proc/sys/kernel/pty/nr is properly increased, but never decreased when a pty gets dropped. It is in fact rather trivial to escalate /proc/sys/kernel/pty/nr far above /proc/sys/kernel/pty/max.
As far as I read this series, the indent was to have this accounting handled in pty_unix98_remove(), however, it would appear that that function never gets called. I'm wondering if this may be a symptom of a bigger problem as well.
-hpa
Quoted 7 lines · H. Peter Anvin
I just noticed that
/proc/sys/kernel/pty/nris broken, and the most likely culprit seems to be the series of checkins that include8b0a88d5andbf970ee4, during the 2.6.28 merge window. This is thus a regression. I haven't verified that the bug really goes that far back -- I should do a bisection -- but it is at least present in 2.6.30.9 and 2.6.32-rc6.
Quoted 9 lines
The symptom is that
/proc/sys/kernel/pty/nris properly increased, but never decreased when a pty gets dropped. It is in fact rather trivial to escalate/proc/sys/kernel/pty/nrfar above/proc/sys/kernel/pty/max.As far as I read this series, the indent was to have this accounting handled in
pty_unix98_remove(), however, it would appear that that function never gets called. I'm wondering if this may be a symptom of a bigger problem as well.
Bisection confirms that the bug was introduced during this commit series:
There are only 'skip'ped commit left to test.
The first bad commit could be any of:8b0a88d5912ab549d5adac2c8498ecdaae5319a573ec06fc5f5c8e1097a7a4a4ab2d7c6c3a007e817d7b93c1452f381350dbaf276a63357fa6559e6dbf970ee46e0fb363c8df4393229121d54330a98e
We cannot bisect more!
This series of skipped commits are ones during which /proc/sys/kernel/pty doesn't exist at all.
-hpa