Skip to contentSkip to conversation

Fix build failure in cgroup_fj testcase

PATCH In review Shi Weihua 2 participants 2 messages Nov 6, 2009 – Nov 9, 2009

lore
Share & tools
lore

Shi Weihua

author
#0 lore raw

PATCH 1/1 Fix build failure in cgroup_fj testcase

The following build failure occured on my x86 box.
-------------------------------------------------------

# uname -a
Linux F8-i386 2.6.32-rc5-tipshiwh+ #3 SMP Wed Oct 21 15:14:54 EDT 2009 i686 i686 i386 GNU/Linux
# cat /etc/issue
Fedora release 8 (Werewolf)
Kernel \r on an \m

gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -I/home/shiwh/ltp-full-20091031/testcases/kernel/include -I/home/shiwh/ltp-full-20091031/testcases/kernel/controllers/cgroup_fj/../libcontrollers -Wall -O2 -Wextra -I../../../../include -I../../../../include -L/home/shiwh/ltp-full-20091031/testcases/kernel/controllers/cgroup_fj/../libcontrollers -L../../../../lib cgroup_fj_proc.c -lltp -lcontrollers -o cgroup_fj_proc
/usr/bin/ld: cannot find -lcontrollers
collect2: ld returned 1 exit status
make[4]: *** [cgroup_fj_proc] Error 1
make[4]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases/kernel/controllers/cgroup_fj' make[3]: *** [all] Error 2
make[3]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases/kernel/controllers' make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases/kernel' make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases'
make: *** [testcases-all] Error 2
-------------------------------------------------------

But the case "cgroup_fj" does not need "-lcontrollers" when building.
So in my patch, i deleted "-lcontrollers" in testcases/kernel/controllers/Makefile.inc and added it to testcases/kernel/controllers/memctl/Makefile because the case "memctl" need it.
All other cases in testcases/kernel/controllers/ build well too when my patch merged.

---

testcases/kernel/controllers/Makefile.inc +0 -2
diff -urpN ltp-full-20091031.orig/testcases/kernel/controllers/Makefile.inc ltp-full-20091031/testcases/kernel/controllers/Makefile.inc
@@ -39,8 +39,6 @@ CPPFLAGS		+= -I$(abs_srcdir)/../$(LIBDIR
 
 LDFLAGS			+= -L$(abs_builddir)/../$(LIBDIR)
 
-LDLIBS			+= -lcontrollers
-
 INSTALL_TARGETS		?= *.sh
 
 # vim: syntax=make
testcases/kernel/controllers/memctl/Makefile +2 -0
diff -urpN ltp-full-20091031.orig/testcases/kernel/controllers/memctl/Makefile ltp-full-20091031/testcases/kernel/controllers/memctl/Makefile
@@ -27,4 +27,6 @@ include $(abs_srcdir)/../Makefile.inc
 
 INSTALL_TARGETS		:= *.sh
 
+LDLIBS			+= -lcontrollers
+
 include $(top_srcdir)/include/mk/generic_leaf_target.mk

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw
Quoted 22 lines · Shi Weihua

The following build failure occured on my x86 box.
-------------------------------------------------------

# uname -a
Linux F8-i386 2.6.32-rc5-tipshiwh+ #3 SMP Wed Oct 21 15:14:54 EDT 2009 i686 i686 i386 GNU/Linux
# cat /etc/issue
Fedora release 8 (Werewolf)
Kernel \r on an \m

gcc -g -O2 -g -O2 -fno-strict-aliasing -pipe -Wall -I/home/shiwh/ltp-full-20091031/testcases/kernel/include -I/home/shiwh/ltp-full-20091031/testcases/kernel/controllers/cgroup_fj/../libcontrollers -Wall -O2 -Wextra -I../../../../include -I../../../../include -L/home/shiwh/ltp-full-20091031/testcases/kernel/controllers/cgroup_fj/../libcontrollers -L../../../../lib cgroup_fj_proc.c -lltp -lcontrollers -o cgroup_fj_proc
/usr/bin/ld: cannot find -lcontrollers
collect2: ld returned 1 exit status
make[4]: *** [cgroup_fj_proc] Error 1
make[4]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases/kernel/controllers/cgroup_fj' make[3]: *** [all] Error 2
make[3]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases/kernel/controllers' make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases/kernel' make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/shiwh/ltp-full-20091031/testcases'
make: *** [testcases-all] Error 2
-------------------------------------------------------

Quoted 7 lines

But the case "cgroup_fj" does not need "-lcontrollers" when building.
So in my patch, i deleted "-lcontrollers" in testcases/kernel/controllers/Makefile.inc and added it to testcases/kernel/controllers/memctl/Makefile because the case "memctl" need it.
All other cases in testcases/kernel/controllers/ build well too when my patch merged.

Thanks.

Regards--
Subrata

Quoted 26 lines

---
diff -urpN ltp-full-20091031.orig/testcases/kernel/controllers/Makefile.inc ltp-full-20091031/testcases/kernel/controllers/Makefile.inc

testcases/kernel/controllers/Makefile.inc +0 -2
@@ -39,8 +39,6 @@ CPPFLAGS		+= -I$(abs_srcdir)/../$(LIBDIR
 
 LDFLAGS			+= -L$(abs_builddir)/../$(LIBDIR)
 
-LDLIBS			+= -lcontrollers
-
 INSTALL_TARGETS		?= *.sh
 
 # vim: syntax=make

diff -urpN ltp-full-20091031.orig/testcases/kernel/controllers/memctl/Makefile ltp-full-20091031/testcases/kernel/controllers/memctl/Makefile

testcases/kernel/controllers/memctl/Makefile +2 -1
@@ -27,4 +27,6 @@ include $(abs_srcdir)/../Makefile.inc
 
 INSTALL_TARGETS		:= *.sh
 
+LDLIBS			+= -lcontrollers
+
 include $(top_srcdir)/include/mk/generic_leaf_target.mk
 
 
------------------------------------------------------------------------------
Quoted 8 lines

Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list