Skip to contentSkip to conversation

e1000e: Add new ID

PATCH In review Sven Anders 2 participants 2 messages Nov 9, 2009 – Nov 10, 2009

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Sven Anders

author
#0 lore raw

PATCH 1/1 e1000e: Add new ID

Hello!

We use the the 82571EB (QUAD COPPER BP) with the e1000e driver. We haven't experienced any problems yet.

The patch is trivial, just adding a new PCI ID...

Regards
Sven Anders

Signature · 9 lines
 Sven Anders <[email protected]>                 () Ascii Ribbon Campaign
                                                 /\ Support plain text e-mail
 ANDURAS service solutions AG
 Innstrasse 71 - 94036 Passau - Germany
 Web: www.anduras.de - Tel: +49 (0)851-4 90 50-0 - Fax: +49 (0)851-4 90 50-55

Those who would give up essential Liberty, to purchase a little
temporary Safety, deserve neither Liberty nor Safety.
  - Benjamin Franklin
drivers/net/e1000e/hw.h renamed from drivers/net/e1000e/hw.h.orig +1 -0
@@ -323,6 +323,7 @@
 #define E1000_DEV_ID_82571PT_QUAD_COPPER	0x10D5
 #define E1000_DEV_ID_82571EB_QUAD_FIBER		0x10A5
 #define E1000_DEV_ID_82571EB_QUAD_COPPER_LP	0x10BC
+#define E1000_DEV_ID_82571EB_QUAD_COPPER_BP	0x10A0
 #define E1000_DEV_ID_82571EB_SERDES_DUAL	0x10D9
 #define E1000_DEV_ID_82571EB_SERDES_QUAD	0x10DA
 #define E1000_DEV_ID_82572EI_COPPER		0x107D
drivers/net/e1000e/netdev.c renamed from drivers/net/e1000e/netdev.c.orig +1 -0
@@ -4560,6 +4560,7 @@
 	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_82571EB_FIBER), board_82571 },
 	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_82571EB_QUAD_COPPER), board_82571 },
 	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_82571EB_QUAD_COPPER_LP), board_82571 },
+	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_82571EB_QUAD_COPPER_BP), board_82571 },
 	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_82571EB_QUAD_FIBER), board_82571 },
 	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_82571EB_SERDES), board_82571 },
 	{ PCI_VDEVICE(INTEL, E1000_DEV_ID_82571EB_SERDES_DUAL), board_82571 },
drivers/net/e1000e/82571.c renamed from drivers/net/e1000e/82571.c.orig +1 -0
@@ -274,6 +274,7 @@
 	case E1000_DEV_ID_82571EB_QUAD_COPPER:
 	case E1000_DEV_ID_82571EB_QUAD_FIBER:
 	case E1000_DEV_ID_82571EB_QUAD_COPPER_LP:
+	case E1000_DEV_ID_82571EB_QUAD_COPPER_BP:
 	case E1000_DEV_ID_82571PT_QUAD_COPPER:
 		adapter->flags |= FLAG_IS_QUAD_PORT;
 		/* mark the first port */

begin:vcard
fn:Sven Anders
n:Anders;Sven
adr;quoted-printable:;;Weidestra=C3=9Fe 19;Hannover;Niedersachsen;30453;Deutschland email;internet:[email protected]
tel;home:+49 (0)511 / 2123090
tel;cell:+49 (0)170 / 8091180
x-mozilla-html:FALSE
url:http://staff.anduras.de/anders
version:2.1
end:vcard

#1 lore raw

NAK. While this is indeed a trivial patch to enable a device that is not currently supported in e1000e, this device requires special handling to get the bypass functionality to work properly and as such this patch is insufficient.

Quoted 29 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Sven Anders
Sent: Monday, November 09, 2009 12:25 PM
To: netdev
Subject: [PATCH] e1000e: Add new ID

Hello!

We use the the 82571EB (QUAD COPPER BP) with the e1000e driver. We haven't experienced any problems yet.

The patch is trivial, just adding a new PCI ID...

Regards
Sven Anders

--
Sven Anders <[email protected]> () Ascii Ribbon Campaign
/\ Support plain text e-
mail
ANDURAS service solutions AG
Innstrasse 71 - 94036 Passau - Germany
Web: www.anduras.de - Tel: +49 (0)851-4 90 50-0 - Fax: +49 (0)851-4 90 50-55

Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety.
- Benjamin Franklin