Skip to contentSkip to conversation

parisc: led: Use for_each_netdev_rcu()

PATCH Applied Eric Dumazet 2 participants 2 messages Nov 10, 2009 – Nov 11, 2009

Subsystems (3)
Networking Network drivers PA-RISC architecture
lore
Share & tools
lore

Eric Dumazet

author
#0 lore raw

PATCH 1/1 parisc: led: Use for_each_netdev_rcu()

Use for_each_netdev_rcu() and dont lock dev_base_lock anymore

Signed-off-by Eric Dumazet <[email protected]>
---
 drivers/parisc/led.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)
drivers/parisc/led.c +2 -5
index 9581d36..79caf1c 100644
@@ -352,11 +352,9 @@ static __inline__ int led_get_net_activity(void)
 
 	rx_total = tx_total = 0;
 	
-	/* we are running as a workqueue task, so locking dev_base 
-	 * for reading should be OK */
-	read_lock(&dev_base_lock);
+	/* we are running as a workqueue task, so we can use an RCU lookup */
 	rcu_read_lock();
-	for_each_netdev(&init_net, dev) {
+	for_each_netdev_rcu(&init_net, dev) {
 	    const struct net_device_stats *stats;
 	    struct in_device *in_dev = __in_dev_get_rcu(dev);
 	    if (!in_dev || !in_dev->ifa_list)

@@ -368,7 +366,6 @@ static __inline__ int led_get_net_activity(void)
 	    tx_total += stats->tx_packets;
 	}
 	rcu_read_unlock();
-	read_unlock(&dev_base_lock);
 
 	retval = 0;