mxc_fec: fix some erroneous PHY accesses.
PATCH 1/2 mxc_fec: fix some erroneous PHY accesses.
This patch fixes erroneous access to the ethernet PHY which broke the driver.
1. Selector field in the auto-negotiation register must be 0x00001 for using 802.3, not 0x00000 which is reseved.
2. Access to the PHY address specified by CONFIG_FEC_MXC_PHYADDR, not 0x0 fixed address.
This has been tested in i.MX27 Litekit board and eldk-4.2 toolchains.
Now using proper defines for auto-negotiation register.
--
drivers/net/fec_mxc.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-)
drivers/net/fec_mxc.c +5 -3
@@ -157,7 +157,9 @@ static int miiphy_restart_aneg(struct eth_device *dev)/* * Set the auto-negotiation advertisement register bits */ -miiphy_write (dev->name,CONFIG_FEC_MXC_PHYADDR ,PHY_ANAR ,0x1e0 ); +miiphy_write (dev->name,CONFIG_FEC_MXC_PHYADDR ,PHY_ANAR , +PHY_ANLPAR_TXFD |PHY_ANLPAR_TX |PHY_ANLPAR_10FD | +PHY_ANLPAR_10 |PHY_ANLPAR_PSB_802_3 );miiphy_write (dev->name,CONFIG_FEC_MXC_PHYADDR ,PHY_BMCR ,PHY_BMCR_AUTON |PHY_BMCR_RST_NEG );
@@ -341,8 +343,8 @@ static int fec_open(struct eth_device *edev)writel (FEC_ECNTRL_ETHER_EN , &fec->eth->ecntrl);miiphy_wait_aneg (edev); -miiphy_speed (edev->name,0 ); -miiphy_duplex (edev->name,0 ); +miiphy_speed (edev->name,CONFIG_FEC_MXC_PHYADDR ); +miiphy_duplex (edev->name,CONFIG_FEC_MXC_PHYADDR );/* * Enable SmartDMA receive task
Signature · 7 lines
Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com
PATCH 1/2 mxc_fec: fix some erroneous PHY accesses.
Dear Ben Warren,
do these patches look OK for you?
Thanks.
Signature · 7 lines
Javier Martin Vista Silicon S.L. CDTUC - FASE C - Oficina S-345 Avda de los Castros s/n 39005- Santander. Cantabria. Spain +34 942 25 32 60 www.vista-silicon.com
Ben Warren
AppliedPATCH 1/2 mxc_fec: fix some erroneous PHY accesses.
In reply to javier MartinJavier,
Quoted 6 lines · javier Martin
This patch fixes erroneous access to the ethernet PHY which broke the driver.
1. Selector field in the auto-negotiation register must be0x00001for using 802.3, not0x00000which is reseved.
2. Access to the PHY address specified byCONFIG_FEC_MXC_PHYADDR, not0x0fixed address.
Quoted 6 lines
This has been tested in i.MX27 Litekit board and eldk-4.2 toolchains.
Now using proper defines for auto-negotiation register.
Signed-off-by Javier Martin <[email protected]>--
Applied to net repo.
thanks,
Ben