Skip to contentSkip to conversation

syscalls: fix some failure on arch X86_64

PATCH In review liubo 5 participants 18 messages Nov 10, 2009 – Dec 9, 2009

lore
Share & tools
lore

liubo

author
#0 lore raw

PATCH 1/1 syscalls: fix some failure on arch X86_64

1) rt_sigaction
"sigaction" has the structure:

 struct sigaction {
         __sighandler_t sa_handler;
         unsigned long sa_flags;
  #ifdef SA_RESTORER
          __sigrestore_t sa_restorer;

#endif
sigset_t sa_mask; /* mask last for extensibility */
};

However, on arch x86_64, if we directly get to call rt_sigaction,
the argument "sa_restorer" will not be fulfilled, and this will lead
to segment fault.
on arch x86_64, if sa_restorer is not set, kernel will lead to segment fault.
In other arch, if sa_restorer is not set, kernel can do the correct work.
To avoid this segment fault, we use glibc function
"int sigaction(...);" instead, which can fulfill the argument "sa_restorer".

2) rt_sigprocmask
This failure contains two aspects,
the first is the segment fault as described in 1),
the second is that testcase uses a unknown signal 33 for test, and this will lead sigaction cannot bind signal 33 to the action.

So, we attempt to use a known signal instead, such as 34.

This patch fixed these failures.

---
 .../kernel/syscalls/rt_sigaction/rt_sigaction01.c  |    4 ++++
 .../syscalls/rt_sigprocmask/rt_sigprocmask01.c     |   12 ++++++++----
 .../syscalls/rt_sigsuspend/rt_sigsuspend01.c       |    4 ++++
 3 files changed, 16 insertions(+), 4 deletions(-)
testcases/kernel/syscalls/rt_sigaction/rt_sigaction01.c +4 -0
index 27af970..1522ac4 100644
@@ -154,7 +154,11 @@ set_handler(int sig, int sig_to_mask, int mask_flags)
                 sa.sa_flags = mask_flags;
                 sigemptyset(&sa.sa_mask);
                 sigaddset(&sa.sa_mask, sig_to_mask);
+		#ifndef __x86_64__
                 TEST(syscall(__NR_rt_sigaction,sig, &sa, &oldaction,SIGSETSIZE));
+		#else
+		TEST(sigaction(sig, &sa, &oldaction));
+		#endif
         if (TEST_RETURN == 0) {
                 return 0;
         } else {
testcases/kernel/syscalls/rt_sigprocmask/rt_sigprocmask01.c +8 -4
index 6398a28..31258e9 100644
@@ -154,7 +154,7 @@ int main(int ac, char **av) {
                         	cleanup();
 				tst_exit();
 			}
-			TEST(sigaddset(&set, 33));
+			TEST(sigaddset(&set, 34));
 			if(TEST_RETURN == -1){
 				tst_resm(TFAIL,"Call to sigaddset() Failed, errno=%d : %s",TEST_ERRNO, strerror(TEST_ERRNO));
                         	cleanup();
@@ -163,7 +163,11 @@ int main(int ac, char **av) {
 			
 			/* call rt_sigaction() */
 			act.sa_handler = sig_handler;
-                        TEST(syscall(__NR_rt_sigaction, 33, &act, &oact, 8));
+			#ifndef __x86_64__
+                        TEST(syscall(__NR_rt_sigaction, 34, &act, &oact, 8));
+			#else
+			TEST(sigaction(34, &act, &oact));
+			#endif
 			if(TEST_RETURN != 0){
 				tst_resm(TFAIL,"Call to rt_sigaction() Failed, errno=%d : %s",TEST_ERRNO, strerror(TEST_ERRNO));
                         	cleanup();
@@ -178,7 +182,7 @@ int main(int ac, char **av) {
 			}
 			
 			else {
-				TEST(kill(getpid(), 33));
+				TEST(kill(getpid(), 34));
 				if(TEST_RETURN != 0){
 					tst_resm(TFAIL,"Call to kill() Failed, errno=%d : %s",TEST_ERRNO, strerror(TEST_ERRNO));
                         		cleanup();
@@ -198,7 +202,7 @@ int main(int ac, char **av) {
                         			cleanup();
 						tst_exit();
 					}
-					TEST(sigismember(&oset, 33));
+					TEST(sigismember(&oset, 34));
 					if(TEST_RETURN == 0 ){
 						tst_resm(TFAIL,"call sigismember() Failed, errno=%d : %s",TEST_ERRNO, strerror(TEST_ERRNO));
                         			cleanup();
testcases/kernel/syscalls/rt_sigsuspend/rt_sigsuspend01.c +4 -0
index 416a7c9..6132622 100644
@@ -142,7 +142,11 @@ int main(int ac, char **av) {
 			struct sigaction act, oact;
 		        act.sa_handler = sig_handler;
 			
+			#ifndef __x86_64__
 			TEST(syscall(__NR_rt_sigaction, SIGALRM, &act, &oact, 8));
+			#else
+			TEST(sigaction(SIGALRM, &act, &oact));
+			#endif
 			if(TEST_RETURN == -1){
 		        	tst_resm(TFAIL,"rt_sigaction() Failed, errno=%d : %s",TEST_ERRNO, strerror(TEST_ERRNO));
 				cleanup();
Signature · 11 lines
1.6.2.2

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
author
#1 lore raw

Hi,

Quoted 20 lines · liubo

1) rt_sigaction
"sigaction" has the structure:

 struct sigaction {
         __sighandler_t sa_handler;
         unsigned long sa_flags;
  #ifdef SA_RESTORER
          __sigrestore_t sa_restorer;

#endif
sigset_t sa_mask; /* mask last for extensibility */
};

However, on arch x86_64, if we directly get to call rt_sigaction,
the argument "sa_restorer" will not be fulfilled, and this will lead
to segment fault.
on arch x86_64, if sa_restorer is not set, kernel will lead to segment fault.
In other arch, if sa_restorer is not set, kernel can do the correct work.
To avoid this segment fault, we use glibc function
"int sigaction(...);" instead, which can fulfill the argument "sa_restorer".

Quoted 9 lines

2) rt_sigprocmask
This failure contains two aspects,
the first is the segment fault as described in 1),
the second is that testcase uses a unknown signal 33 for test, and this will lead sigaction cannot bind signal 33 to the action.

So, we attempt to use a known signal instead, such as 34.

I am sure signal 32 and 33 cannot be used in rt_sigprocmask test on arch x86_64, but I'm not sure which signal else should be used here, Is there anyone can provide suggestions?

Quoted 77 lines

This patch fixed these failures.

---
 .../kernel/syscalls/rt_sigaction/rt_sigaction01.c  |    4 ++++
 .../syscalls/rt_sigprocmask/rt_sigprocmask01.c     |   12 ++++++++----
 .../syscalls/rt_sigsuspend/rt_sigsuspend01.c       |    4 ++++
 3 files changed, 16 insertions(+), 4 deletions(-)
testcases/kernel/syscalls/rt_sigaction/rt_sigaction01.c +4 -0
index 27af970..1522ac4 100644
@@ -154,7 +154,11 @@ set_handler(int sig, int sig_to_mask, int mask_flags)
                 sa.sa_flags = mask_flags;
                 sigemptyset(&sa.sa_mask);
                 sigaddset(&sa.sa_mask, sig_to_mask);
+		#ifndef __x86_64__
                 TEST(syscall(__NR_rt_sigaction,sig, &sa, &oldaction,SIGSETSIZE));
+		#else
+		TEST(sigaction(sig, &sa, &oldaction));
+		#endif
         if (TEST_RETURN == 0) {
                 return 0;
         } else {
testcases/kernel/syscalls/rt_sigprocmask/rt_sigprocmask01.c +8 -4
index 6398a28..31258e9 100644
@@ -154,7 +154,7 @@ int main(int ac, char **av) {
                         	cleanup();
 				tst_exit();
 			}
-			TEST(sigaddset(&set, 33));
+			TEST(sigaddset(&set, 34));
 			if(TEST_RETURN == -1){
 				tst_resm(TFAIL,"Call to sigaddset() Failed, errno=%d : %s",TEST_ERRNO, strerror(TEST_ERRNO));
                         	cleanup();
@@ -163,7 +163,11 @@ int main(int ac, char **av) {
 
 			/* call rt_sigaction() */
 			act.sa_handler = sig_handler;
-                        TEST(syscall(__NR_rt_sigaction, 33, &act, &oact, 8));
+			#ifndef __x86_64__
+                        TEST(syscall(__NR_rt_sigaction, 34, &act, &oact, 8));
+			#else
+			TEST(sigaction(34, &act, &oact));
+			#endif
 			if(TEST_RETURN != 0){
 				tst_resm(TFAIL,"Call to rt_sigaction() Failed, errno=%d : %s",TEST_ERRNO, strerror(TEST_ERRNO));
                         	cleanup();
@@ -178,7 +182,7 @@ int main(int ac, char **av) {
 			}
 
 			else {
-				TEST(kill(getpid(), 33));
+				TEST(kill(getpid(), 34));
 				if(TEST_RETURN != 0){
 					tst_resm(TFAIL,"Call to kill() Failed, errno=%d : %s",TEST_ERRNO, strerror(TEST_ERRNO));
                         		cleanup();
@@ -198,7 +202,7 @@ int main(int ac, char **av) {
                         			cleanup();
 						tst_exit();
 					}
-					TEST(sigismember(&oset, 33));
+					TEST(sigismember(&oset, 34));
 					if(TEST_RETURN == 0 ){
 						tst_resm(TFAIL,"call sigismember() Failed, errno=%d : %s",TEST_ERRNO, strerror(TEST_ERRNO));
                         			cleanup();
testcases/kernel/syscalls/rt_sigsuspend/rt_sigsuspend01.c +0 -0
index 416a7c9..6132622 100644
@@ -142,7 +142,11 @@ int main(int ac, char **av) {
 			struct sigaction act, oact;

testcases/kernel/syscalls/rt_sigsuspend/rt_sigsuspend01.c int main(int ac, char **av) { · line 152

Quoted 10 lines
testcases/kernel/syscalls/rt_sigsuspend/rt_sigsuspend01.c +4 -0
 		        act.sa_handler = sig_handler;
 
+			#ifndef __x86_64__
 			TEST(syscall(__NR_rt_sigaction, SIGALRM, &act, &oact, 8));
+			#else
+			TEST(sigaction(SIGALRM, &act, &oact));
+			#endif
 			if(TEST_RETURN == -1){
 		        	tst_resm(TFAIL,"rt_sigaction() Failed, errno=%d : %s",TEST_ERRNO, strerror(TEST_ERRNO));
 				cleanup();

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#2 lore raw
Quoted 13 lines · liubo

Hi,

Quoted 11 lines · liubo

1) rt_sigaction
    "sigaction" has the structure:

 struct sigaction {
         __sighandler_t sa_handler;
         unsigned long sa_flags;
  #ifdef SA_RESTORER
          __sigrestore_t sa_restorer;
  #endif
          sigset_t sa_mask;               /* mask last for extensibility */ };

Not true... from glibc 2.9 / gentoo-sources-2.6.30-r4:

#ifdef __i386__
/* Here we must cater to libcs that poke about in kernel headers. */

struct sigaction {
        union {
          __sighandler_t _sa_handler;
          void (*_sa_sigaction)(int, struct siginfo *, void *);
        } _u;
        sigset_t sa_mask;
        unsigned long sa_flags;
        void (*sa_restorer)(void);
};

/* ... */

#else

struct sigaction {
        __sighandler_t sa_handler;
        unsigned long sa_flags;
        __sigrestore_t sa_restorer;
        sigset_t sa_mask;               /* mask last for extensibility */
};

#endif

What do the manpages say is required for rt_sigaction to function on your machine? Mine just says:

SYNOPSIS

       #include <signal.h>

       int sigaction(int signum, const struct sigaction *act,
                     struct sigaction *oldact);

Feature Test Macro Requirements for glibc (see feature_test_macros(7)):

       sigaction(): _POSIX_C_SOURCE >= 1 || _XOPEN_SOURCE || _POSIX_SOURCE
Quoted 14 lines
Quoted 14 lines

    However, on arch x86_64, if we directly get to call rt_sigaction, the argument "sa_restorer" will not be fulfilled, and this will lead to segment fault.
    on arch x86_64, if sa_restorer is not set, kernel will lead to segment fault. In other arch, if sa_restorer is not set, kernel can do the correct work. To avoid this segment fault, we use glibc function
"int sigaction(...);" instead, which can fulfill the argument "sa_restorer".

2) rt_sigprocmask
    This failure contains two aspects,
the first is the segment fault as described in 1),
the second is that testcase uses a unknown signal 33 for test, and this will lead sigaction cannot bind signal 33 to the action.

Quoted 7 lines
Quoted 3 lines

    So, we attempt to use a known signal instead, such as 34.

 I am sure signal 32 and 33 cannot be used in rt_sigprocmask test on arch x86_64, but I'm not sure which signal else should be used here, Is there anyone can provide suggestions?

RT signals are all signals above SIGRTMIN (typically 32+, but not always), up to SIGRTMAX (usually 64, but on mips it's 128). So... why is setting the signal number to anywhere between SIGRTMIN and SIGRTMAX unacceptable?

Thanks,
-Garrett

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#3 lore raw
Quoted 83 lines · Garrett Cooper
Quoted 15 lines · liubo

Hi,

Quoted 12 lines · liubo

1) rt_sigaction
"sigaction" has the structure:

 struct sigaction {
         __sighandler_t sa_handler;
         unsigned long sa_flags;
  #ifdef SA_RESTORER
          __sigrestore_t sa_restorer;

#endif
sigset_t sa_mask; /* mask last for extensibility */
};

Not true... from glibc 2.9 / gentoo-sources-2.6.30-r4:

#ifdef __i386__
/* Here we must cater to libcs that poke about in kernel headers. */

struct sigaction {
        union {
          __sighandler_t _sa_handler;
          void (*_sa_sigaction)(int, struct siginfo *, void *);
        } _u;
        sigset_t sa_mask;
        unsigned long sa_flags;
        void (*sa_restorer)(void);
};

/* ... */

#else

struct sigaction {
        __sighandler_t sa_handler;
        unsigned long sa_flags;
        __sigrestore_t sa_restorer;
        sigset_t sa_mask;               /* mask last for extensibility */
};

#endif

What do the manpages say is required for rt_sigaction to function on your machine? Mine just says:

SYNOPSIS

       #include <signal.h>

       int sigaction(int signum, const struct sigaction *act,
                     struct sigaction *oldact);

Feature Test Macro Requirements for glibc (see feature_test_macros(7)):

       sigaction(): _POSIX_C_SOURCE >= 1 || _XOPEN_SOURCE || _POSIX_SOURCE
Quoted 14 lines
Quoted 14 lines

However, on arch x86_64, if we directly get to call rt_sigaction,
the argument "sa_restorer" will not be fulfilled, and this will lead
to segment fault.
on arch x86_64, if sa_restorer is not set, kernel will lead to segment fault.
In other arch, if sa_restorer is not set, kernel can do the correct work.
To avoid this segment fault, we use glibc function
"int sigaction(...);" instead, which can fulfill the argument "sa_restorer".

2) rt_sigprocmask
This failure contains two aspects,
the first is the segment fault as described in 1),
the second is that testcase uses a unknown signal 33 for test, and this will lead sigaction cannot bind signal 33 to the action.

Quoted 8 lines
Quoted 4 lines

So, we attempt to use a known signal instead, such as 34.

I am sure signal 32 and 33 cannot be used in rt_sigprocmask test on arch x86_64, but I'm not sure which signal else should be used here, Is there anyone can provide suggestions?

Quoted 5 lines

RT signals are all signals above SIGRTMIN (typically 32+, but not always), up to SIGRTMAX (usually 64, but on mips it's 128). So... why is setting the signal number to anywhere between SIGRTMIN and SIGRTMAX unacceptable?

Not sure why signal 32 and 33 are not accepted by sigaction() on x86_64, the acceptable signal from 34 to SIGRTMAX, maybe it's the glibc's BUG? since I had not found the source code of x86_64 sigaction(), I can not check this. It is very strange.

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

author
#4 lore raw
In reply to Garrett Cooper
Quoted 50 lines · Garrett Cooper
Quoted 15 lines · liubo

Hi,

Quoted 12 lines · liubo

1) rt_sigaction
"sigaction" has the structure:

 struct sigaction {
         __sighandler_t sa_handler;
         unsigned long sa_flags;
  #ifdef SA_RESTORER
          __sigrestore_t sa_restorer;

#endif
sigset_t sa_mask; /* mask last for extensibility */
};

Not true... from glibc 2.9 / gentoo-sources-2.6.30-r4:

#ifdef __i386__
/* Here we must cater to libcs that poke about in kernel headers. */

struct sigaction {
        union {
          __sighandler_t _sa_handler;
          void (*_sa_sigaction)(int, struct siginfo *, void *);
        } _u;
        sigset_t sa_mask;
        unsigned long sa_flags;
        void (*sa_restorer)(void);
};

/* ... */

#else

struct sigaction {
        __sighandler_t sa_handler;
        unsigned long sa_flags;
        __sigrestore_t sa_restorer;
        sigset_t sa_mask;               /* mask last for extensibility */
};

#endif

What do the manpages say is required for rt_sigaction to function on your machine? Mine just says:

SYNOPSIS

Quoted 10 lines
       #include <signal.h>

       int sigaction(int signum, const struct sigaction *act,
                     struct sigaction *oldact);

Feature Test Macro Requirements for glibc (see feature_test_macros(7)):

       sigaction(): _POSIX_C_SOURCE >= 1 || _XOPEN_SOURCE || _POSIX_SOURCE

On my machine,

man sigaction
===========
NAME
sigaction - examine and change a signal action

SYNOPSIS

       #include <signal.h>

       int sigaction(int signum, const struct sigaction *act,
                     struct sigaction *oldact);

Feature Test Macro Requirements for glibc (see feature_test_macros(7)):

       sigaction(): _POSIX_C_SOURCE >= 1 || _XOPEN_SOURCE || _POSIX_SOURCE

===========
The same as you.

BTW, I got the sigaction from kernel code instead of glibc.

And I use "strace" to investigate, it shows that function sigaction do call rt_sigaction on my x86_64 arch.

Quoted 23 lines
Quoted 14 lines
Quoted 14 lines

However, on arch x86_64, if we directly get to call rt_sigaction,
the argument "sa_restorer" will not be fulfilled, and this will lead
to segment fault.
on arch x86_64, if sa_restorer is not set, kernel will lead to segment fault.
In other arch, if sa_restorer is not set, kernel can do the correct work.
To avoid this segment fault, we use glibc function
"int sigaction(...);" instead, which can fulfill the argument "sa_restorer".

2) rt_sigprocmask
This failure contains two aspects,
the first is the segment fault as described in 1),
the second is that testcase uses a unknown signal 33 for test, and this will lead sigaction cannot bind signal 33 to the action.

Quoted 8 lines
Quoted 4 lines

So, we attempt to use a known signal instead, such as 34.

I am sure signal 32 and 33 cannot be used in rt_sigprocmask test on arch x86_64, but I'm not sure which signal else should be used here, Is there anyone can provide suggestions?

Quoted 10 lines

RT signals are all signals above SIGRTMIN (typically 32+, but not always), up to SIGRTMAX (usually 64, but on mips it's 128). So... why is setting the signal number to anywhere between SIGRTMIN and SIGRTMAX unacceptable?

Thanks,
-Garrett

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#5 lore raw
In reply to liubo
Quoted 12 lines · On Tuesday 10 November 2009 04:38:30 liubo wrote:

1) rt_sigaction
"sigaction" has the structure:

 struct sigaction {
         __sighandler_t sa_handler;
         unsigned long sa_flags;
  #ifdef SA_RESTORER
          __sigrestore_t sa_restorer;

#endif
sigset_t sa_mask; /* mask last for extensibility */
};

Quoted 8 lines

However, on arch x86_64, if we directly get to call rt_sigaction,
the argument "sa_restorer" will not be fulfilled, and this will lead
to segment fault.
on arch x86_64, if sa_restorer is not set, kernel will lead to segment
fault. In other arch, if sa_restorer is not set, kernel can do the correct work. To avoid this segment fault, we use glibc function
"int sigaction(...);" instead, which can fulfill the argument
"sa_restorer".

which defeats the purpose of the test. there is no guarantee that the C library sigaction function is implemented via the __NR_rt_sigaction syscall.

Quoted 7 lines

2) rt_sigprocmask
This failure contains two aspects,
the first is the segment fault as described in 1),
the second is that testcase uses a unknown signal 33 for test, and this will lead sigaction cannot bind signal 33 to the action.

So, we attempt to use a known signal instead, such as 34.

which is just as bogus and unportable. if the test needs a real time signal, it should leverage the sigrtmin...sigrtmax defines.
-mike

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#6 lore raw
Quoted 24 lines · Mike Frysinger
Quoted 12 lines · On Tuesday 10 November 2009 04:38:30 liubo wrote:

1) rt_sigaction
"sigaction" has the structure:

 struct sigaction {
         __sighandler_t sa_handler;
         unsigned long sa_flags;
  #ifdef SA_RESTORER
          __sigrestore_t sa_restorer;

#endif
sigset_t sa_mask; /* mask last for extensibility */
};

Quoted 9 lines

However, on arch x86_64, if we directly get to call rt_sigaction,
the argument "sa_restorer" will not be fulfilled, and this will lead
to segment fault.
on arch x86_64, if sa_restorer is not set, kernel will lead to segment
fault. In other arch, if sa_restorer is not set, kernel can do the correct work. To avoid this segment fault, we use glibc function
"int sigaction(...);" instead, which can fulfill the argument
"sa_restorer".

Quoted 3 lines

which defeats the purpose of the test. there is no guarantee that the C library sigaction function is implemented via the __NR_rt_sigaction syscall.

In x86_64, it do this. And If we want to use __NR_rt_sigaction syscall directly, we must fill the sa_restorer and set the RESTORER flag to sa_mask. If we do not set the sa_restorer, kill will always cause segment fault.

Quoted 23 lines
Quoted 9 lines

2) rt_sigprocmask
This failure contains two aspects,
the first is the segment fault as described in 1),
the second is that testcase uses a unknown signal 33 for test, and this will lead sigaction cannot bind signal 33 to the action.

So, we attempt to use a known signal instead, such as 34.

which is just as bogus and unportable. if the test needs a real time signal, it should leverage the sigrtmin...sigrtmax defines.
-mike

------------------------------------------------------------------------

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
------------------------------------------------------------------------

Quoted 5 lines

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#7 lore raw

Liubo,

Are you sending an updated patch post this discussion ?

Regards--
Subrata

Quoted 64 lines · Wei Yongjun
Quoted 24 lines · Mike Frysinger
Quoted 12 lines · On Tuesday 10 November 2009 04:38:30 liubo wrote:

1) rt_sigaction
"sigaction" has the structure:

 struct sigaction {
         __sighandler_t sa_handler;
         unsigned long sa_flags;
  #ifdef SA_RESTORER
          __sigrestore_t sa_restorer;

#endif
sigset_t sa_mask; /* mask last for extensibility */
};

Quoted 9 lines

However, on arch x86_64, if we directly get to call rt_sigaction,
the argument "sa_restorer" will not be fulfilled, and this will lead
to segment fault.
on arch x86_64, if sa_restorer is not set, kernel will lead to segment
fault. In other arch, if sa_restorer is not set, kernel can do the correct work. To avoid this segment fault, we use glibc function
"int sigaction(...);" instead, which can fulfill the argument
"sa_restorer".

Quoted 3 lines

which defeats the purpose of the test. there is no guarantee that the C library sigaction function is implemented via the __NR_rt_sigaction syscall.

In x86_64, it do this. And If we want to use __NR_rt_sigaction syscall directly, we must fill the sa_restorer and set the RESTORER flag to sa_mask. If we do not set the sa_restorer, kill will always cause segment fault.

Quoted 23 lines
Quoted 9 lines

2) rt_sigprocmask
This failure contains two aspects,
the first is the segment fault as described in 1),
the second is that testcase uses a unknown signal 33 for test, and this will lead sigaction cannot bind signal 33 to the action.

So, we attempt to use a known signal instead, such as 34.

which is just as bogus and unportable. if the test needs a real time signal, it should leverage the sigrtmin...sigrtmax defines.
-mike

------------------------------------------------------------------------

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
------------------------------------------------------------------------

Quoted 5 lines

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Quoted 9 lines

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

author
#8 lore raw

Hi, Subrata,

Quoted 5 lines · Subrata Modak

Liubo,

Are you sending an updated patch post this discussion ?

Yes, I'll resend a updated patch about these rt_sigs.

Regards--
Liubo

Quoted 86 lines

Regards--
Subrata

Quoted 77 lines · Wei Yongjun
Quoted 25 lines · Mike Frysinger
Quoted 12 lines · On Tuesday 10 November 2009 04:38:30 liubo wrote:

1) rt_sigaction
"sigaction" has the structure:

 struct sigaction {
         __sighandler_t sa_handler;
         unsigned long sa_flags;
  #ifdef SA_RESTORER
          __sigrestore_t sa_restorer;

#endif
sigset_t sa_mask; /* mask last for extensibility */
};

Quoted 10 lines

However, on arch x86_64, if we directly get to call rt_sigaction,
the argument "sa_restorer" will not be fulfilled, and this will lead
to segment fault.
on arch x86_64, if sa_restorer is not set, kernel will lead to segment
fault. In other arch, if sa_restorer is not set, kernel can do the correct work. To avoid this segment fault, we use glibc function
"int sigaction(...);" instead, which can fulfill the argument
"sa_restorer".

Quoted 4 lines

which defeats the purpose of the test. there is no guarantee that the C library sigaction function is implemented via the __NR_rt_sigaction syscall.

In x86_64, it do this. And If we want to use __NR_rt_sigaction syscall directly, we must fill the sa_restorer and set the RESTORER flag to sa_mask. If we do not set the sa_restorer, kill will always cause segment fault.

Quoted 24 lines
Quoted 11 lines

2) rt_sigprocmask
This failure contains two aspects,
the first is the segment fault as described in 1),
the second is that testcase uses a unknown signal 33 for test, and this will lead sigaction cannot bind signal 33 to the action.

So, we attempt to use a known signal instead, such as 34.

which is just as bogus and unportable. if the test needs a real time signal, it should leverage the sigrtmin...sigrtmax defines.
-mike

------------------------------------------------------------------------

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
------------------------------------------------------------------------

Quoted 6 lines

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#9 lore raw
Quoted 71 lines · liubo

Hi, Subrata,
On 11/16/2009 04:13 PM, Subrata Modak wrote:

Liubo,

Are you sending an updated patch post this discussion ?

Yes, I'll resend a updated patch about these rt_sigs.

Regards--
Liubo

Regards--
Subrata

On Wed, 2009-11-11 at 13:03 +0800, Wei Yongjun wrote:

Mike Frysinger wrote:

On Tuesday 10 November 2009 04:38:30 liubo wrote:

1) rt_sigaction
"sigaction" has the structure:

 struct sigaction {
         __sighandler_t sa_handler;
         unsigned long sa_flags;
  #ifdef SA_RESTORER
          __sigrestore_t sa_restorer;

#endif
sigset_t sa_mask; /* mask last for extensibility */
};

However, on arch x86_64, if we directly get to call rt_sigaction,
the argument "sa_restorer" will not be fulfilled, and this will lead
to segment fault.
on arch x86_64, if sa_restorer is not set, kernel will lead to segment
fault. In other arch, if sa_restorer is not set, kernel can do the correct work. To avoid this segment fault, we use glibc function
"int sigaction(...);" instead, which can fulfill the argument
"sa_restorer".

which defeats the purpose of the test. there is no guarantee that the C library sigaction function is implemented via the __NR_rt_sigaction syscall.

In x86_64, it do this. And If we want to use __NR_rt_sigaction syscall directly, we must fill the sa_restorer and set the RESTORER flag to sa_mask. If we do not set the sa_restorer, kill will always cause segment fault.

2) rt_sigprocmask
This failure contains two aspects,
the first is the segment fault as described in 1),
the second is that testcase uses a unknown signal 33 for test, and this will lead sigaction cannot bind signal 33 to the action.

Quoted 8 lines

So, we attempt to use a known signal instead, such as 34.

which is just as bogus and unportable. if the test needs a real time signal,
it should leverage the sigrtmin...sigrtmax defines.
-mike

I see what you mean about this testcase segfaulting now.

I've done some exploring, and while sigaction does map to rt_sigaction on ia64 and x86_64, it won't on arm, mips, s390*, sh, or x86.

Furthermore, the problem is actually being caused by the fact that we're not even calling sigaddset properly!

gcooper@orangebox /scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction $ gdb ./rt_sigaction01
GNU gdb 6.8
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu"...
(gdb) c
The program is not being run.
(gdb) r
Starting program:
/scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction/rt_sigaction01 thread:20
[Thread debugging using libthread_db enabled]

rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    1  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    2  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    3  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    4  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    5  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    6  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    7  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    8  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    9  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   10  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   11  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   12  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   13  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   14  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   15  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   16  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   17  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   18  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   19  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   20  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   21  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   22  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   23  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   24  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   25  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   26  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   27  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   28  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   29  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   30  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument

So, the test needs fixing, anyhow. After I fixed it, the test still segfaulted >:( --

gcooper@orangebox /scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction $ gdb ./rt_sigaction01
GNU gdb 6.8
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu"...
(gdb) r
Starting program:
/scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction/rt_sigaction01 thread:20
[Thread debugging using libthread_db enabled]

rt_sigaction01    0  TINFO  :  signal: 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO

[New Thread 0x7fdd451d66f0 (LWP 31927)]

Program received signal SIG34, Real-time event 34. [Switching to Thread 0x7fdd451d66f0 (LWP 31927)] 0x00007fdd448944f7 in kill () from /lib/libc.so.6 (gdb) c
Continuing.

Program received signal SIGSEGV, Segmentation fault. 0x00007fdd448944f7 in kill () from /lib/libc.so.6

So I tried to do some digging. glibc 2.8-20080602 does the following for alpha, i386, and sysv:

result = INLINE_SYSCALL (rt_sigaction, 4,
sig, act ? __ptrvalue (&kact) : NULL, oact ? __ptrvalue (&koact) : NULL, _NSIG / 8);

The kernel code for rt_sigaction in kernel/signal.c is as follows:

#ifdef __ARCH_WANT_SYS_RT_SIGACTION SYSCALL_DEFINE4(rt_sigaction, int, sig,
const struct sigaction __user *, act, struct sigaction __user *, oact, size_t, sigsetsize)

{
        struct k_sigaction new_sa, old_sa;
        int ret = -EINVAL;

        /* XXX: Don't preclude handling different sized sigset_t's.  */
        if (sigsetsize != sizeof(sigset_t))
                goto out;

        if (act) {
                if (copy_from_user(&new_sa.sa, act, sizeof(new_sa.sa)))
                        return -EFAULT;
        }

        ret = do_sigaction(sig, act ? &new_sa : NULL, oact ? &old_sa : NULL);

        if (!ret && oact) {
                if (copy_to_user(oact, &old_sa.sa, sizeof(old_sa.sa)))
                        return -EFAULT;
        }
out:
        return ret;
}

This just blows my mind because rt_sigaction is just calling do_sigaction, which is the same code as sigaction AFAICT, apart from the fact that rt_sigaction completely disregards sa_restorer on some architectures because it's obsolete, and requires the end-user to specify a signal mask set (here's mips' version, which wasn't the same as i386's version -- i386 had the old sa_restorer code):

SYSCALL_DEFINE3(sigaction, int, sig, const struct sigaction __user *, act,
struct sigaction __user *, oact)

{
        struct k_sigaction new_ka, old_ka;
        int ret;
        int err = 0;

        if (act) {
                old_sigset_t mask;

                if (!access_ok(VERIFY_READ, act, sizeof(*act)))
                        return -EFAULT;
                err |= __get_user(new_ka.sa.sa_handler, &act->sa_handler);
                err |= __get_user(new_ka.sa.sa_flags, &act->sa_flags);
                err |= __get_user(mask, &act->sa_mask.sig[0]);
                if (err)
                        return -EFAULT;

                siginitset(&new_ka.sa.sa_mask, mask);
        }

        ret = do_sigaction(sig, act ? &new_ka : NULL, oact ? &old_ka : NULL);

        if (!ret && oact) {
                if (!access_ok(VERIFY_WRITE, oact, sizeof(*oact)))
                        return -EFAULT;
                err |= __put_user(old_ka.sa.sa_flags, &oact->sa_flags);
                err |= __put_user(old_ka.sa.sa_handler, &oact->sa_handler);
                err |= __put_user(old_ka.sa.sa_mask.sig[0], oact->sa_mask.sig);
                err |= __put_user(0, &oact->sa_mask.sig[1]);
                err |= __put_user(0, &oact->sa_mask.sig[2]);
                err |= __put_user(0, &oact->sa_mask.sig[3]);
                if (err)
                        return -EFAULT;
        }

        return ret;
}

I dunno -- maybe someone else can read the kernel code better than me, but it looks like there's zero real value to the rt_sigaction testcases, because it can be covered by sigaction...

Thanks,
-Garrett

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

author
#10 lore raw

Hi, Garrett

Quoted 313 lines · Garrett Cooper
Quoted 71 lines · liubo

Hi, Subrata,
On 11/16/2009 04:13 PM, Subrata Modak wrote:

Liubo,

Are you sending an updated patch post this discussion ?

Yes, I'll resend a updated patch about these rt_sigs.

Regards--
Liubo

Regards--
Subrata

On Wed, 2009-11-11 at 13:03 +0800, Wei Yongjun wrote:

Mike Frysinger wrote:

On Tuesday 10 November 2009 04:38:30 liubo wrote:

1) rt_sigaction
"sigaction" has the structure:

 struct sigaction {
         __sighandler_t sa_handler;
         unsigned long sa_flags;
  #ifdef SA_RESTORER
          __sigrestore_t sa_restorer;

#endif
sigset_t sa_mask; /* mask last for extensibility */
};

However, on arch x86_64, if we directly get to call rt_sigaction,
the argument "sa_restorer" will not be fulfilled, and this will lead
to segment fault.
on arch x86_64, if sa_restorer is not set, kernel will lead to segment
fault. In other arch, if sa_restorer is not set, kernel can do the correct work. To avoid this segment fault, we use glibc function
"int sigaction(...);" instead, which can fulfill the argument
"sa_restorer".

which defeats the purpose of the test. there is no guarantee that the C library sigaction function is implemented via the __NR_rt_sigaction syscall.

In x86_64, it do this. And If we want to use __NR_rt_sigaction syscall directly, we must fill the sa_restorer and set the RESTORER flag to sa_mask. If we do not set the sa_restorer, kill will always cause segment fault.

2) rt_sigprocmask
This failure contains two aspects,
the first is the segment fault as described in 1),
the second is that testcase uses a unknown signal 33 for test, and this will lead sigaction cannot bind signal 33 to the action.

Quoted 9 lines

So, we attempt to use a known signal instead, such as 34.

which is just as bogus and unportable. if the test needs a real time signal,
it should leverage the sigrtmin...sigrtmax defines.
-mike

I see what you mean about this testcase segfaulting now.

I've done some exploring, and while sigaction does map to rt_sigaction on ia64 and x86_64, it won't on arm, mips, s390*, sh, or x86.

Furthermore, the problem is actually being caused by the fact that we're not even calling sigaddset properly!

gcooper@orangebox /scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction $ gdb ./rt_sigaction01
GNU gdb 6.8
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu"...
(gdb) c
The program is not being run.
(gdb) r
Starting program:
/scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction/rt_sigaction01 thread:20
[Thread debugging using libthread_db enabled]

rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    1  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    2  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    3  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    4  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    5  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    6  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    7  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    8  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    9  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   10  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   11  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   12  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   13  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   14  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   15  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   16  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   17  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   18  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   19  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   20  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   21  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   22  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   23  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   24  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   25  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   26  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   27  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   28  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   29  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   30  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument

So, the test needs fixing, anyhow. After I fixed it, the test still segfaulted >:( --

gcooper@orangebox /scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction $ gdb ./rt_sigaction01
GNU gdb 6.8
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu"...
(gdb) r
Starting program:
/scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction/rt_sigaction01 thread:20
[Thread debugging using libthread_db enabled]

rt_sigaction01    0  TINFO  :  signal: 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO

[New Thread 0x7fdd451d66f0 (LWP 31927)]

Program received signal SIG34, Real-time event 34. [Switching to Thread 0x7fdd451d66f0 (LWP 31927)] 0x00007fdd448944f7 in kill () from /lib/libc.so.6 (gdb) c
Continuing.

Program received signal SIGSEGV, Segmentation fault. 0x00007fdd448944f7 in kill () from /lib/libc.so.6

So I tried to do some digging. glibc 2.8-20080602 does the following for alpha, i386, and sysv:

result = INLINE_SYSCALL (rt_sigaction, 4,
sig, act ? __ptrvalue (&kact) : NULL, oact ? __ptrvalue (&koact) : NULL, _NSIG / 8);

The kernel code for rt_sigaction in kernel/signal.c is as follows:

#ifdef __ARCH_WANT_SYS_RT_SIGACTION SYSCALL_DEFINE4(rt_sigaction, int, sig,
const struct sigaction __user *, act, struct sigaction __user *, oact, size_t, sigsetsize)

{
        struct k_sigaction new_sa, old_sa;
        int ret = -EINVAL;

        /* XXX: Don't preclude handling different sized sigset_t's.  */
        if (sigsetsize != sizeof(sigset_t))
                goto out;

        if (act) {
                if (copy_from_user(&new_sa.sa, act, sizeof(new_sa.sa)))
                        return -EFAULT;
        }

        ret = do_sigaction(sig, act ? &new_sa : NULL, oact ? &old_sa : NULL);

        if (!ret && oact) {
                if (copy_to_user(oact, &old_sa.sa, sizeof(old_sa.sa)))
                        return -EFAULT;
        }
out:
        return ret;
}

This just blows my mind because rt_sigaction is just calling do_sigaction, which is the same code as sigaction AFAICT, apart from the fact that rt_sigaction completely disregards sa_restorer on some architectures because it's obsolete, and requires the end-user to specify a signal mask set (here's mips' version, which wasn't the same as i386's version -- i386 had the old sa_restorer code):

SYSCALL_DEFINE3(sigaction, int, sig, const struct sigaction __user *, act,
struct sigaction __user *, oact)

{
        struct k_sigaction new_ka, old_ka;
        int ret;
        int err = 0;

        if (act) {
                old_sigset_t mask;

                if (!access_ok(VERIFY_READ, act, sizeof(*act)))
                        return -EFAULT;
                err |= __get_user(new_ka.sa.sa_handler, &act->sa_handler);
                err |= __get_user(new_ka.sa.sa_flags, &act->sa_flags);
                err |= __get_user(mask, &act->sa_mask.sig[0]);
                if (err)
                        return -EFAULT;

                siginitset(&new_ka.sa.sa_mask, mask);
        }

        ret = do_sigaction(sig, act ? &new_ka : NULL, oact ? &old_ka : NULL);

        if (!ret && oact) {
                if (!access_ok(VERIFY_WRITE, oact, sizeof(*oact)))
                        return -EFAULT;
                err |= __put_user(old_ka.sa.sa_flags, &oact->sa_flags);
                err |= __put_user(old_ka.sa.sa_handler, &oact->sa_handler);
                err |= __put_user(old_ka.sa.sa_mask.sig[0], oact->sa_mask.sig);
                err |= __put_user(0, &oact->sa_mask.sig[1]);
                err |= __put_user(0, &oact->sa_mask.sig[2]);
                err |= __put_user(0, &oact->sa_mask.sig[3]);
                if (err)
                        return -EFAULT;
        }

        return ret;
}
Quoted 5 lines

I dunno -- maybe someone else can read the kernel code better than me, but it looks like there's zero real value to the rt_sigaction testcases, because it can be covered by sigaction...

We just tell guys who use these testcases on arch x86_64 that "Syscall rt_sigaction cannot be called directly on arch x86_64.", can we?

Quoted 5 lines

Thanks,
-Garrett

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#11 lore raw
Quoted 329 lines · liubo

Hi, Garrett
On 11/26/2009 07:11 PM, Garrett Cooper wrote:

On Mon, Nov 16, 2009 at 12:53 AM, liubo <[email protected]> wrote:

Hi, Subrata,
On 11/16/2009 04:13 PM, Subrata Modak wrote:

Liubo,

Are you sending an updated patch post this discussion ?

Yes, I'll resend a updated patch about these rt_sigs.

Regards--
Liubo

Regards--
Subrata

On Wed, 2009-11-11 at 13:03 +0800, Wei Yongjun wrote:

Mike Frysinger wrote:

On Tuesday 10 November 2009 04:38:30 liubo wrote:

1) rt_sigaction
"sigaction" has the structure:

 struct sigaction {
         __sighandler_t sa_handler;
         unsigned long sa_flags;
  #ifdef SA_RESTORER
          __sigrestore_t sa_restorer;

#endif
sigset_t sa_mask; /* mask last for extensibility */
};

However, on arch x86_64, if we directly get to call rt_sigaction,
the argument "sa_restorer" will not be fulfilled, and this will lead
to segment fault.
on arch x86_64, if sa_restorer is not set, kernel will lead to segment
fault. In other arch, if sa_restorer is not set, kernel can do the correct work. To avoid this segment fault, we use glibc function
"int sigaction(...);" instead, which can fulfill the argument
"sa_restorer".

which defeats the purpose of the test. there is no guarantee that the C library sigaction function is implemented via the __NR_rt_sigaction syscall.

In x86_64, it do this. And If we want to use __NR_rt_sigaction syscall directly, we must fill the sa_restorer and set the RESTORER flag to sa_mask. If we do not set the sa_restorer, kill will always cause segment fault.

2) rt_sigprocmask
This failure contains two aspects,
the first is the segment fault as described in 1),
the second is that testcase uses a unknown signal 33 for test, and this will lead sigaction cannot bind signal 33 to the action.

So, we attempt to use a known signal instead, such as 34.

which is just as bogus and unportable. if the test needs a real time signal,
it should leverage the sigrtmin...sigrtmax defines.
-mike

I see what you mean about this testcase segfaulting now.

I've done some exploring, and while sigaction does map to rt_sigaction on ia64 and x86_64, it won't on arm, mips, s390*, sh, or x86.

Furthermore, the problem is actually being caused by the fact that we're not even calling sigaddset properly!

gcooper@orangebox /scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction $ gdb ./rt_sigaction01
GNU gdb 6.8
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu"...
(gdb) c
The program is not being run.
(gdb) r
Starting program:
/scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction/rt_sigaction01 thread:20
[Thread debugging using libthread_db enabled]

rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    1  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    2  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    3  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    4  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    5  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    6  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    7  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    8  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    9  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   10  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   11  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   12  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   13  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   14  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   15  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   16  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   17  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   18  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   19  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   20  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   21  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   22  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   23  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   24  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   25  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   26  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   27  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   28  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   29  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   30  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument

So, the test needs fixing, anyhow. After I fixed it, the test still segfaulted >:( --

gcooper@orangebox /scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction $ gdb ./rt_sigaction01
GNU gdb 6.8
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu"...
(gdb) r
Starting program:
/scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction/rt_sigaction01 thread:20
[Thread debugging using libthread_db enabled]

rt_sigaction01    0  TINFO  :  signal: 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO

[New Thread 0x7fdd451d66f0 (LWP 31927)]

Program received signal SIG34, Real-time event 34. [Switching to Thread 0x7fdd451d66f0 (LWP 31927)] 0x00007fdd448944f7 in kill () from /lib/libc.so.6 (gdb) c
Continuing.

Program received signal SIGSEGV, Segmentation fault. 0x00007fdd448944f7 in kill () from /lib/libc.so.6

So I tried to do some digging. glibc 2.8-20080602 does the following for alpha, i386, and sysv:

result = INLINE_SYSCALL (rt_sigaction, 4,
sig, act ? __ptrvalue (&kact) : NULL, oact ? __ptrvalue (&koact) : NULL, _NSIG /
8);

The kernel code for rt_sigaction in kernel/signal.c is as follows:

#ifdef __ARCH_WANT_SYS_RT_SIGACTION SYSCALL_DEFINE4(rt_sigaction, int, sig,
const struct sigaction __user *, act, struct sigaction __user *, oact, size_t, sigsetsize)

{
        struct k_sigaction new_sa, old_sa;
        int ret = -EINVAL;

        /* XXX: Don't preclude handling different sized sigset_t's.  */
        if (sigsetsize != sizeof(sigset_t))
                goto out;

        if (act) {
                if (copy_from_user(&new_sa.sa, act, sizeof(new_sa.sa)))
                        return -EFAULT;
        }

        ret = do_sigaction(sig, act ? &new_sa : NULL, oact ? &old_sa :

NULL);

        if (!ret && oact) {
                if (copy_to_user(oact, &old_sa.sa, sizeof(old_sa.sa)))
                        return -EFAULT;
        }
out:
        return ret;
}

This just blows my mind because rt_sigaction is just calling do_sigaction, which is the same code as sigaction AFAICT, apart from the fact that rt_sigaction completely disregards sa_restorer on some architectures because it's obsolete, and requires the end-user to specify a signal mask set (here's mips' version, which wasn't the same as i386's version -- i386 had the old sa_restorer code):

SYSCALL_DEFINE3(sigaction, int, sig, const struct sigaction __user *, act,
struct sigaction __user *, oact)

{
        struct k_sigaction new_ka, old_ka;
        int ret;
        int err = 0;

        if (act) {
                old_sigset_t mask;

                if (!access_ok(VERIFY_READ, act, sizeof(*act)))
                        return -EFAULT;
                err |= __get_user(new_ka.sa.sa_handler, &act->sa_handler);
                err |= __get_user(new_ka.sa.sa_flags, &act->sa_flags);
                err |= __get_user(mask, &act->sa_mask.sig[0]);
                if (err)
                        return -EFAULT;

                siginitset(&new_ka.sa.sa_mask, mask);
        }

        ret = do_sigaction(sig, act ? &new_ka : NULL, oact ? &old_ka :

NULL);

        if (!ret && oact) {
                if (!access_ok(VERIFY_WRITE, oact, sizeof(*oact)))
                        return -EFAULT;
                err |= __put_user(old_ka.sa.sa_flags, &oact->sa_flags);
                err |= __put_user(old_ka.sa.sa_handler, &oact->sa_handler);
                err |= __put_user(old_ka.sa.sa_mask.sig[0],
oact->sa_mask.sig);
                err |= __put_user(0, &oact->sa_mask.sig[1]);
                err |= __put_user(0, &oact->sa_mask.sig[2]);
                err |= __put_user(0, &oact->sa_mask.sig[3]);
                if (err)
                        return -EFAULT;
        }

        return ret;
}

I dunno -- maybe someone else can read the kernel code better than me, but it looks like there's zero real value to the rt_sigaction testcases, because it can be covered by sigaction...

Quoted 3 lines

    We just tell guys who use these testcases on arch x86_64 that "Syscall rt_sigaction cannot be called directly on arch x86_64.", can we?

It's not just x86_64 -- it's also ia64, and this may change
depending on the version of glibc and linux sources, so... this really isn't a viable solution IMO.
Does anyone have any better suggestions, apart from just using a
preprocessor macro that would execute rt_sig* via their non-rt equivalents in ltp_signal.h?
Thanks,
-Garrett

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#12 lore raw
Quoted 334 lines · Garrett Cooper
Quoted 329 lines · liubo

Hi, Garrett
On 11/26/2009 07:11 PM, Garrett Cooper wrote:

On Mon, Nov 16, 2009 at 12:53 AM, liubo <[email protected]> wrote:

Hi, Subrata,
On 11/16/2009 04:13 PM, Subrata Modak wrote:

Liubo,

Are you sending an updated patch post this discussion ?

Yes, I'll resend a updated patch about these rt_sigs.

Regards--
Liubo

Regards--
Subrata

On Wed, 2009-11-11 at 13:03 +0800, Wei Yongjun wrote:

Mike Frysinger wrote:

On Tuesday 10 November 2009 04:38:30 liubo wrote:

1) rt_sigaction
    "sigaction" has the structure:

 struct sigaction {
         __sighandler_t sa_handler;
         unsigned long sa_flags;
  #ifdef SA_RESTORER
          __sigrestore_t sa_restorer;
  #endif
          sigset_t sa_mask;               /* mask last for extensibility */ };

    However, on arch x86_64, if we directly get to call rt_sigaction, the argument "sa_restorer" will not be fulfilled, and this will lead to segment fault.
    on arch x86_64, if sa_restorer is not set, kernel will lead to segment fault. In other arch, if sa_restorer is not set, kernel can do the correct work. To avoid this segment fault, we use glibc function
"int sigaction(...);" instead, which can fulfill the argument "sa_restorer".

which defeats the purpose of the test.  there is no guarantee that the C library sigaction function is implemented via the __NR_rt_sigaction syscall.

In x86_64, it do this. And If we want to use __NR_rt_sigaction syscall directly, we must fill the sa_restorer and set the RESTORER flag to sa_mask. If we do not set the sa_restorer, kill will always cause segment fault.

2) rt_sigprocmask
    This failure contains two aspects,
the first is the segment fault as described in 1),
the second is that testcase uses a unknown signal 33 for test, and this will lead sigaction cannot bind signal 33 to the action.

    So, we attempt to use a known signal instead, such as 34.

which is just as bogus and unportable.  if the test needs a real time signal,
it should leverage the sigrtmin...sigrtmax defines.
-mike

I see what you mean about this testcase segfaulting now.

I've done some exploring, and while sigaction does map to rt_sigaction on ia64 and x86_64, it won't on arm, mips, s390*, sh, or x86.

Furthermore, the problem is actually being caused by the fact that we're not even calling sigaddset properly!

gcooper@orangebox /scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction $ gdb ./rt_sigaction01
GNU gdb 6.8
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law.  Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu"...
(gdb) c
The program is not being run.
(gdb) r
Starting program:
/scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction/rt_sigaction01 thread:20
[Thread debugging using libthread_db enabled]
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    1  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    2  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    3  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    4  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    5  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    6  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    7  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    8  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    9  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   10  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   11  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   12  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   13  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   14  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   15  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   16  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   17  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   18  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   19  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   20  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   21  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   22  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   23  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   24  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   25  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   26  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   27  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   28  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   29  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   30  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument

So, the test needs fixing, anyhow. After I fixed it, the test still segfaulted >:( --

gcooper@orangebox /scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction $ gdb ./rt_sigaction01
GNU gdb 6.8
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law.  Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu"...
(gdb) r
Starting program:
/scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction/rt_sigaction01 thread:20
[Thread debugging using libthread_db enabled]
rt_sigaction01    0  TINFO  :  signal: 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO [New Thread 0x7fdd451d66f0 (LWP 31927)]

Program received signal SIG34, Real-time event 34. [Switching to Thread 0x7fdd451d66f0 (LWP 31927)] 0x00007fdd448944f7 in kill () from /lib/libc.so.6 (gdb) c
Continuing.

Program received signal SIGSEGV, Segmentation fault. 0x00007fdd448944f7 in kill () from /lib/libc.so.6

So I tried to do some digging. glibc 2.8-20080602 does the following for alpha, i386, and sysv:

      result = INLINE_SYSCALL (rt_sigaction, 4,
                               sig, act ? __ptrvalue (&kact) : NULL, oact ? __ptrvalue (&koact) : NULL, _NSIG / 8);

The kernel code for rt_sigaction in kernel/signal.c is as follows:

#ifdef __ARCH_WANT_SYS_RT_SIGACTION SYSCALL_DEFINE4(rt_sigaction, int, sig,
                const struct sigaction __user *, act, struct sigaction __user *, oact, size_t, sigsetsize)
{
        struct k_sigaction new_sa, old_sa; int ret = -EINVAL;

        /* XXX: Don't preclude handling different sized sigset_t's.  */ if (sigsetsize != sizeof(sigset_t))
                goto out;

        if (act) {
                if (copy_from_user(&new_sa.sa, act, sizeof(new_sa.sa))) return -EFAULT;
        }

        ret = do_sigaction(sig, act ? &new_sa : NULL, oact ? &old_sa :
NULL);

        if (!ret && oact) {
                if (copy_to_user(oact, &old_sa.sa, sizeof(old_sa.sa))) return -EFAULT;
        }
out:
        return ret;
}

This just blows my mind because rt_sigaction is just calling do_sigaction, which is the same code as sigaction AFAICT, apart from the fact that rt_sigaction completely disregards sa_restorer on some architectures because it's obsolete, and requires the end-user to specify a signal mask set (here's mips' version, which wasn't the same as i386's version -- i386 had the old sa_restorer code):

SYSCALL_DEFINE3(sigaction, int, sig, const struct sigaction __user *, act, struct sigaction __user *, oact)
{
        struct k_sigaction new_ka, old_ka;
        int ret;
        int err = 0;

        if (act) {
                old_sigset_t mask;

                if (!access_ok(VERIFY_READ, act, sizeof(*act))) return -EFAULT;

                err |= __get_user(new_ka.sa.sa_handler, &act->sa_handler);
                err |= __get_user(new_ka.sa.sa_flags, &act->sa_flags);
                err |= __get_user(mask, &act->sa_mask.sig[0]);

                if (err)
                        return -EFAULT;

                siginitset(&new_ka.sa.sa_mask, mask); }

        ret = do_sigaction(sig, act ? &new_ka : NULL, oact ? &old_ka :
NULL);

        if (!ret && oact) {
                if (!access_ok(VERIFY_WRITE, oact, sizeof(*oact))) return -EFAULT;

                err |= __put_user(old_ka.sa.sa_flags, &oact->sa_flags);
                err |= __put_user(old_ka.sa.sa_handler, &oact->sa_handler);
                err |= __put_user(old_ka.sa.sa_mask.sig[0],
oact->sa_mask.sig);
                err |= __put_user(0, &oact->sa_mask.sig[1]);
                err |= __put_user(0, &oact->sa_mask.sig[2]);
                err |= __put_user(0, &oact->sa_mask.sig[3]);

                if (err)
                        return -EFAULT;
        }

        return ret;
}

I dunno -- maybe someone else can read the kernel code better than me, but it looks like there's zero real value to the rt_sigaction testcases, because it can be covered by sigaction...

Quoted 3 lines

    We just tell guys who use these testcases on arch x86_64 that "Syscall rt_sigaction cannot be called directly on arch x86_64.", can we?

Quoted 6 lines

   It's not just x86_64 -- it's also ia64, and this may change depending on the version of glibc and linux sources, so... this really isn't a viable solution IMO.
   Does anyone have any better suggestions, apart from just using a preprocessor macro that would execute rt_sig* via their non-rt equivalents in ltp_signal.h?

AHA! I think I discovered the kernel bug. rt_sigaction on x86_64 assumes that you're working in 32-bit space:

gcooper@orangebox /usr/src/linux $ grep -r rt_sigaction /usr/src/linux/arch/x86* /usr/src/linux/arch/x86/ia32/sys_ia32.c:asmlinkage long sys32_rt_sigaction(int sig, struct sigaction32 __user *act,
Binary file /usr/src/linux/arch/x86/ia32/sys_ia32.o matches
Binary file /usr/src/linux/arch/x86/ia32/built-in.o matches
/usr/src/linux/arch/x86/ia32/ia32entry.S: .quad sys32_rt_sigaction
Binary file /usr/src/linux/arch/x86/ia32/ia32entry.o matches
Binary file /usr/src/linux/arch/x86/kernel/syscall_64.o matches Binary file /usr/src/linux/arch/x86/kernel/built-in.o matches
/usr/src/linux/arch/x86/kernel/syscall_table_32.S: .long sys_rt_sigaction
/usr/src/linux/arch/x86/include/asm/unistd_32.h:#define
__NR_rt_sigaction 174
/usr/src/linux/arch/x86/include/asm/unistd_64.h:#define
__NR_rt_sigaction 13
/usr/src/linux/arch/x86/include/asm/unistd_64.h:__SYSCALL(__NR_rt_sigaction, sys_rt_sigaction) /usr/src/linux/arch/x86/include/asm/sys_ia32.h:asmlinkage long sys32_rt_sigaction(int, struct sigaction32 __user *,

Watch (compiled with -m32):

rt_sigaction01    0  TINFO  :  signal: 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  signal: 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  signal: 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  signal: 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  signal: 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  signal: 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  signal: 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  signal: 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  signal: 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  signal: 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  signal: 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  signal: 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  signal: 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  signal: 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  signal: 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  signal: 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  signal: 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  signal: 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  signal: 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  signal: 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  signal: 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  signal: 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  signal: 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  signal: 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  signal: 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  signal: 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  signal: 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  signal: 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  signal: 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  signal: 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  signal: 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64

So from what I can tell, the sucker isn't properly translating something in 64-bit space, and instead of properly trapping the issue, it's segfaulting and dying -_-.

Ultimately the problem from what I can see is that bi-arch (32-bit on 64-bit kernel) 64-bit rt_sig* support is broken. I don't know about straight, non-bi-arch 64-bit rt_sig* support...

If someone could verify this with a little more kernel experience, or someone could direct me on how the issue could be trapped in gdb so I could inspect the registers and ensure the traps are or aren't being done properly, that would be helpful.

Thanks!
-Garrett

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

author
#13 lore raw

Hi, Garrett

Quoted 715 lines · Garrett Cooper
Quoted 335 lines · Garrett Cooper
Quoted 329 lines · liubo

Hi, Garrett
On 11/26/2009 07:11 PM, Garrett Cooper wrote:

On Mon, Nov 16, 2009 at 12:53 AM, liubo <[email protected]> wrote:

Hi, Subrata,
On 11/16/2009 04:13 PM, Subrata Modak wrote:

Liubo,

Are you sending an updated patch post this discussion ?

Yes, I'll resend a updated patch about these rt_sigs.

Regards--
Liubo

Regards--
Subrata

On Wed, 2009-11-11 at 13:03 +0800, Wei Yongjun wrote:

Mike Frysinger wrote:

On Tuesday 10 November 2009 04:38:30 liubo wrote:

1) rt_sigaction
"sigaction" has the structure:

 struct sigaction {
         __sighandler_t sa_handler;
         unsigned long sa_flags;
  #ifdef SA_RESTORER
          __sigrestore_t sa_restorer;

#endif
sigset_t sa_mask; /* mask last for extensibility */
};

However, on arch x86_64, if we directly get to call rt_sigaction,
the argument "sa_restorer" will not be fulfilled, and this will lead
to segment fault.
on arch x86_64, if sa_restorer is not set, kernel will lead to segment
fault. In other arch, if sa_restorer is not set, kernel can do the correct work. To avoid this segment fault, we use glibc function
"int sigaction(...);" instead, which can fulfill the argument
"sa_restorer".

which defeats the purpose of the test. there is no guarantee that the C library sigaction function is implemented via the __NR_rt_sigaction syscall.

In x86_64, it do this. And If we want to use __NR_rt_sigaction syscall directly, we must fill the sa_restorer and set the RESTORER flag to sa_mask. If we do not set the sa_restorer, kill will always cause segment fault.

2) rt_sigprocmask
This failure contains two aspects,
the first is the segment fault as described in 1),
the second is that testcase uses a unknown signal 33 for test, and this will lead sigaction cannot bind signal 33 to the action.

So, we attempt to use a known signal instead, such as 34.

which is just as bogus and unportable. if the test needs a real time signal,
it should leverage the sigrtmin...sigrtmax defines.
-mike

I see what you mean about this testcase segfaulting now.

I've done some exploring, and while sigaction does map to rt_sigaction on ia64 and x86_64, it won't on arm, mips, s390*, sh, or x86.

Furthermore, the problem is actually being caused by the fact that we're not even calling sigaddset properly!

gcooper@orangebox /scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction $ gdb ./rt_sigaction01
GNU gdb 6.8
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu"...
(gdb) c
The program is not being run.
(gdb) r
Starting program:
/scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction/rt_sigaction01 thread:20
[Thread debugging using libthread_db enabled]

rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    1  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    2  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    3  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    4  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    5  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    6  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    7  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    8  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    9  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   10  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   11  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   12  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   13  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   14  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   15  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   16  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   17  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   18  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   19  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   20  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   21  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   22  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   23  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   24  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   25  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   26  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   27  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   28  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   29  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   30  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument

So, the test needs fixing, anyhow. After I fixed it, the test still segfaulted >:( --

gcooper@orangebox /scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction $ gdb ./rt_sigaction01
GNU gdb 6.8
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu"...
(gdb) r
Starting program:
/scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction/rt_sigaction01 thread:20
[Thread debugging using libthread_db enabled]

rt_sigaction01    0  TINFO  :  signal: 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO

[New Thread 0x7fdd451d66f0 (LWP 31927)]

Program received signal SIG34, Real-time event 34. [Switching to Thread 0x7fdd451d66f0 (LWP 31927)] 0x00007fdd448944f7 in kill () from /lib/libc.so.6 (gdb) c
Continuing.

Program received signal SIGSEGV, Segmentation fault. 0x00007fdd448944f7 in kill () from /lib/libc.so.6

So I tried to do some digging. glibc 2.8-20080602 does the following for alpha, i386, and sysv:

result = INLINE_SYSCALL (rt_sigaction, 4,
sig, act ? __ptrvalue (&kact) : NULL, oact ? __ptrvalue (&koact) : NULL, _NSIG /
8);

The kernel code for rt_sigaction in kernel/signal.c is as follows:

#ifdef __ARCH_WANT_SYS_RT_SIGACTION SYSCALL_DEFINE4(rt_sigaction, int, sig,
const struct sigaction __user *, act, struct sigaction __user *, oact, size_t, sigsetsize)

{
        struct k_sigaction new_sa, old_sa;
        int ret = -EINVAL;

        /* XXX: Don't preclude handling different sized sigset_t's.  */
        if (sigsetsize != sizeof(sigset_t))
                goto out;

        if (act) {
                if (copy_from_user(&new_sa.sa, act, sizeof(new_sa.sa)))
                        return -EFAULT;
        }

        ret = do_sigaction(sig, act ? &new_sa : NULL, oact ? &old_sa :

NULL);

        if (!ret && oact) {
                if (copy_to_user(oact, &old_sa.sa, sizeof(old_sa.sa)))
                        return -EFAULT;
        }
out:
        return ret;
}

This just blows my mind because rt_sigaction is just calling do_sigaction, which is the same code as sigaction AFAICT, apart from the fact that rt_sigaction completely disregards sa_restorer on some architectures because it's obsolete, and requires the end-user to specify a signal mask set (here's mips' version, which wasn't the same as i386's version -- i386 had the old sa_restorer code):

SYSCALL_DEFINE3(sigaction, int, sig, const struct sigaction __user *, act,
struct sigaction __user *, oact)

{
        struct k_sigaction new_ka, old_ka;
        int ret;
        int err = 0;

        if (act) {
                old_sigset_t mask;

                if (!access_ok(VERIFY_READ, act, sizeof(*act)))
                        return -EFAULT;
                err |= __get_user(new_ka.sa.sa_handler, &act->sa_handler);
                err |= __get_user(new_ka.sa.sa_flags, &act->sa_flags);
                err |= __get_user(mask, &act->sa_mask.sig[0]);
                if (err)
                        return -EFAULT;

                siginitset(&new_ka.sa.sa_mask, mask);
        }

        ret = do_sigaction(sig, act ? &new_ka : NULL, oact ? &old_ka :

NULL);

        if (!ret && oact) {
                if (!access_ok(VERIFY_WRITE, oact, sizeof(*oact)))
                        return -EFAULT;
                err |= __put_user(old_ka.sa.sa_flags, &oact->sa_flags);
                err |= __put_user(old_ka.sa.sa_handler, &oact->sa_handler);
                err |= __put_user(old_ka.sa.sa_mask.sig[0],
oact->sa_mask.sig);
                err |= __put_user(0, &oact->sa_mask.sig[1]);
                err |= __put_user(0, &oact->sa_mask.sig[2]);
                err |= __put_user(0, &oact->sa_mask.sig[3]);
                if (err)
                        return -EFAULT;
        }

        return ret;
}

I dunno -- maybe someone else can read the kernel code better than me, but it looks like there's zero real value to the rt_sigaction testcases, because it can be covered by sigaction...

Quoted 4 lines

We just tell guys who use these testcases on arch x86_64 that "Syscall rt_sigaction cannot be called directly on arch x86_64.", can we?

Quoted 7 lines

It's not just x86_64 -- it's also ia64, and this may change
depending on the version of glibc and linux sources, so... this really isn't a viable solution IMO.
Does anyone have any better suggestions, apart from just using a
preprocessor macro that would execute rt_sig* via their non-rt equivalents in ltp_signal.h?

AHA! I think I discovered the kernel bug. rt_sigaction on x86_64 assumes that you're working in 32-bit space:

gcooper@orangebox /usr/src/linux $ grep -r rt_sigaction /usr/src/linux/arch/x86* /usr/src/linux/arch/x86/ia32/sys_ia32.c:asmlinkage long sys32_rt_sigaction(int sig, struct sigaction32 __user *act,
Binary file /usr/src/linux/arch/x86/ia32/sys_ia32.o matches
Binary file /usr/src/linux/arch/x86/ia32/built-in.o matches
/usr/src/linux/arch/x86/ia32/ia32entry.S: .quad sys32_rt_sigaction
Binary file /usr/src/linux/arch/x86/ia32/ia32entry.o matches
Binary file /usr/src/linux/arch/x86/kernel/syscall_64.o matches Binary file /usr/src/linux/arch/x86/kernel/built-in.o matches
/usr/src/linux/arch/x86/kernel/syscall_table_32.S: .long sys_rt_sigaction
/usr/src/linux/arch/x86/include/asm/unistd_32.h:#define
__NR_rt_sigaction 174
/usr/src/linux/arch/x86/include/asm/unistd_64.h:#define
__NR_rt_sigaction 13
/usr/src/linux/arch/x86/include/asm/unistd_64.h:__SYSCALL(__NR_rt_sigaction, sys_rt_sigaction) /usr/src/linux/arch/x86/include/asm/sys_ia32.h:asmlinkage long sys32_rt_sigaction(int, struct sigaction32 __user *,

Watch (compiled with -m32):

rt_sigaction01    0  TINFO  :  signal: 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  signal: 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  signal: 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  signal: 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  signal: 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  signal: 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  signal: 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  signal: 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  signal: 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  signal: 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  signal: 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  signal: 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  signal: 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  signal: 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  signal: 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  signal: 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  signal: 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  signal: 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  signal: 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  signal: 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  signal: 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  signal: 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  signal: 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  signal: 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  signal: 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  signal: 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  signal: 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  signal: 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  signal: 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  signal: 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  signal: 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64

So from what I can tell, the sucker isn't properly translating something in 64-bit space, and instead of properly trapping the issue, it's segfaulting and dying -_-.

Quoted 10 lines

Ultimately the problem from what I can see is that bi-arch (32-bit on 64-bit kernel) 64-bit rt_sig* support is broken. I don't know about straight, non-bi-arch 64-bit rt_sig* support...

If someone could verify this with a little more kernel experience, or someone could direct me on how the issue could be trapped in gdb so I could inspect the registers and ensure the traps are or aren't being done properly, that would be helpful.

Although I had figured this, I think your solution is just a compromise, isn't it?
Change 64-bit rt_sigaction to 32-bit rt_sigaction to pass the testcase. Let's try to use 64bit rt_sigaction to pass it. ^_^

Thanks~
Liubo

Quoted 5 lines

Thanks!
-Garrett

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#14 lore raw
Quoted 735 lines · liubo

Hi, Garrett

On 11/27/2009 04:50 PM, Garrett Cooper wrote:

On Thu, Nov 26, 2009 at 10:49 PM, Garrett Cooper <[email protected]> wrote:

On Thu, Nov 26, 2009 at 9:33 PM, liubo <[email protected]> wrote:

Hi, Garrett
On 11/26/2009 07:11 PM, Garrett Cooper wrote:

On Mon, Nov 16, 2009 at 12:53 AM, liubo <[email protected]> wrote:

Hi, Subrata,
On 11/16/2009 04:13 PM, Subrata Modak wrote:

Liubo,

Are you sending an updated patch post this discussion ?

Yes, I'll resend a updated patch about these rt_sigs.

Regards--
Liubo

Regards--
Subrata

On Wed, 2009-11-11 at 13:03 +0800, Wei Yongjun wrote:

Mike Frysinger wrote:

On Tuesday 10 November 2009 04:38:30 liubo wrote:

1) rt_sigaction
    "sigaction" has the structure:

 struct sigaction {
         __sighandler_t sa_handler;
         unsigned long sa_flags;
  #ifdef SA_RESTORER
          __sigrestore_t sa_restorer;
  #endif
          sigset_t sa_mask;               /* mask last for extensibility */ };

    However, on arch x86_64, if we directly get to call rt_sigaction, the argument "sa_restorer" will not be fulfilled, and this will lead to segment fault.
    on arch x86_64, if sa_restorer is not set, kernel will lead to segment fault. In other arch, if sa_restorer is not set, kernel can do the correct work. To avoid this segment fault, we use glibc function
"int sigaction(...);" instead, which can fulfill the argument "sa_restorer".

which defeats the purpose of the test.  there is no guarantee that the C library sigaction function is implemented via the __NR_rt_sigaction syscall.

In x86_64, it do this. And If we want to use __NR_rt_sigaction syscall directly, we must fill the sa_restorer and set the RESTORER flag to sa_mask. If we do not set the sa_restorer, kill will always cause segment fault.

2) rt_sigprocmask
    This failure contains two aspects,
the first is the segment fault as described in 1),
the second is that testcase uses a unknown signal 33 for test, and this will lead sigaction cannot bind signal 33 to the action.

    So, we attempt to use a known signal instead, such as 34.

which is just as bogus and unportable.  if the test needs a real time signal,
it should leverage the sigrtmin...sigrtmax defines.
-mike

I see what you mean about this testcase segfaulting now.

I've done some exploring, and while sigaction does map to rt_sigaction on ia64 and x86_64, it won't on arm, mips, s390*, sh, or x86.

Furthermore, the problem is actually being caused by the fact that we're not even calling sigaddset properly!

gcooper@orangebox /scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction $ gdb ./rt_sigaction01
GNU gdb 6.8
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law.  Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu"...
(gdb) c
The program is not being run.
(gdb) r
Starting program:
/scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction/rt_sigaction01 thread:20
[Thread debugging using libthread_db enabled]
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    1  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    2  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    3  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    4  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    5  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    6  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    7  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    8  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    9  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   10  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   11  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   12  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   13  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   14  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   15  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   16  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   17  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   18  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   19  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   20  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   21  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   22  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   23  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   24  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   25  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   26  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   27  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   28  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   29  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   30  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument

So, the test needs fixing, anyhow. After I fixed it, the test still segfaulted >:( --

gcooper@orangebox /scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction $ gdb ./rt_sigaction01
GNU gdb 6.8
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law.  Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu"...
(gdb) r
Starting program:
/scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction/rt_sigaction01 thread:20
[Thread debugging using libthread_db enabled]
rt_sigaction01    0  TINFO  :  signal: 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO [New Thread 0x7fdd451d66f0 (LWP 31927)]

Program received signal SIG34, Real-time event 34. [Switching to Thread 0x7fdd451d66f0 (LWP 31927)] 0x00007fdd448944f7 in kill () from /lib/libc.so.6 (gdb) c
Continuing.

Program received signal SIGSEGV, Segmentation fault. 0x00007fdd448944f7 in kill () from /lib/libc.so.6

So I tried to do some digging. glibc 2.8-20080602 does the following for alpha, i386, and sysv:

      result = INLINE_SYSCALL (rt_sigaction, 4,
                               sig, act ? __ptrvalue (&kact) : NULL, oact ? __ptrvalue (&koact) : NULL, _NSIG / 8);

The kernel code for rt_sigaction in kernel/signal.c is as follows:

#ifdef __ARCH_WANT_SYS_RT_SIGACTION SYSCALL_DEFINE4(rt_sigaction, int, sig,
                const struct sigaction __user *, act, struct sigaction __user *, oact, size_t, sigsetsize)
{
        struct k_sigaction new_sa, old_sa; int ret = -EINVAL;

        /* XXX: Don't preclude handling different sized sigset_t's.  */ if (sigsetsize != sizeof(sigset_t))
                goto out;

        if (act) {
                if (copy_from_user(&new_sa.sa, act, sizeof(new_sa.sa))) return -EFAULT;
        }

        ret = do_sigaction(sig, act ? &new_sa : NULL, oact ? &old_sa :
NULL);

        if (!ret && oact) {
                if (copy_to_user(oact, &old_sa.sa, sizeof(old_sa.sa))) return -EFAULT;
        }
out:
        return ret;
}

This just blows my mind because rt_sigaction is just calling do_sigaction, which is the same code as sigaction AFAICT, apart from the fact that rt_sigaction completely disregards sa_restorer on some architectures because it's obsolete, and requires the end-user to specify a signal mask set (here's mips' version, which wasn't the same as i386's version -- i386 had the old sa_restorer code):

SYSCALL_DEFINE3(sigaction, int, sig, const struct sigaction __user *, act, struct sigaction __user *, oact)
{
        struct k_sigaction new_ka, old_ka;
        int ret;
        int err = 0;

        if (act) {
                old_sigset_t mask;

                if (!access_ok(VERIFY_READ, act, sizeof(*act))) return -EFAULT;

                err |= __get_user(new_ka.sa.sa_handler, &act->sa_handler);
                err |= __get_user(new_ka.sa.sa_flags, &act->sa_flags);
                err |= __get_user(mask, &act->sa_mask.sig[0]);

                if (err)
                        return -EFAULT;

                siginitset(&new_ka.sa.sa_mask, mask); }

        ret = do_sigaction(sig, act ? &new_ka : NULL, oact ? &old_ka :
NULL);

        if (!ret && oact) {
                if (!access_ok(VERIFY_WRITE, oact, sizeof(*oact))) return -EFAULT;

                err |= __put_user(old_ka.sa.sa_flags, &oact->sa_flags);
                err |= __put_user(old_ka.sa.sa_handler, &oact->sa_handler);
                err |= __put_user(old_ka.sa.sa_mask.sig[0],
oact->sa_mask.sig);
                err |= __put_user(0, &oact->sa_mask.sig[1]);
                err |= __put_user(0, &oact->sa_mask.sig[2]);
                err |= __put_user(0, &oact->sa_mask.sig[3]);

                if (err)
                        return -EFAULT;
        }

        return ret;
}

I dunno -- maybe someone else can read the kernel code better than me, but it looks like there's zero real value to the rt_sigaction testcases, because it can be covered by sigaction...

    We just tell guys who use these testcases on arch x86_64 that "Syscall rt_sigaction cannot be called directly on arch x86_64.", can we?

   It's not just x86_64 -- it's also ia64, and this may change depending on the version of glibc and linux sources, so... this really isn't a viable solution IMO.
   Does anyone have any better suggestions, apart from just using a preprocessor macro that would execute rt_sig* via their non-rt equivalents in ltp_signal.h?

AHA! I think I discovered the kernel bug. rt_sigaction on x86_64 assumes that you're working in 32-bit space:

gcooper@orangebox /usr/src/linux $ grep -r rt_sigaction /usr/src/linux/arch/x86* /usr/src/linux/arch/x86/ia32/sys_ia32.c:asmlinkage long sys32_rt_sigaction(int sig, struct sigaction32 __user *act, Binary file /usr/src/linux/arch/x86/ia32/sys_ia32.o matches Binary file /usr/src/linux/arch/x86/ia32/built-in.o matches
/usr/src/linux/arch/x86/ia32/ia32entry.S: .quad sys32_rt_sigaction
Binary file /usr/src/linux/arch/x86/ia32/ia32entry.o matches Binary file /usr/src/linux/arch/x86/kernel/syscall_64.o matches Binary file /usr/src/linux/arch/x86/kernel/built-in.o matches
/usr/src/linux/arch/x86/kernel/syscall_table_32.S: .long
sys_rt_sigaction /usr/src/linux/arch/x86/include/asm/unistd_32.h:#define
__NR_rt_sigaction 174
/usr/src/linux/arch/x86/include/asm/unistd_64.h:#define
__NR_rt_sigaction 13
/usr/src/linux/arch/x86/include/asm/unistd_64.h:__SYSCALL(__NR_rt_sigaction, sys_rt_sigaction) /usr/src/linux/arch/x86/include/asm/sys_ia32.h:asmlinkage long sys32_rt_sigaction(int, struct sigaction32 __user *,

Watch (compiled with -m32):

rt_sigaction01    0  TINFO  :  signal: 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  signal: 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  signal: 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  signal: 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  signal: 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  signal: 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  signal: 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  signal: 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  signal: 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  signal: 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  signal: 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  signal: 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  signal: 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  signal: 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  signal: 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  signal: 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  signal: 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  signal: 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  signal: 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  signal: 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  signal: 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  signal: 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  signal: 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  signal: 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  signal: 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  signal: 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  signal: 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  signal: 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  signal: 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  signal: 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  signal: 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64

So from what I can tell, the sucker isn't properly translating something in 64-bit space, and instead of properly trapping the issue, it's segfaulting and dying -_-.

Ultimately the problem from what I can see is that bi-arch (32-bit on 64-bit kernel) 64-bit rt_sig* support is broken. I don't know about straight, non-bi-arch 64-bit rt_sig* support...

If someone could verify this with a little more kernel experience, or someone could direct me on how the issue could be trapped in gdb so I could inspect the registers and ensure the traps are or aren't being done properly, that would be helpful.

Quoted 4 lines

Although I had figured this, I think your solution is just a compromise, isn't it?
Change 64-bit rt_sigaction to 32-bit rt_sigaction to pass the testcase. Let's try to use 64bit rt_sigaction to pass it. ^_^

Luibo,
It isn't really a compromise -- it's an observation of what I
consider broken functionality in the 32-bit <-> 64-bit translation layers in the kernel ;)... 32-bit and 64-bit rt_sigaction should function equivalently, but they don't today.
Thanks,
-Garrett

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#15 lore raw
Quoted 743 lines · Garrett Cooper
Quoted 735 lines · liubo

Hi, Garrett

On 11/27/2009 04:50 PM, Garrett Cooper wrote:

On Thu, Nov 26, 2009 at 10:49 PM, Garrett Cooper <[email protected]> wrote:

On Thu, Nov 26, 2009 at 9:33 PM, liubo <[email protected]> wrote:

Hi, Garrett
On 11/26/2009 07:11 PM, Garrett Cooper wrote:

On Mon, Nov 16, 2009 at 12:53 AM, liubo <[email protected]> wrote:

Hi, Subrata,
On 11/16/2009 04:13 PM, Subrata Modak wrote:

Liubo,

Are you sending an updated patch post this discussion ?

Yes, I'll resend a updated patch about these rt_sigs.

Regards--
Liubo

Regards--
Subrata

On Wed, 2009-11-11 at 13:03 +0800, Wei Yongjun wrote:

Mike Frysinger wrote:

On Tuesday 10 November 2009 04:38:30 liubo wrote:

1) rt_sigaction
"sigaction" has the structure:

 struct sigaction {
         __sighandler_t sa_handler;
         unsigned long sa_flags;
  #ifdef SA_RESTORER
          __sigrestore_t sa_restorer;

#endif
sigset_t sa_mask; /* mask last for extensibility */
};

However, on arch x86_64, if we directly get to call rt_sigaction,
the argument "sa_restorer" will not be fulfilled, and this will lead
to segment fault.
on arch x86_64, if sa_restorer is not set, kernel will lead to segment
fault. In other arch, if sa_restorer is not set, kernel can do the correct work. To avoid this segment fault, we use glibc function
"int sigaction(...);" instead, which can fulfill the argument
"sa_restorer".

which defeats the purpose of the test. there is no guarantee that the C library sigaction function is implemented via the __NR_rt_sigaction syscall.

In x86_64, it do this. And If we want to use __NR_rt_sigaction syscall directly, we must fill the sa_restorer and set the RESTORER flag to sa_mask. If we do not set the sa_restorer, kill will always cause segment fault.

2) rt_sigprocmask
This failure contains two aspects,
the first is the segment fault as described in 1),
the second is that testcase uses a unknown signal 33 for test, and this will lead sigaction cannot bind signal 33 to the action.

So, we attempt to use a known signal instead, such as 34.

which is just as bogus and unportable. if the test needs a real time signal,
it should leverage the sigrtmin...sigrtmax defines.
-mike

I see what you mean about this testcase segfaulting now.

I've done some exploring, and while sigaction does map to rt_sigaction on ia64 and x86_64, it won't on arm, mips, s390*, sh, or x86.

Furthermore, the problem is actually being caused by the fact that we're not even calling sigaddset properly!

gcooper@orangebox /scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction $ gdb ./rt_sigaction01
GNU gdb 6.8
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu"...
(gdb) c
The program is not being run.
(gdb) r
Starting program:
/scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction/rt_sigaction01 thread:20
[Thread debugging using libthread_db enabled]

rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    1  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    2  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    3  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    4  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    5  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    6  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    7  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    8  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01    9  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   10  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   11  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   12  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   13  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   14  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   15  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   16  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   17  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   18  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   19  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   20  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   21  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   22  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   23  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   24  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   25  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   26  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   27  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   28  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   29  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed
rt_sigaction01   30  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument

So, the test needs fixing, anyhow. After I fixed it, the test still segfaulted >:( --

gcooper@orangebox /scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction $ gdb ./rt_sigaction01
GNU gdb 6.8
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu"...
(gdb) r
Starting program:
/scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction/rt_sigaction01 thread:20
[Thread debugging using libthread_db enabled]

rt_sigaction01    0  TINFO  :  signal: 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO

[New Thread 0x7fdd451d66f0 (LWP 31927)]

Program received signal SIG34, Real-time event 34. [Switching to Thread 0x7fdd451d66f0 (LWP 31927)] 0x00007fdd448944f7 in kill () from /lib/libc.so.6 (gdb) c
Continuing.

Program received signal SIGSEGV, Segmentation fault. 0x00007fdd448944f7 in kill () from /lib/libc.so.6

So I tried to do some digging. glibc 2.8-20080602 does the following for alpha, i386, and sysv:

result = INLINE_SYSCALL (rt_sigaction, 4,
sig, act ? __ptrvalue (&kact) : NULL, oact ? __ptrvalue (&koact) : NULL, _NSIG /
8);

The kernel code for rt_sigaction in kernel/signal.c is as follows:

#ifdef __ARCH_WANT_SYS_RT_SIGACTION SYSCALL_DEFINE4(rt_sigaction, int, sig,
const struct sigaction __user *, act, struct sigaction __user *, oact, size_t, sigsetsize)

{
        struct k_sigaction new_sa, old_sa;
        int ret = -EINVAL;

        /* XXX: Don't preclude handling different sized sigset_t's.  */
        if (sigsetsize != sizeof(sigset_t))
                goto out;

        if (act) {
                if (copy_from_user(&new_sa.sa, act, sizeof(new_sa.sa)))
                        return -EFAULT;
        }

        ret = do_sigaction(sig, act ? &new_sa : NULL, oact ? &old_sa :

NULL);

        if (!ret && oact) {
                if (copy_to_user(oact, &old_sa.sa, sizeof(old_sa.sa)))
                        return -EFAULT;
        }
out:
        return ret;
}

This just blows my mind because rt_sigaction is just calling do_sigaction, which is the same code as sigaction AFAICT, apart from the fact that rt_sigaction completely disregards sa_restorer on some architectures because it's obsolete, and requires the end-user to specify a signal mask set (here's mips' version, which wasn't the same as i386's version -- i386 had the old sa_restorer code):

SYSCALL_DEFINE3(sigaction, int, sig, const struct sigaction __user *, act,
struct sigaction __user *, oact)

{
        struct k_sigaction new_ka, old_ka;
        int ret;
        int err = 0;

        if (act) {
                old_sigset_t mask;

                if (!access_ok(VERIFY_READ, act, sizeof(*act)))
                        return -EFAULT;
                err |= __get_user(new_ka.sa.sa_handler, &act->sa_handler);
                err |= __get_user(new_ka.sa.sa_flags, &act->sa_flags);
                err |= __get_user(mask, &act->sa_mask.sig[0]);
                if (err)
                        return -EFAULT;

                siginitset(&new_ka.sa.sa_mask, mask);
        }

        ret = do_sigaction(sig, act ? &new_ka : NULL, oact ? &old_ka :

NULL);

        if (!ret && oact) {
                if (!access_ok(VERIFY_WRITE, oact, sizeof(*oact)))
                        return -EFAULT;
                err |= __put_user(old_ka.sa.sa_flags, &oact->sa_flags);
                err |= __put_user(old_ka.sa.sa_handler, &oact->sa_handler);
                err |= __put_user(old_ka.sa.sa_mask.sig[0],
oact->sa_mask.sig);
                err |= __put_user(0, &oact->sa_mask.sig[1]);
                err |= __put_user(0, &oact->sa_mask.sig[2]);
                err |= __put_user(0, &oact->sa_mask.sig[3]);
                if (err)
                        return -EFAULT;
        }

        return ret;
}

I dunno -- maybe someone else can read the kernel code better than me, but it looks like there's zero real value to the rt_sigaction testcases, because it can be covered by sigaction...

We just tell guys who use these testcases on arch x86_64 that "Syscall rt_sigaction cannot be called directly on arch x86_64.", can we?

It's not just x86_64 -- it's also ia64, and this may change
depending on the version of glibc and linux sources, so... this really isn't a viable solution IMO.
Does anyone have any better suggestions, apart from just using a
preprocessor macro that would execute rt_sig* via their non-rt equivalents in ltp_signal.h?

AHA! I think I discovered the kernel bug. rt_sigaction on x86_64 assumes that you're working in 32-bit space:

gcooper@orangebox /usr/src/linux $ grep -r rt_sigaction /usr/src/linux/arch/x86* /usr/src/linux/arch/x86/ia32/sys_ia32.c:asmlinkage long sys32_rt_sigaction(int sig, struct sigaction32 __user *act, Binary file /usr/src/linux/arch/x86/ia32/sys_ia32.o matches Binary file /usr/src/linux/arch/x86/ia32/built-in.o matches
/usr/src/linux/arch/x86/ia32/ia32entry.S: .quad sys32_rt_sigaction
Binary file /usr/src/linux/arch/x86/ia32/ia32entry.o matches Binary file /usr/src/linux/arch/x86/kernel/syscall_64.o matches Binary file /usr/src/linux/arch/x86/kernel/built-in.o matches
/usr/src/linux/arch/x86/kernel/syscall_table_32.S: .long
sys_rt_sigaction /usr/src/linux/arch/x86/include/asm/unistd_32.h:#define
__NR_rt_sigaction 174
/usr/src/linux/arch/x86/include/asm/unistd_64.h:#define
__NR_rt_sigaction 13
/usr/src/linux/arch/x86/include/asm/unistd_64.h:__SYSCALL(__NR_rt_sigaction, sys_rt_sigaction) /usr/src/linux/arch/x86/include/asm/sys_ia32.h:asmlinkage long sys32_rt_sigaction(int, struct sigaction32 __user *,

Watch (compiled with -m32):

rt_sigaction01    0  TINFO  :  signal: 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34
rt_sigaction01    0  TINFO  :  signal: 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35
rt_sigaction01    0  TINFO  :  signal: 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36
rt_sigaction01    0  TINFO  :  signal: 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37
rt_sigaction01    0  TINFO  :  signal: 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38
rt_sigaction01    0  TINFO  :  signal: 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39
rt_sigaction01    0  TINFO  :  signal: 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40
rt_sigaction01    0  TINFO  :  signal: 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41
rt_sigaction01    0  TINFO  :  signal: 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42
rt_sigaction01    0  TINFO  :  signal: 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43
rt_sigaction01    0  TINFO  :  signal: 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44
rt_sigaction01    0  TINFO  :  signal: 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45
rt_sigaction01    0  TINFO  :  signal: 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46
rt_sigaction01    0  TINFO  :  signal: 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47
rt_sigaction01    0  TINFO  :  signal: 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48
rt_sigaction01    0  TINFO  :  signal: 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49
rt_sigaction01    0  TINFO  :  signal: 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50
rt_sigaction01    0  TINFO  :  signal: 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51
rt_sigaction01    0  TINFO  :  signal: 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52
rt_sigaction01    0  TINFO  :  signal: 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53
rt_sigaction01    0  TINFO  :  signal: 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54
rt_sigaction01    0  TINFO  :  signal: 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55
rt_sigaction01    0  TINFO  :  signal: 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56
rt_sigaction01    0  TINFO  :  signal: 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57
rt_sigaction01    0  TINFO  :  signal: 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58
rt_sigaction01    0  TINFO  :  signal: 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59
rt_sigaction01    0  TINFO  :  signal: 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60
rt_sigaction01    0  TINFO  :  signal: 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61
rt_sigaction01    0  TINFO  :  signal: 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62
rt_sigaction01    0  TINFO  :  signal: 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63
rt_sigaction01    0  TINFO  :  signal: 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK
rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64

So from what I can tell, the sucker isn't properly translating something in 64-bit space, and instead of properly trapping the issue, it's segfaulting and dying -_-.

Ultimately the problem from what I can see is that bi-arch (32-bit on 64-bit kernel) 64-bit rt_sig* support is broken. I don't know about straight, non-bi-arch 64-bit rt_sig* support...

If someone could verify this with a little more kernel experience, or someone could direct me on how the issue could be trapped in gdb so I could inspect the registers and ensure the traps are or aren't being done properly, that would be helpful.

Quoted 5 lines

Although I had figured this, I think your solution is just a compromise, isn't it?
Change 64-bit rt_sigaction to 32-bit rt_sigaction to pass the testcase. Let's try to use 64bit rt_sigaction to pass it. ^_^

Quoted 9 lines

Luibo,
It isn't really a compromise -- it's an observation of what I
consider broken functionality in the 32-bit <-> 64-bit translation layers in the kernel ;)... 32-bit and 64-bit rt_sigaction should function equivalently, but they don't today.
Thanks,
-Garrett

There is other issue in x86_64. see the following kernel source code from file arch/x86/kernel/signal.c:

412 #else /* !CONFIG_X86_32 */
413 static int __setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info,
414 sigset_t *set, struct pt_regs *regs)

 415 {
     ......
 430 
 431         put_user_try {
 432                 /* Create the ucontext.  */
 433                 if (cpu_has_xsave)
 434                         put_user_ex(UC_FP_XSTATE, &frame->uc.uc_flags);
 435                 else
 436                         put_user_ex(0, &frame->uc.uc_flags);
 437                 put_user_ex(0, &frame->uc.uc_link);
 438                 put_user_ex(me->sas_ss_sp, &frame->uc.uc_stack.ss_sp);
 439                 put_user_ex(sas_ss_flags(regs->sp),
 440                             &frame->uc.uc_stack.ss_flags);
 441                 put_user_ex(me->sas_ss_size, &frame->uc.uc_stack.ss_size);
 442                 err |= setup_sigcontext(&frame->uc.uc_mcontext, fp, regs, set->sig[0]);
 443                 err |= __copy_to_user(&frame->uc.uc_sigmask, set, sizeof(*set));
 444 
 445                 /* Set up to return from userspace.  If provided, use a stub
 446                    already in userspace.  */
 447                 /* x86-64 should always use SA_RESTORER. */
 448                 if (ka->sa.sa_flags & SA_RESTORER) {
 449                         put_user_ex(ka->sa.sa_restorer, &frame->pretcode);
 450                 } else {
 451                         /* could use a vstub here */
 452                         err |= -EFAULT;
 453                 }
 454         } put_user_catch(err);
 455 
             ......

476 return 0;
477 }
478 #endif /* CONFIG_X86_32 */

Line 448~453 said that x86-64 should always use SA_RESTORER flag ans set the sa_restorer, otherwise kernel will return EFAULT.

In test rt_sigaction01.c, it used rt_sigaction syscall directly without the SA_RESTORER flag and null sa_restorer handler, so the test cases for x86_64 will aways fail. In Liu's fix, he used sigaction() instead of rt_sigaction syscall. sigaction() will fill the SA_RESTORER flag and sa_restorer handler, so he can pass the test case in x86_64.

Fill the SA_RESTORER flag and sa_restorer handler is the point I think.

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#16 lore raw
Quoted 799 lines · Wei Yongjun
Quoted 743 lines · Garrett Cooper
Quoted 735 lines · liubo

Hi, Garrett

On 11/27/2009 04:50 PM, Garrett Cooper wrote:

On Thu, Nov 26, 2009 at 10:49 PM, Garrett Cooper <[email protected]> wrote:

On Thu, Nov 26, 2009 at 9:33 PM, liubo <[email protected]> wrote:

Hi, Garrett
On 11/26/2009 07:11 PM, Garrett Cooper wrote:

On Mon, Nov 16, 2009 at 12:53 AM, liubo <[email protected]> wrote:

Hi, Subrata,
On 11/16/2009 04:13 PM, Subrata Modak wrote:

Liubo,

Are you sending an updated patch post this discussion ?

Yes, I'll resend a updated patch about these rt_sigs.

Regards--
Liubo

Regards--
Subrata

On Wed, 2009-11-11 at 13:03 +0800, Wei Yongjun wrote:

Mike Frysinger wrote:

On Tuesday 10 November 2009 04:38:30 liubo wrote:

1) rt_sigaction
    "sigaction" has the structure:

 struct sigaction {
         __sighandler_t sa_handler;
         unsigned long sa_flags;
  #ifdef SA_RESTORER
          __sigrestore_t sa_restorer;
  #endif
          sigset_t sa_mask;               /* mask last for extensibility */ };

    However, on arch x86_64, if we directly get to call rt_sigaction, the argument "sa_restorer" will not be fulfilled, and this will lead to segment fault.
    on arch x86_64, if sa_restorer is not set, kernel will lead to segment fault. In other arch, if sa_restorer is not set, kernel can do the correct work. To avoid this segment fault, we use glibc function
"int sigaction(...);" instead, which can fulfill the argument "sa_restorer".

which defeats the purpose of the test.  there is no guarantee that the C library sigaction function is implemented via the __NR_rt_sigaction syscall.

In x86_64, it do this. And If we want to use __NR_rt_sigaction syscall directly, we must fill the sa_restorer and set the RESTORER flag to sa_mask. If we do not set the sa_restorer, kill will always cause segment fault.

2) rt_sigprocmask
    This failure contains two aspects,
the first is the segment fault as described in 1),
the second is that testcase uses a unknown signal 33 for test, and this will lead sigaction cannot bind signal 33 to the action.

    So, we attempt to use a known signal instead, such as 34.

which is just as bogus and unportable.  if the test needs a real time signal,
it should leverage the sigrtmin...sigrtmax defines.
-mike

I see what you mean about this testcase segfaulting now.

I've done some exploring, and while sigaction does map to rt_sigaction on ia64 and x86_64, it won't on arm, mips, s390*, sh, or x86.

Furthermore, the problem is actually being caused by the fact that we're not even calling sigaddset properly!

gcooper@orangebox /scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction $ gdb ./rt_sigaction01
GNU gdb 6.8
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law.  Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu"...
(gdb) c
The program is not being run.
(gdb) r
Starting program:
/scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction/rt_sigaction01 thread:20
[Thread debugging using libthread_db enabled]
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    1  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    2  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    3  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    4  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    5  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    6  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    7  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    8  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01    9  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   10  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   11  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   12  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   13  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   14  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   15  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   16  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   17  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   18  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   19  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   20  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   21  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   22  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   23  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   24  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   25  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   26  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   27  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   28  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   29  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument
rt_sigaction01    0  TINFO  :  sigaddset(..) failed rt_sigaction01   30  TFAIL  :  rt_sigaction01 failed:
TEST_ERRNO=EINVAL(22): Invalid argument

So, the test needs fixing, anyhow. After I fixed it, the test still segfaulted >:( --

gcooper@orangebox /scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction $ gdb ./rt_sigaction01
GNU gdb 6.8
Copyright (C) 2008 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later
<http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law.  Type "show copying" and "show warranty" for details.
This GDB was configured as "x86_64-pc-linux-gnu"...
(gdb) r
Starting program:
/scratch/ltp-dev2/ltp/testcases/kernel/syscalls/rt_sigaction/rt_sigaction01 thread:20
[Thread debugging using libthread_db enabled]
rt_sigaction01    0  TINFO  :  signal: 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO [New Thread 0x7fdd451d66f0 (LWP 31927)]

Program received signal SIG34, Real-time event 34. [Switching to Thread 0x7fdd451d66f0 (LWP 31927)] 0x00007fdd448944f7 in kill () from /lib/libc.so.6 (gdb) c
Continuing.

Program received signal SIGSEGV, Segmentation fault. 0x00007fdd448944f7 in kill () from /lib/libc.so.6

So I tried to do some digging. glibc 2.8-20080602 does the following for alpha, i386, and sysv:

      result = INLINE_SYSCALL (rt_sigaction, 4,
                               sig, act ? __ptrvalue (&kact) : NULL, oact ? __ptrvalue (&koact) : NULL, _NSIG / 8);

The kernel code for rt_sigaction in kernel/signal.c is as follows:

#ifdef __ARCH_WANT_SYS_RT_SIGACTION SYSCALL_DEFINE4(rt_sigaction, int, sig,
                const struct sigaction __user *, act, struct sigaction __user *, oact, size_t, sigsetsize)
{
        struct k_sigaction new_sa, old_sa; int ret = -EINVAL;

        /* XXX: Don't preclude handling different sized sigset_t's.  */ if (sigsetsize != sizeof(sigset_t))
                goto out;

        if (act) {
                if (copy_from_user(&new_sa.sa, act, sizeof(new_sa.sa))) return -EFAULT;
        }

        ret = do_sigaction(sig, act ? &new_sa : NULL, oact ? &old_sa :
NULL);

        if (!ret && oact) {
                if (copy_to_user(oact, &old_sa.sa, sizeof(old_sa.sa))) return -EFAULT;
        }
out:
        return ret;
}

This just blows my mind because rt_sigaction is just calling do_sigaction, which is the same code as sigaction AFAICT, apart from the fact that rt_sigaction completely disregards sa_restorer on some architectures because it's obsolete, and requires the end-user to specify a signal mask set (here's mips' version, which wasn't the same as i386's version -- i386 had the old sa_restorer code):

SYSCALL_DEFINE3(sigaction, int, sig, const struct sigaction __user *, act, struct sigaction __user *, oact)
{
        struct k_sigaction new_ka, old_ka;
        int ret;
        int err = 0;

        if (act) {
                old_sigset_t mask;

                if (!access_ok(VERIFY_READ, act, sizeof(*act))) return -EFAULT;

                err |= __get_user(new_ka.sa.sa_handler, &act->sa_handler);
                err |= __get_user(new_ka.sa.sa_flags, &act->sa_flags);
                err |= __get_user(mask, &act->sa_mask.sig[0]);

                if (err)
                        return -EFAULT;

                siginitset(&new_ka.sa.sa_mask, mask); }

        ret = do_sigaction(sig, act ? &new_ka : NULL, oact ? &old_ka :
NULL);

        if (!ret && oact) {
                if (!access_ok(VERIFY_WRITE, oact, sizeof(*oact))) return -EFAULT;

                err |= __put_user(old_ka.sa.sa_flags, &oact->sa_flags);
                err |= __put_user(old_ka.sa.sa_handler, &oact->sa_handler);
                err |= __put_user(old_ka.sa.sa_mask.sig[0],
oact->sa_mask.sig);
                err |= __put_user(0, &oact->sa_mask.sig[1]);
                err |= __put_user(0, &oact->sa_mask.sig[2]);
                err |= __put_user(0, &oact->sa_mask.sig[3]);

                if (err)
                        return -EFAULT;
        }

        return ret;
}

I dunno -- maybe someone else can read the kernel code better than me, but it looks like there's zero real value to the rt_sigaction testcases, because it can be covered by sigaction...

    We just tell guys who use these testcases on arch x86_64 that "Syscall rt_sigaction cannot be called directly on arch x86_64.", can we?

   It's not just x86_64 -- it's also ia64, and this may change depending on the version of glibc and linux sources, so... this really isn't a viable solution IMO.
   Does anyone have any better suggestions, apart from just using a preprocessor macro that would execute rt_sig* via their non-rt equivalents in ltp_signal.h?

AHA! I think I discovered the kernel bug. rt_sigaction on x86_64 assumes that you're working in 32-bit space:

gcooper@orangebox /usr/src/linux $ grep -r rt_sigaction /usr/src/linux/arch/x86* /usr/src/linux/arch/x86/ia32/sys_ia32.c:asmlinkage long sys32_rt_sigaction(int sig, struct sigaction32 __user *act, Binary file /usr/src/linux/arch/x86/ia32/sys_ia32.o matches Binary file /usr/src/linux/arch/x86/ia32/built-in.o matches /usr/src/linux/arch/x86/ia32/ia32entry.S:       .quad sys32_rt_sigaction Binary file /usr/src/linux/arch/x86/ia32/ia32entry.o matches Binary file /usr/src/linux/arch/x86/kernel/syscall_64.o matches Binary file /usr/src/linux/arch/x86/kernel/built-in.o matches /usr/src/linux/arch/x86/kernel/syscall_table_32.S:      .long sys_rt_sigaction /usr/src/linux/arch/x86/include/asm/unistd_32.h:#define __NR_rt_sigaction       174 /usr/src/linux/arch/x86/include/asm/unistd_64.h:#define __NR_rt_sigaction                       13 /usr/src/linux/arch/x86/include/asm/unistd_64.h:__SYSCALL(__NR_rt_sigaction, sys_rt_sigaction) /usr/src/linux/arch/x86/include/asm/sys_ia32.h:asmlinkage long sys32_rt_sigaction(int, struct sigaction32 __user *,

Watch (compiled with -m32):

rt_sigaction01    0  TINFO  :  signal: 34
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 34 rt_sigaction01    0  TINFO  :  signal: 35
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 35 rt_sigaction01    0  TINFO  :  signal: 36
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 36 rt_sigaction01    0  TINFO  :  signal: 37
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 37 rt_sigaction01    0  TINFO  :  signal: 38
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 38 rt_sigaction01    0  TINFO  :  signal: 39
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 39 rt_sigaction01    0  TINFO  :  signal: 40
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 40 rt_sigaction01    0  TINFO  :  signal: 41
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 41 rt_sigaction01    0  TINFO  :  signal: 42
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 42 rt_sigaction01    0  TINFO  :  signal: 43
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 43 rt_sigaction01    0  TINFO  :  signal: 44
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 44 rt_sigaction01    0  TINFO  :  signal: 45
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 45 rt_sigaction01    0  TINFO  :  signal: 46
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 46 rt_sigaction01    0  TINFO  :  signal: 47
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 47 rt_sigaction01    0  TINFO  :  signal: 48
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 48 rt_sigaction01    0  TINFO  :  signal: 49
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 49 rt_sigaction01    0  TINFO  :  signal: 50
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 50 rt_sigaction01    0  TINFO  :  signal: 51
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 51 rt_sigaction01    0  TINFO  :  signal: 52
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 52 rt_sigaction01    0  TINFO  :  signal: 53
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 53 rt_sigaction01    0  TINFO  :  signal: 54
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 54 rt_sigaction01    0  TINFO  :  signal: 55
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 55 rt_sigaction01    0  TINFO  :  signal: 56
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 56 rt_sigaction01    0  TINFO  :  signal: 57
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 57 rt_sigaction01    0  TINFO  :  signal: 58
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 58 rt_sigaction01    0  TINFO  :  signal: 59
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 59 rt_sigaction01    0  TINFO  :  signal: 60
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 60 rt_sigaction01    0  TINFO  :  signal: 61
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 61 rt_sigaction01    0  TINFO  :  signal: 62
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 62 rt_sigaction01    0  TINFO  :  signal: 63
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 63 rt_sigaction01    0  TINFO  :  signal: 64
rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_RESETHAND|SA_SIGINFO rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64 rt_sigaction01    0  TINFO  :  sa.sa_flags = SA_NOMASK rt_sigaction01    0  TINFO  :  Signal Handler Called with signal number 64

So from what I can tell, the sucker isn't properly translating something in 64-bit space, and instead of properly trapping the issue, it's segfaulting and dying -_-.

Ultimately the problem from what I can see is that bi-arch (32-bit on 64-bit kernel) 64-bit rt_sig* support is broken. I don't know about straight, non-bi-arch 64-bit rt_sig* support...

If someone could verify this with a little more kernel experience, or someone could direct me on how the issue could be trapped in gdb so I could inspect the registers and ensure the traps are or aren't being done properly, that would be helpful.

Quoted 5 lines

Although I had figured this, I think your solution is just a compromise, isn't it?
Change 64-bit rt_sigaction to 32-bit rt_sigaction to pass the testcase. Let's try to use 64bit rt_sigaction to pass it. ^_^

Quoted 9 lines

Luibo,
    It isn't really a compromise -- it's an observation of what I consider broken functionality in the 32-bit <-> 64-bit translation layers in the kernel ;)... 32-bit and 64-bit rt_sigaction should function equivalently, but they don't today.
Thanks,
-Garrett

There is other issue in x86_64. see the following kernel source code from file arch/x86/kernel/signal.c:

 412 #else /* !CONFIG_X86_32 */
 413 static int __setup_rt_frame(int sig, struct k_sigaction *ka, siginfo_t *info, 414                             sigset_t *set, struct pt_regs *regs)
 415 {
    ......
 430
 431         put_user_try {
 432                 /* Create the ucontext.  */
 433                 if (cpu_has_xsave)
 434                         put_user_ex(UC_FP_XSTATE, &frame->uc.uc_flags); 435                 else
 436                         put_user_ex(0, &frame->uc.uc_flags);
 437                 put_user_ex(0, &frame->uc.uc_link);
 438                 put_user_ex(me->sas_ss_sp, &frame->uc.uc_stack.ss_sp); 439                 put_user_ex(sas_ss_flags(regs->sp),
 440                             &frame->uc.uc_stack.ss_flags);
 441                 put_user_ex(me->sas_ss_size, &frame->uc.uc_stack.ss_size); 442                 err |= setup_sigcontext(&frame->uc.uc_mcontext, fp, regs, set->sig[0]); 443                 err |= __copy_to_user(&frame->uc.uc_sigmask, set, sizeof(*set)); 444
 445                 /* Set up to return from userspace.  If provided, use a stub 446                    already in userspace.  */
 447                 /* x86-64 should always use SA_RESTORER. */
 448                 if (ka->sa.sa_flags & SA_RESTORER) {
 449                         put_user_ex(ka->sa.sa_restorer, &frame->pretcode); 450                 } else {
 451                         /* could use a vstub here */
 452                         err |= -EFAULT;
 453                 }
 454         } put_user_catch(err);
 455
            ......
 476         return 0;
 477 }
 478 #endif /* CONFIG_X86_32 */

Line 448~453 said that x86-64 should always use SA_RESTORER flag ans set the sa_restorer, otherwise kernel will return EFAULT.

Quoted 7 lines

In test rt_sigaction01.c, it used rt_sigaction syscall directly without the SA_RESTORER flag and null sa_restorer handler, so the test cases for x86_64 will aways fail. In Liu's fix, he used sigaction() instead of rt_sigaction syscall. sigaction() will fill the SA_RESTORER flag and sa_restorer handler, so he can pass the test case in x86_64.

Fill the SA_RESTORER flag and sa_restorer handler is the point I think.

Yes. I [mostly] fixed the rt_sigaction01 test a few hours ago. A summary of the issues with the old version:

1. The test as it was written before verified functionality by ensuring that coredumps and crashes didn't occur. The new version either catches the appropriate rt signal and increments, or catches SIGSEGV and continues. Eventually once all of the issues are worked out with SIGRTMIN, the known issue TINFO printout needs to be removed from include/ltp_signal.h
2. If the sa_flags field of a struct sigaction `object' specifies SA_SIGINFO, you should and must use sa_sigaction instead of sa_handler, as stated in the manpage, because sa_handler and sa_sigaction are a union structure on many architectures, or not present when rt_* not implemented.
3. An autoconf test was added to look for sa_sigaction in struct sigaction, as it isn't present on all architectures.

So, while this does fix rt_sigaction01, by and large, the following issues still exist with the rt_sig* syscalls:
1. SIGRTMIN always SIGSEGV's because signal_fault is being called in arch/x86/kernel/signal.c . I need to put some printk's in the code to understand why -EFAULT is being thrown, and thus why signal_fault is being tossed.
2. rt_sigprocmask01 and rt_sigsuspend01 still segfault for the same reason, as noted in 1.

Someone in the kernel.org team should generate some kind of
documentation to clarify several points (including architectural quirks) with the rt_sig* syscalls. This trial and error problem solving isn't very helpful and there are a fair number of gotchas involved with implementing a functional set of sigaction-like calls using rt_sig*.

Thanks,
-Garrett

------------------------------------------------------------------------------
Join us December 9, 2009 for the Red Hat Virtual Experience, a free event focused on virtualization and cloud computing. Attend in-depth sessions from your desk. Your couch. Anywhere.
http://p.sf.net/sfu/redhat-sfdev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

author
#17 lore raw

Hi,

Quoted 33 lines

Yes. I [mostly] fixed the rt_sigaction01 test a few hours ago. A summary of the issues with the old version:

1. The test as it was written before verified functionality by ensuring that coredumps and crashes didn't occur. The new version either catches the appropriate rt signal and increments, or catches SIGSEGV and continues. Eventually once all of the issues are worked out with SIGRTMIN, the known issue TINFO printout needs to be removed from include/ltp_signal.h
2. If the sa_flags field of a struct sigaction `object' specifies SA_SIGINFO, you should and must use sa_sigaction instead of sa_handler, as stated in the manpage, because sa_handler and sa_sigaction are a union structure on many architectures, or not present when rt_* not implemented.
3. An autoconf test was added to look for sa_sigaction in struct sigaction, as it isn't present on all architectures.

So, while this does fix rt_sigaction01, by and large, the following issues still exist with the rt_sig* syscalls:
1. SIGRTMIN always SIGSEGV's because signal_fault is being called in arch/x86/kernel/signal.c . I need to put some printk's in the code to understand why -EFAULT is being thrown, and thus why signal_fault is being tossed.
2. rt_sigprocmask01 and rt_sigsuspend01 still segfault for the same reason, as noted in 1.

Someone in the kernel.org team should generate some kind of
documentation to clarify several points (including architectural quirks) with the rt_sig* syscalls. This trial and error problem solving isn't very helpful and there are a fair number of gotchas involved with implementing a functional set of sigaction-like calls using rt_sig*.

Quoted 5 lines

Thanks,
-Garrett

I've made a patch to fix this rt_sig problem, but I encounted a trouble.

I figured out that syscall __NR_rt_sigaction doesn't use struct sigaction, and glibc defines a
struct called kernel_sigaction to fit __NR_rt_sigaction so that glibc function can pass it.
And the struct sigaction may change in the future.

My trouble is if we define a struct to fit this syscall just as what glibc does, after the struct
sigaction change, we'll define another struct as well.

Looking forward to any advice about this trouble...

Thanks,
Liubo

------------------------------------------------------------------------------
Return on Information:
Google Enterprise Search pays you back
Get the facts.
http://p.sf.net/sfu/google-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list