Skip to contentSkip to conversation

OMAP3: pandora: fix booting without serial attached

PATCH New Grazvydas Ignotas 2 participants 4 messages Nov 11, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 OMAP3: pandora: fix booting without serial attached

When the board is booted without serial cable attached (which is how most of them will be used) UART RX is left floating and sometimes picks noise, which interrupts countdown and enters U-Boot prompt instead of booting the kernel. Fix this by setting up internal pullup on UART RX pin.

---
 board/pandora/pandora.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
board/pandora/pandora.h +1 -1
index 5bfa0f9..f1e1db9 100644
@@ -219,7 +219,7 @@ const omap3_sysinfo sysinfo = {
 	MUX_VAL(CP(UART2_RX),		(IEN  | PTD | EN  | M4)) /*GPIO_147,*/\
 								 /*UART2_RX*/\
  /*Serial Interface (Peripheral boot, Linux console, on AV connector)*/\
-	MUX_VAL(CP(UART3_RX_IRRX),	(IEN  | PTD | DIS | M0)) /*UART3_RX*/\
+	MUX_VAL(CP(UART3_RX_IRRX),	(IEN  | PTU | EN  | M0)) /*UART3_RX*/\
 	MUX_VAL(CP(UART3_TX_IRTX),	(IDIS | PTD | DIS | M0)) /*UART3_TX*/\
  /*LEDs (Controlled by OMAP)*/\
 	MUX_VAL(CP(MMC1_DAT6),		(IDIS | PTD | DIS | M4)) /*GPIO_128*/\
Signature · 1 line
1.5.4.3
#1 lore raw

PATCH 1/1 OMAP3: pandora: fix booting without serial attached

Quoted 16 lines · Grazvydas Ignotas

When the board is booted without serial cable attached (which is how most of them will be used) UART RX is left floating and sometimes picks noise, which interrupts countdown and enters U-Boot prompt instead of booting the kernel. Fix this by setting up internal pullup on UART RX pin.

---
 board/pandora/pandora.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
board/pandora/pandora.h +0 -0
index 5bfa0f9..f1e1db9 100644

board/pandora/pandora.h const omap3_sysinfo sysinfo = { · line 225

Quoted 8 lines
board/pandora/pandora.h +1 -1
@@ -219,7 +219,7 @@ const omap3_sysinfo sysinfo = {
 	MUX_VAL(CP(UART2_RX),		(IEN  | PTD | EN  | M4)) /*GPIO_147,*/\
 								 /*UART2_RX*/\
  /*Serial Interface (Peripheral boot, Linux console, on AV connector)*/\
-	MUX_VAL(CP(UART3_RX_IRRX),	(IEN  | PTD | DIS | M0)) /*UART3_RX*/\
+	MUX_VAL(CP(UART3_RX_IRRX),	(IEN  | PTU | EN  | M0)) /*UART3_RX*/\
 	MUX_VAL(CP(UART3_TX_IRTX),	(IDIS | PTD | DIS | M0)) /*UART3_TX*/\
  /*LEDs (Controlled by OMAP)*/\
 	MUX_VAL(CP(MMC1_DAT6),		(IDIS | PTD | DIS | M4)) /*GPIO_128*/\

Will this change disable normal u-boot serial?
From the config file

/*
* select serial console configuration
*/
#define CONFIG_CONS_INDEX 3
#define CONFIG_SYS_NS16550_COM3 OMAP34XX_UART3
#define CONFIG_SERIAL3 3

It looks like it will.

This must be as a non default config option.

Tom

#2 lore raw

PATCH 1/1 OMAP3: pandora: fix booting without serial attached

Quoted 21 lines · Tom
Quoted 20 lines · Grazvydas Ignotas

When the board is booted without serial cable attached (which is how most of them will be used) UART RX is left floating and sometimes picks noise, which interrupts countdown and enters U-Boot prompt instead of booting the kernel. Fix this by setting up internal pullup on UART RX pin.

---
?board/pandora/pandora.h | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)

board/pandora/pandora.h +0 -0
index 5bfa0f9..f1e1db9 100644
@@ -219,7 +219,7 @@ const omap3_sysinfo sysinfo = {
 ? ? ? ?MUX_VAL(CP(UART2_RX), ? ? ? ? ? (IEN ?| PTD | EN ?| M4))
 /*GPIO_147,*/\
 
Quoted 13 lines
Quoted 11 lines
board/pandora/pandora.h +1 -1
 /*UART2_RX*/\
 ?/*Serial Interface (Peripheral boot, Linux console, on AV connector)*/\
- ? ? ? MUX_VAL(CP(UART3_RX_IRRX), ? ? ?(IEN ?| PTD | DIS | M0))
 /*UART3_RX*/\
+ ? ? ? MUX_VAL(CP(UART3_RX_IRRX), ? ? ?(IEN ?| PTU | EN ?| M0))

/*UART3_RX*/\
? ? ? ?MUX_VAL(CP(UART3_TX_IRTX), ? ? ?(IDIS | PTD | DIS | M0)) /*UART3_TX*/\
?/*LEDs (Controlled by OMAP)*/\
? ? ? ?MUX_VAL(CP(MMC1_DAT6), ? ? ? ? ?(IDIS | PTD | DIS | M4)) /*GPIO_128*/\

Will this change disable normal u-boot serial?

No it won't, it only enables weak internal pullup resistor in OMAP, which won't prevent the UART from working, only pull it up when nothing is driving the pin (i.e. cable not conneted).

Quoted 14 lines

From the config file

/*
?* select serial console configuration
?*/
#define CONFIG_CONS_INDEX ? ? ? ? ? ? ? 3 #define CONFIG_SYS_NS16550_COM3 ? ? ? ? OMAP34XX_UART3 #define CONFIG_SERIAL3 ? ? ? ? ? ? ? ? ?3

It looks like it will.

This must be as a non default config option.

Tom

#3 lore raw

PATCH 1/1 OMAP3: pandora: fix booting without serial attached

Quoted 34 lines · Grazvydas Ignotas
Quoted 20 lines · Tom
Quoted 19 lines · Grazvydas Ignotas

When the board is booted without serial cable attached (which is how most of them will be used) UART RX is left floating and sometimes picks noise, which interrupts countdown and enters U-Boot prompt instead of booting the kernel. Fix this by setting up internal pullup on UART RX pin.

---
 board/pandora/pandora.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
board/pandora/pandora.h +0 -0
index 5bfa0f9..f1e1db9 100644
@@ -219,7 +219,7 @@ const omap3_sysinfo sysinfo = {
       MUX_VAL(CP(UART2_RX),           (IEN  | PTD | EN  | M4))
 /*GPIO_147,*/\
 
Quoted 12 lines
Quoted 11 lines
board/pandora/pandora.h +1 -1
 /*UART2_RX*/\
 /*Serial Interface (Peripheral boot, Linux console, on AV connector)*/\
-       MUX_VAL(CP(UART3_RX_IRRX),      (IEN  | PTD | DIS | M0))
 /*UART3_RX*/\
+       MUX_VAL(CP(UART3_RX_IRRX),      (IEN  | PTU | EN  | M0))
/*UART3_RX*/\
       MUX_VAL(CP(UART3_TX_IRTX),      (IDIS | PTD | DIS | M0))
/*UART3_TX*/\
 /*LEDs (Controlled by OMAP)*/\
       MUX_VAL(CP(MMC1_DAT6),          (IDIS | PTD | DIS | M4))

/*GPIO_128*/\

Will this change disable normal u-boot serial?

Quoted 3 lines

No it won't, it only enables weak internal pullup resistor in OMAP, which won't prevent the UART from working, only pull it up when nothing is driving the pin (i.e. cable not conneted).

Good.
Please add this comment to the commit log.
Please also add a similar comment to the code.

The mux code is cyptic, documenting helps.
Tom

Quoted 15 lines
Quoted 15 lines

From the config file

/*
* select serial console configuration
*/

#define CONFIG_CONS_INDEX               3
#define CONFIG_SYS_NS16550_COM3         OMAP34XX_UART3
#define CONFIG_SERIAL3                  3

It looks like it will.

This must be as a non default config option.

Tom