Skip to contentSkip to conversation

Fix bug at nlmclnt_lock()

PATCH New Mi Jinlong 1 participant 1 message Nov 12, 2009

Subsystems (2)
lore
Share & tools
lore

Mi Jinlong

author
#0 lore raw

PATCH 1/1 Fix bug at nlmclnt_lock()

When testing NLM, i found a bug.

Test process:
step1: client open file.
step2: keep network partition.
step3: client call fcntl with SETLKW to get lock.
(it will timeout and return -1)
step4: recover network.
step5: client try to get lock again, but it always fail.

At nlmclnt_lock(), resp->status is set to "nlm_lck_blocked" by default before call nlmclnt_call().

So at step3, when nlmclnt_call return error because network partition, client will think the nlm_lck_blocked was replied from server, and it just send cancel request not unlock.

Signed-off-by [email protected]
---
 fs/lockd/clntproc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
fs/lockd/clntproc.c +1 -1
index c81249f..a631582 100644
@@ -535,7 +535,7 @@ again:
 	 * Initialise resp->status to a valid non-zero value,
 	 * since 0 == nlm_lck_granted
 	 */
-	resp->status = nlm_lck_blocked;
+	resp->status = nlm_lck_denied_nolocks;
 	for(;;) {
 		/* Reboot protection */
 		fl->fl_u.nfs_fl.state = host->h_state;
Signature · 4 lines
1.6.2

thanks,
Mi Jinlong