Skip to contentSkip to conversation

OMAP3: pandora: fix booting without serial attached

PATCH New Grazvydas Ignotas 3 participants 3 messages Nov 12, 2009 – Nov 17, 2009

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 OMAP3: pandora: fix booting without serial attached

When the board is booted without serial cable attached (which is how most of them will be used) UART RX is left floating and sometimes picks noise, which interrupts countdown and enters U-Boot prompt instead of booting the kernel.

Fix this by setting up internal pullup on UART RX pin. This does not prevent serial from working as the internal pullup is weak.

---
It would be nice for this to go in as a fix for 2009.11, else users without serial cable won't be able to boot it.

 board/pandora/pandora.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
board/pandora/pandora.h +2 -1
index 5bfa0f9..f0ad16b 100644
@@ -219,7 +219,8 @@ const omap3_sysinfo sysinfo = {
 	MUX_VAL(CP(UART2_RX),		(IEN  | PTD | EN  | M4)) /*GPIO_147,*/\
 								 /*UART2_RX*/\
  /*Serial Interface (Peripheral boot, Linux console, on AV connector)*/\
-	MUX_VAL(CP(UART3_RX_IRRX),	(IEN  | PTD | DIS | M0)) /*UART3_RX*/\
+ /*RX pulled up to avoid noise when nothing is connected to serial port*/\
+	MUX_VAL(CP(UART3_RX_IRRX),	(IEN  | PTU | EN  | M0)) /*UART3_RX*/\
 	MUX_VAL(CP(UART3_TX_IRTX),	(IDIS | PTD | DIS | M0)) /*UART3_TX*/\
  /*LEDs (Controlled by OMAP)*/\
 	MUX_VAL(CP(MMC1_DAT6),		(IDIS | PTD | DIS | M4)) /*GPIO_128*/\
Signature · 1 line
1.5.6.3
#1 lore raw

PATCH v2 1/1 OMAP3: pandora: fix booting without serial attached

Quoted 10 lines · Grazvydas Ignotas

When the board is booted without serial cable attached (which is how most of them will be used) UART RX is left floating and sometimes picks noise, which interrupts countdown and enters U-Boot prompt instead of booting the kernel.

Fix this by setting up internal pullup on UART RX pin. This does not prevent serial from working as the internal pullup is weak.

Ack.
Thanks.

Quoted 4 lines

---
It would be nice for this to go in as a fix for 2009.11, else users without serial cable won't be able to boot it.

Wolfgang,
Can this fix be included in 2009.11 ?

Tom

Quoted 17 lines
 board/pandora/pandora.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
board/pandora/pandora.h +2 -1
index 5bfa0f9..f0ad16b 100644
@@ -219,7 +219,8 @@ const omap3_sysinfo sysinfo = {
 	MUX_VAL(CP(UART2_RX),		(IEN  | PTD | EN  | M4)) /*GPIO_147,*/\
 								 /*UART2_RX*/\
  /*Serial Interface (Peripheral boot, Linux console, on AV connector)*/\
-	MUX_VAL(CP(UART3_RX_IRRX),	(IEN  | PTD | DIS | M0)) /*UART3_RX*/\
+ /*RX pulled up to avoid noise when nothing is connected to serial port*/\
+	MUX_VAL(CP(UART3_RX_IRRX),	(IEN  | PTU | EN  | M0)) /*UART3_RX*/\
 	MUX_VAL(CP(UART3_TX_IRTX),	(IDIS | PTD | DIS | M0)) /*UART3_TX*/\
  /*LEDs (Controlled by OMAP)*/\
 	MUX_VAL(CP(MMC1_DAT6),		(IDIS | PTD | DIS | M4)) /*GPIO_128*/\
#2 lore raw

PATCH v2 1/1 OMAP3: pandora: fix booting without serial attached

Dear Tom,

Quoted 6 lines · In message <[email protected]> you wrote:
Quoted 3 lines

It would be nice for this to go in as a fix for 2009.11, else users without serial cable won't be able to boot it.

Wolfgang,
Can this fix be included in 2009.11 ?

Sure - if you merge it and send a pull request, please.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Actual war is a very messy business. Very, very messy business.
	-- Kirk, "A Taste of Armageddon", stardate 3193.0