Skip to contentSkip to conversation

nodatacsum broken?

DISCUSSION Steven Pratt 2 participants 5 messages Nov 16, 2009 Btrfs file system

lore
Share & tools
lore
#0 lore raw

Did we break the ability to run with -o nodatacsum somewhere along the way? I had not run just this option in a while (usually doing nodatacow which implies nodatacsum). Just did a full run with just nodatacsum and it looks like we still did csums.

from proc/mounts:

/dev/ffsbdev1 on /mnt/ffsb1 type btrfs (rw,nodatacsum)

but profile:

samples % app name symbol name

1664460  15.3103  vmlinux-2.6.31-autokern1 copy_user_generic_unrolled
1514349  13.9295  vmlinux-2.6.31-autokern1 crc32c
606147    5.5756  vmlinux-2.6.31-autokern1 rb_get_reader_page
562936    5.1781  vmlinux-2.6.31-autokern1 mutex_spin_on_owner
433405    3.9866  vmlinux-2.6.31-autokern1 ring_buffer_consume

This was for a sequential read test on the unstable tree from 11-12.

Steve

#1 lore raw
Quoted 4 lines · Steven Pratt

Did we break the ability to run with -o nodatacsum somewhere along the way? I had not run just this option in a while (usually doing nodatacow which implies nodatacsum). Just did a full run with just nodatacsum and it looks like we still did csums.

Were the files created without nodatasum? The sum option actually ends up stored in the file itself, so if you're reading from an old dataset you'll still sum.

-chris

#2 lore raw
Quoted 8 lines · Chris Mason
Quoted 5 lines · Steven Pratt

Did we break the ability to run with -o nodatacsum somewhere along the way? I had not run just this option in a while (usually doing nodatacow which implies nodatacsum). Just did a full run with just nodatacsum and it looks like we still did csums.

Quoted 4 lines

Were the files created without nodatasum? The sum option actually ends up stored in the file itself, so if you're reading from an old dataset you'll still sum.

No, fresh mkfs and all mounts used nodatacsum.

Steve

Quoted 6 lines

-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
In reply to Steven Pratt
Quoted 8 lines · Steven Pratt

Did we break the ability to run with -o nodatacsum somewhere along the way? I had not run just this option in a while (usually doing nodatacow which implies nodatacsum). Just did a full run with just nodatacsum and it looks like we still did csums.

from proc/mounts:

/dev/ffsbdev1 on /mnt/ffsb1 type btrfs (rw,nodatacsum)

                                         ^^^^^^^^^^^^^^

This should be mount -o nodatasum.

2.6.33 will have a patch from Sage to fail mounting when we don't recognize the option instead of silently pretending it worked. I just didn't want to introduce it this late in the 2.6.32-rc series.

-chris

#4 lore raw
Quoted 7 lines · Chris Mason
Quoted 5 lines · Steven Pratt

Did we break the ability to run with -o nodatacsum somewhere along the way? I had not run just this option in a while (usually doing nodatacow which implies nodatacsum). Just did a full run with just nodatacsum and it looks like we still did csums.

Quoted 9 lines
Quoted 4 lines

from proc/mounts:

/dev/ffsbdev1 on /mnt/ffsb1 type btrfs (rw,nodatacsum)

                                         ^^^^^^^^^^^^^^

This should be mount -o nodatasum.

Oops. My bad. Re-running.

Quoted 4 lines

2.6.33 will have a patch from Sage to fail mounting when we don't recognize the option instead of silently pretending it worked. I just didn't want to introduce it this late in the 2.6.32-rc series.

Good.

Steve

Quoted 6 lines

-chris
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html