net-next-2.6 compilation errors: missing wireless/i82593.h

For the past 9-10 days, net-next-2.6 has failed to compile. In addition to the errors and warnings already reported here last week, since Nov 12th there has been another missing file. I kept hoping it was temporary, but no joy.

/home/administer/net-next-2.6/drivers/net/znet.c:107:29: error: wireless/i82593.h: No such file or directory /home/administer/net-next-2.6/drivers/net/znet.c:133: error: field ‘i593_init’ has incomplete type /home/administer/net-next-2.6/drivers/net/znet.c: In function ‘znet_set_multicast_list’:
/home/administer/net-next-2.6/drivers/net/znet.c:235: error: invalid application of ‘sizeof’ to incomplete type ‘struct i82593_conf_block’ /home/administer/net-next-2.6/drivers/net/znet.c:235: error: invalid application of ‘sizeof’ to incomplete type ‘struct i82593_conf_block’ /home/administer/net-next-2.6/drivers/net/znet.c:235: error: invalid application of ‘sizeof’ to incomplete type ‘struct i82593_conf_block’ /home/administer/net-next-2.6/drivers/net/znet.c:235: error: invalid application of ‘sizeof’ to incomplete type ‘struct i82593_conf_block’ /home/administer/net-next-2.6/drivers/net/znet.c:235: error: invalid application of ‘sizeof’ to incomplete type ‘struct i82593_conf_block’ /home/administer/net-next-2.6/drivers/net/znet.c:235: error: invalid application of ‘sizeof’ to incomplete type ‘struct i82593_conf_block’ /home/administer/net-next-2.6/drivers/net/znet.c:247: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:248: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:249: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:250: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:251: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:254: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:255: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:256: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:259: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:260: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:261: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:262: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:265: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:266: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:267: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:268: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:271: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:274: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:277: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:278: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:281: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:282: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:283: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:284: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:285: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:286: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:289: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:290: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:291: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:294: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:297: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:298: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:299: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:300: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:301: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:302: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:303: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:304: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:307: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:310: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:311: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:312: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:315: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:316: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:317: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:318: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:319: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:320: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:323: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:324: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:325: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:326: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:327: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:328: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:329: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:330: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:333: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:334: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:340: error: dereferencing pointer to incomplete type /home/administer/net-next-2.6/drivers/net/znet.c:345: error: invalid application of ‘sizeof’ to incomplete type ‘struct i82593_conf_block’ /home/administer/net-next-2.6/drivers/net/znet.c:346: error: invalid application of ‘sizeof’ to incomplete type ‘struct i82593_conf_block’ /home/administer/net-next-2.6/drivers/net/znet.c:346: error: invalid application of ‘sizeof’ to incomplete type ‘struct i82593_conf_block’ /home/administer/net-next-2.6/drivers/net/znet.c:346: error: invalid application of ‘sizeof’ to incomplete type ‘struct i82593_conf_block’ /home/administer/net-next-2.6/drivers/net/znet.c:347: error: invalid application of ‘sizeof’ to incomplete type ‘struct i82593_conf_block’ /home/administer/net-next-2.6/drivers/net/znet.c:348: error: ‘OP0_CONFIGURE’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:348: error: (Each undeclared identifier is reported only once /home/administer/net-next-2.6/drivers/net/znet.c:348: error: for each function it appears in.) /home/administer/net-next-2.6/drivers/net/znet.c:348: error: ‘CR0_CHNL’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c: In function ‘znet_tx_timeout’:
/home/administer/net-next-2.6/drivers/net/znet.c:512: error: ‘CR0_STATUS_0’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:514: error: ‘CR0_STATUS_1’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:516: error: ‘CR0_STATUS_2’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:518: error: ‘CR0_STATUS_3’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:522: error: ‘TX_LOST_CRS’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:525: error: ‘OP0_RESET’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c: In function ‘znet_send_packet’:
/home/administer/net-next-2.6/drivers/net/znet.c:549: error: ‘CR0_STATUS_0’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:583: error: ‘OP0_TRANSMIT’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:583: error: ‘CR0_CHNL’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c: In function ‘znet_interrupt’:
/home/administer/net-next-2.6/drivers/net/znet.c:612: error: ‘CR0_STATUS_0’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:617: error: ‘CR0_STATUS_1’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:619: error: ‘CR0_STATUS_2’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:621: error: ‘CR0_STATUS_3’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:626: error: ‘SR0_INTERRUPT’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:631: error: ‘SR0_EVENT_MASK’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:631: error: ‘SR0_TRANSMIT_DONE’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:632: error: ‘SR0_RETRANSMIT_DONE’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:633: error: ‘SR0_TRANSMIT_NO_CRC_DONE’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:638: error: ‘TX_OK’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:640: error: ‘TX_NCOL_MASK’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:642: error: ‘TX_LOST_CTS’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:642: error: ‘TX_LOST_CRS’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:644: error: ‘TX_UND_RUN’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:646: error: ‘TX_HRT_BEAT’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:648: error: ‘TX_MAX_COL’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:666: error: ‘SR0_RECEPTION’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:667: error: ‘SR0_STOP_REG_HIT’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:671: error: ‘CR0_INT_ACK’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c: In function ‘znet_rx’:
/home/administer/net-next-2.6/drivers/net/znet.c:688: error: ‘CR0_STATUS_2’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:747: error: ‘RX_RCV_OK’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:749: error: ‘RX_CRC_ERR’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:750: error: ‘RX_ALG_ERR’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:756: error: ‘RX_OVRRUN’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:758: error: ‘RX_SRT_FRM’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c: In function ‘znet_close’:
/home/administer/net-next-2.6/drivers/net/znet.c:814: error: ‘OP0_RESET’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c: In function ‘hardware_init’:
/home/administer/net-next-2.6/drivers/net/znet.c:859: error: ‘OP0_RESET’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:885: error: ‘OP0_CONFIGURE’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:885: error: ‘CR0_CHNL’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:893: error: ‘OP0_IA_SETUP’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:898: error: ‘OP0_RCV_ENABLE’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c: In function ‘update_stop_hit’:
/home/administer/net-next-2.6/drivers/net/znet.c:904: error: ‘OP0_SWIT_TO_PORT_1’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:904: error: ‘CR0_CHNL’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:907: error: ‘CR1_STOP_REG_UPDATE’ undeclared (first use in this function) /home/administer/net-next-2.6/drivers/net/znet.c:909: error: ‘OP1_SWIT_TO_PORT_0’ undeclared (first use in this function) make[3]: *** [drivers/net/znet.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [drivers/net] Error 2
make[1]: *** [drivers] Error 2
make: *** [sub-make] Error 2

From: William Allen Simpson <[email protected]>
Date: Tue, 17 Nov 2009 06:34:15 -0500

Those seemed to be for Android drivers and such, so I hope you reported those failures to the driver maintainers as well as linux-kernel.

For the time being could you just disable those drivers in your build just to get work done or do you absolutely need them?

That header file got moved out to drivers/staging along with the wavelan driver.

The header file should instead be moved to, perhaps, include/linux while there are still other users of it.

That's incredibly clumsy what drivers/net/znet.c is doing.

John please fix this up, thanks!

I did, at least some of them. Nothing seems to have been fixed yet.

I did, at least some of them. Of course, since I'm making changes to linux/tcp.h and net/tcp.h, an awful lot of drivers seem to include them one way or another, and I'm trying to ensure nothing breaks (at least for compilation purposes).

Too bad that CONFIG_STAGING "N" (# CONFIG_STAGING is not set) doesn't actually turn off all the staging....

Please.

It does - that isn't the problem. Someone moves shared header files out of the right directory into staging without double checking (lxr is rather handy..)

Alan

znet was including "wireless/i82593.h" (which is a bit wierd), and I missed that when I relocated i82593.h to drivers/staging/wavelan. Since I don't have ISA turned-on in my normal .config, I didn't see the build failures -- mea culpa!

---
I'll just include this with the wireless-next-2.6 pull request I intend to send later today...

 drivers/net/znet.c                     |    3 +-
 drivers/staging/wavelan/i82593.h       |  229 --------------------------------
 drivers/staging/wavelan/wavelan_cs.p.h |    2 +-
 include/linux/i82593.h                 |  229 ++++++++++++++++++++++++++++++++
 4 files changed, 231 insertions(+), 232 deletions(-)
 delete mode 100644 drivers/staging/wavelan/i82593.h
 create mode 100644 include/linux/i82593.h

index b423473..443c4ee 100644
@@ -103,8 +103,7 @@
 #include <asm/io.h>
 #include <asm/dma.h>
 
-/* This include could be elsewhere, since it is not wireless specific */
-#include "wireless/i82593.h"
+#include <linux/i82593.h>
 
 static char version[] __initdata = "znet.c:v1.02 9/23/94 [email protected]\n";
 

index 81d9153..8fbfaa8 100644
@@ -446,7 +446,7 @@
 #include <pcmcia/ds.h>
 
 /* Wavelan declarations */
-#include "i82593.h"	/* Definitions for the Intel chip */
+#include <linux/i82593.h>	/* Definitions for the Intel chip */
 
 #include "wavelan_cs.h"	/* Others bits of the hardware */
 

1.6.2.5

From: "John W. Linville" <[email protected]>
Date: Tue, 17 Nov 2009 10:20:49 -0500

Sounds good.