Skip to contentSkip to conversation

netsched: Allow var_sk_bound_if meta to work on all namespaces

PATCH In review Eric Dumazet 2 participants 2 messages Nov 18, 2009 – Nov 19, 2009

Subsystems (3)
Networking Network drivers Traffic control (tc)
lore
Share & tools
lore

Eric Dumazet

author
#0 lore raw

PATCH 1/1 netsched: Allow var_sk_bound_if meta to work on all namespaces

This fix can probably wait 2.6.33, or should use another patch if needed in 2.6.32 (no get_dev_by_index_rcu() before 2.6.33)

Signed-off-by Eric Dumazet <[email protected]>

---

net/sched/em_meta.c +2 -1
index 8e8d836..24dce8b 100644
@@ -310,7 +310,8 @@ META_COLLECTOR(var_sk_bound_if)
 		struct net_device *dev;
 
 		rcu_read_lock();
-		dev = dev_get_by_index_rcu(&init_net, skb->sk->sk_bound_dev_if);
+		dev = dev_get_by_index_rcu(sock_net(skb->sk),
+					   skb->sk->sk_bound_dev_if);
 		*err = var_dev(dev, dst);
 		rcu_read_unlock();
 	}
maintainer
#1 lore raw

From: Eric Dumazet <[email protected]>
Date: Thu, 19 Nov 2009 00:58:57 +0100

Quoted 4 lines

This fix can probably wait 2.6.33, or should use another patch if needed in 2.6.32 (no get_dev_by_index_rcu() before 2.6.33)

Signed-off-by Eric Dumazet <[email protected]>

I'll add this to net-next-2.6, thanks Eric.