Skip to contentSkip to conversation

ieee802154: dont leak skbs in ieee802154_fake_xmit()

PATCH Applied Eric Dumazet 3 participants 3 messages Nov 19, 2009

Subsystems (2)
Networking Network drivers
lore
Share & tools
lore

Eric Dumazet

author
#0 lore raw

PATCH 1/1 ieee802154: dont leak skbs in ieee802154_fake_xmit()

ieee802154_fake_xmit() should free skbs since it returns NETDEV_TX_OK

Signed-off-by Eric Dumazet <[email protected]>

---

drivers/ieee802154/fakehard.c +1 -4
index 96a2959..7c544f7 100644
@@ -260,15 +260,12 @@ static int ieee802154_fake_close(struct net_device *dev)
 static netdev_tx_t ieee802154_fake_xmit(struct sk_buff *skb,
 					      struct net_device *dev)
 {
-	skb->iif = dev->ifindex;
-	skb->dev = dev;
 	dev->stats.tx_packets++;
 	dev->stats.tx_bytes += skb->len;
 
-	dev->trans_start = jiffies;
-
 	/* FIXME: do hardware work here ... */
 
+	dev_kfree_skb(skb);
 	return NETDEV_TX_OK;
 }