Skip to contentSkip to conversation

ILLUME_CONFIG is now also set by a variable]

PATCH In review Sebastian Spaeth 4 participants 5 messages Nov 20, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ILLUME_CONFIG is now also set by a variable]

See attached patch. We'd love to replace the default illume config with our distro-specific version, so this will make the config RDEPENDS overridable from our distro conf. Is such a change acceptable for OE?

spaetz

---
 recipes/tasks/task-x11-illume.bb |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
recipes/tasks/task-x11-illume.bb +2 -1
index 8b813b4..9af914f 100644
@@ -10,6 +10,7 @@ inherit task
 
 # Default illume theme
 ILLUME_THEME ?= "e-wm-theme-illume"
+ILLUME_CONFIG ?= "e-wm-config-illume"
 
 RDEPENDS_${PN} = "\
   task-x11-server \
@@ -17,6 +18,6 @@ RDEPENDS_${PN} = "\
 #  xserver-kdrive-splash-illume \
   \
   e-wm \
-  e-wm-config-illume \
+  ${ILLUME_CONFIG} \
   ${ILLUME_THEME} \
 "
Signature · 6 lines
1.6.5.3

_______________________________________________
Shr-devel mailing list
[email protected]
http://lists.shr-project.org/mailman/listinfo/shr-devel
#1 lore raw
Quoted 3 lines · Sebastian Spaeth

See attached patch. We'd love to replace the default illume config with our distro-specific version, so this will make the config RDEPENDS overridable from our distro conf. Is such a change acceptable for OE?

Yes, that looks fine. If ${ILLUME_THEME} is already overridable then I can't see any reason why you shouldn't do the same with the config package.

p.

#2 lore raw
In reply to Sebastian Spaeth
Quoted 3 lines · Sebastian Spaeth

See attached patch. We'd love to replace the default illume config with our distro-specific version, so this will make the config RDEPENDS overridable from our distro conf. Is such a change acceptable for OE?

The change looks file, but the Author field is wrong (people have last names, unless you're called Wookie) and the commit message isn't to OE standards either. In the future fix up both before committing. It can get tedious, I know, I do it for my coworkers as well :)

regards,

Koen

#3 lore raw
Quoted 8 lines · Koen Kooi
Quoted 3 lines · Sebastian Spaeth

See attached patch. We'd love to replace the default illume config with our distro-specific version, so this will make the config RDEPENDS overridable from our distro conf. Is such a change acceptable for OE?

The change looks file, but the Author field is wrong (people have last names, unless you're called Wookie) and the commit message isn't to OE standards either.

Is Wookie his first name or last name?

Philip

Quoted 13 lines

In the future fix up both before committing. It can get tedious, I know, I do it for my coworkers as well :)

regards,

Koen

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

#4 lore raw
In reply to Koen Kooi
Quoted 5 lines · Koen Kooi

The change looks file, but the Author field is wrong (people have last names, unless you're called Wookie) and the commit message isn't to OE standards either.
In the future fix up both before committing. It can get tedious, I know, I do it for my coworkers as well :)

Apologies for those glitches. I applied the patches without checking the author field and making sure that the commit comment is ok (I partially blame "git am" here, it makes things too easy :)). Will do in the future.

spaetz