Skip to contentSkip to conversation

BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.

PATCH Superseded Robert P. J. Day 2 participants 3 messages Nov 20, 2009

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.

Make it clear to the reader that, since OMAP 34XX and 35XX are the same silicon, the BeagleBoard can use the OMAP34XX macros.

---

include/configs/omap3_beagle.h +3 -0
index 19a5ec9..59b7edc 100644
@@ -30,6 +30,9 @@
 
 /*
  * High Level Configuration Options
+ *
+ * Note that since OMAP 34XX and 35XX are the same silicon, the
+ * OMAP 3530-based BeagleBoard can use the OMAP34XX macros.
  */
 #define CONFIG_ARMCORTEXA8	1	/* This is an ARM V7 CPU core */
 #define CONFIG_OMAP		1	/* in a TI OMAP core */

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================

#1 lore raw

PATCH v2 1/1 BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.

Quoted 12 lines · Robert P. J. Day

Make it clear to the reader that, since OMAP 34XX and 35XX are the same silicon, the BeagleBoard can use the OMAP34XX macros.

---

include/configs/omap3_beagle.h +0 -0
index 19a5ec9..59b7edc 100644

include/configs/omap3_beagle.h line 35

Quoted 6 lines
include/configs/omap3_beagle.h +3 -0
@@ -30,6 +30,9 @@
 
 /*
  * High Level Configuration Options
+ *
+ * Note that since OMAP 34XX and 35XX are the same silicon, the
+ * OMAP 3530-based BeagleBoard can use the OMAP34XX macros.

I think this comment would be appropriate in the omap3 readme.

<beyond_scope_of_change>
Perhaps the omap3 specific defines could be explained in greater detail there.
</beyond_scope_of_change>

Tom

Quoted 17 lines
include/configs/omap3_beagle.h +0 -0
  */
 #define CONFIG_ARMCORTEXA8	1	/* This is an ARM V7 CPU core */
 #define CONFIG_OMAP		1	/* in a TI OMAP core */

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#2 lore raw

PATCH v2 1/1 BeagleBoard: Add a comment explaining the use of "OMAP34XX" macros.

Quoted 22 lines · Tom
Quoted 12 lines · Robert P. J. Day

Make it clear to the reader that, since OMAP 34XX and 35XX are the same silicon, the BeagleBoard can use the OMAP34XX macros.

---

include/configs/omap3_beagle.h +0 -0
index 19a5ec9..59b7edc 100644

include/configs/omap3_beagle.h line 35

Quoted 6 lines
include/configs/omap3_beagle.h +3 -0
@@ -30,6 +30,9 @@
 
 /*
  * High Level Configuration Options
+ *
+ * Note that since OMAP 34XX and 35XX are the same silicon, the
+ * OMAP 3530-based BeagleBoard can use the OMAP34XX macros.

I think this comment would be appropriate in the omap3 readme.

Quoted 4 lines

<beyond_scope_of_change>
Perhaps the omap3 specific defines could be explained in greater detail there.
</beyond_scope_of_change>

certainly, there's nothing amiss about a longer explanation in the
README file. but the rationale for the above was just a couple lines to prevent any confusion on the part of anyone who wanted to peruse the beagle config file, nothing more. it wasn't meant to be a big deal.

rday
--

========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA

Linux Consulting, Training and Kernel Pedantry.

Web page:                                          http://crashcourse.ca
Twitter:                                       http://twitter.com/rpjday

========================================================================