V4L/DVB: Fix test in copy_reg_bits()
PATCH 1/1 V4L/DVB: Fix test in copy_reg_bits()
The reg_pair2[j].reg was tested twice.
Signed-off-by Roel Kluin <[email protected]>
--- drivers/media/common/tuners/mxl5007t.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
I think this was intended?
drivers/media/common/tuners/mxl5007t.c +1 -1
@@ -196,7 +196,7 @@ static void copy_reg_bits(struct reg_pair_t *reg_pair1, i = j =0 ;while (reg_pair1[i].reg || reg_pair1[i].val) { -while (reg_pair2[j].reg || reg_pair2[j].reg) { +while (reg_pair2[j].reg || reg_pair2[j].val) {if (reg_pair1[i].reg != reg_pair2[j].reg) { j++;continue ;
Ah! Nice catch. Thank you, Roel. Mauro / Andrew, can one of you please merge this? The driver hasn't changed, so it should go to Linus' current tree and also stable, although it isn't crucial.
Signed-off-by Michael Krufky <[email protected]>
Quoted 26 lines · Roel Kluin
The reg_pair2[j].reg was tested twice.
Signed-off-by Roel Kluin <[email protected]>--- drivers/media/common/tuners/mxl5007t.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)I think this was intended?
drivers/media/common/tuners/mxl5007t.c +1
-2@@ -196,7 +196,7 @@ static void copy_reg_bits(struct reg_pair_t *reg_pair1, i = j =0 ;while (reg_pair1[i].reg || reg_pair1[i].val) { -while (reg_pair2[j].reg || reg_pair2[j].reg) { +while (reg_pair2[j].reg || reg_pair2[j].val) {if (reg_pair1[i].reg != reg_pair2[j].reg) { j++;continue ; --To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html