Skip to contentSkip to conversation

netfilter: xt_limit: fix invalid return code in limit_mt_check()

PATCH Patrick McHardy 2 participants 2 messages Nov 23, 2009

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

This patch fixes an invalid return value in the limit match. Please apply or pull from:

git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-2.6.git master

Thanks!

commit 8fa539bd911e8a7faa7cd77b5192229c9666d9b8

Author: Patrick McHardy <[email protected]>
Date:   Mon Nov 23 13:37:23 2009 +0100

netfilter: xt_limit: fix invalid return code in limit_mt_check()

Commit acc738fe (netfilter: xtables: avoid pointer to self) introduced an invalid return value in limit_mt_check().

net/netfilter/xt_limit.c +1 -1
index 2e8089e..2773be6 100644
@@ -112,7 +112,7 @@ static bool limit_mt_check(const struct xt_mtchk_param *par)
 
 	priv = kmalloc(sizeof(*priv), GFP_KERNEL);
 	if (priv == NULL)
-		return -ENOMEM;
+		return false;
 
 	/* For SMP, we only want to use one set of state. */
 	r->master = priv;
maintainer
#1 lore raw

From: Patrick McHardy <[email protected]>
Date: Mon, 23 Nov 2009 13:43:57 +0100

Quoted 4 lines

This patch fixes an invalid return value in the limit match. Please apply or pull from:

git://git.kernel.org/pub/scm/linux/kernel/git/kaber/nf-2.6.git master

Pulled, thanks Patrick.