powerpc: Add support for creating FIT uImages
Review
Quoted 5 lines · Peter Tyser <ptyser wrote:
(quoted diff) +5
-0+uboot.fit) + rm -f "$ofile" + ${MKITS} -A ppc -C gzip -a $membase -e $membase -v $version \ + -d "$srctree/$dtb" -k "$srctree/$vmz" -o "$object/uImage.its" + ${MKIMAGE} -f "$object/uImage.its" "$ofile"
Hi,
I have tested your patches against last mkimage utility provided with u-boot. The utility requires to pass the type of the image (flat_dt), even if this is not mentioned in the help output. Without the image type parameter, no image is generated, and no error is reported. It should be:
${MKIMAGE} -f "$object/uImage.its" - T flat_dt "$ofile"I have tried to get an image for the lite5200b board, because I have the possibility to test the result on the target. However, dtc fails to compile the its generated by your script (Version: DTC 1.2.0-g0ef21055, cloned from jdt).
DTC: dts->dtb on file "arch/powerpc/boot/uImage.its"
Error: arch/powerpc/boot/uImage.its 1:0 syntax error
Do you test in different conditions ?
Regards,
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: [email protected] =====================================================================
Hi Stefano,
Thanks for trying the patches out.
Quoted 9 lines · Stefano Babic
Review
Quoted 5 lines · Peter Tyser <ptyser wrote:
(quoted diff) +5
-0+uboot.fit) + rm -f "$ofile" + ${MKITS} -A ppc -C gzip -a $membase -e $membase -v $version \ + -d "$srctree/$dtb" -k "$srctree/$vmz" -o "$object/uImage.its" + ${MKIMAGE} -f "$object/uImage.its" "$ofile"Hi,
Quoted 7 lines
I have tested your patches against last mkimage utility provided with u-boot. The utility requires to pass the type of the image (
flat_dt), even if this is not mentioned in the help output. Without the image type parameter, no image is generated, and no error is reported. It should be:${MKIMAGE} -f "$object/uImage.its" - T flat_dt "$ofile"
Argh, I'm seeing the same behavior with the latest mkimage source too. It looks like there was a regression in the mkimage utility - the "-T" option shouldn't be necessary to create a FIT image. I'll send a patch to U-Boot to fix this behavior.
Quoted 4 lines
I have tried to get an image for the lite5200b board, because I have the possibility to test the result on the target. However, dtc fails to compile the its generated by your script (Version: DTC 1.2.0-g0ef21055, cloned from jdt).
I did my testing using the dtc in the linux kernel source (scripts/dtc/dtc, version 1.2.0) and version 1.2.0-rc1. I see the same error as you when using version 1.2.0-g0ef21055.
Quoted 4 lines
DTC:
dts->dtbon file "arch/powerpc/boot/uImage.its"
Error:arch/powerpc/boot/uImage.its1:0 syntax errorDo you test in different conditions ?
Applying the following change should resolve the dtc syntax error.
scripts/mkits.sh +3 -1
@@ -64,7 +64,9 @@ ENTRY_ADDR=`echo $ENTRY_ADDR | sed 's/0x//'` RAMFS_ADDR=`echo $RAMFS_ADDR | sed 's/0x//'` # Create a default, fully populated DTS file -DATA="/ { +DATA="/dts-v1/; + +/ { description = \"Linux kernel ${VERSION}\"; #address-cells = <1>;
I'll wait a few more days for feedback then resubmit with the dts syntax fix
Thanks for testing,
Peter