xfstests 213: Add enospc case to fallocate test
PATCH 1/1 xfstests 213: Add enospc case to fallocate test
Add a test for ENOSPC when fallocating.
Also, add an expected output, not sure how that went missing!
---
iff --git a/213 b/213
index 3cd55f7..7d66338 100755
213 +8 -2
@@ -61,8 +61,6 @@ _require_xfs_io_falloc avail=`df -P $TEST_DIR | awk 'END {print $4}'` [ "$avail" -ge 1049600 ] || _notrun "Test device is too small ($avail KiB)" -echo Silence is golden - # reserve 1GiB, truncate at 100bytes $XFS_IO_PROG -F -f -c 'falloc 0 1g' -c 'truncate 100' $TEST_DIR/ouch rm -f $TEST_DIR/ouch
@@ -79,6 +77,14 @@ rm -f $TEST_DIR/ouch $XFS_IO_PROG -F -f -c 'falloc 0 1g' -c 'falloc 2g 1m' -c 'truncate 3g' $TEST_DIR/ouch rm -f $TEST_DIR/ouch +# Try to reserve more space than we have +echo "We should get: fallocate: No space left on device" +echo "Strangely, xfs_io sometimes says \"Success\" when something went wrong, FYI" + +let toobig=$avail*2 +$XFS_IO_PROG -F -f -c "falloc 0 ${toobig}k" $TEST_DIR/ouch +rm -f $TEST_DIR/ouch + # success, all done status=0 exit
213.out new file +4 -0
@@ -0,0 +1,4 @@ +QA output created by 213 +We should get: fallocate: No space left on device +Strangely, xfs_io sometimes says "Success" when something went wrong, FYI +fallocate: No space left on device
group +1 -1
@@ -322,7 +322,7 @@ prealloc 210 auto aio quick 211 auto aio quick 212 auto aio quick -213 rw auto prealloc quick +213 rw auto prealloc quick enospc 214 rw auto prealloc quick 215 auto metadata quick 216 log metadata auto quick
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 3 lines · Eric Sandeen
Add a test for ENOSPC when fallocating.
Also, add an expected output, not sure how that went missing!
Oops. Easily to do because xfstests doesn't complain but rather just skips tests without golden output..
I guess the ENOSPC test is to catch the inverted error returns just detected?
Anyway, looks good,
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 10 lines · Christoph Hellwig
Quoted 3 lines · Eric Sandeen
Add a test for ENOSPC when fallocating.
Also, add an expected output, not sure how that went missing!
Oops. Easily to do because xfstests doesn't complain but rather just skips tests without golden output..
I guess the ENOSPC test is to catch the inverted error returns just detected?
yep
Quoted 1 line
Anyway, looks good,
thanks!
-eric
Quoted 2 lines
Reviewed-by Christoph Hellwig <[email protected]>
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs