Davinci: Table driven pinmux configuration
PATCH 1/1 Davinci: Table driven pinmux configuration
Davinci: Table driven pinmux configuration
Add code to allow pinmux_config tables to be grouped and configured as a single resource. This removes multiple calls to the pinmux configuration code from board_init and allows pinmuxes to be individually configured and added by data manipulation only.
All related #ifdefs can the be removed from board_init code and since the compiler optimises away statics, #ifdefs can be reduced in the data definitions as well.
---
Applies to u-boot-ti:
board/davinci/common/misc.c | 31 +++++++++++++++++++++++++++++++ board/davinci/common/misc.h | 13 +++++++++++++ 2 files changed, 44 insertions(+), 0 deletions(-)
board/davinci/common/misc.c +31 -0
@@ -155,3 +155,34 @@ int davinci_configure_pin_mux(const struct pinmux_config *pins,return 0 ; } + +/* +* Configure multiple pinmux resources. +* +* Takes an pinmux_resource array of pinmux_config and pin counts: +* +* const struct pinmux_resource pinmuxes[] = { +* PINMUX_ITEM(uart_pins), +* PINMUX_ITEM(i2c_pins), +* }; +* +* The number of items in the array must be passed (ARRAY_SIZE can provide +* this value conveniently). +* +* Each item entry is configured in the defined order. If configuration +* of any item fails, -1 is returned and none of the following items are +* configured. On success, 0 is returned. +*/ +int davinci_configure_pin_mux_items (const struct pinmux_resource *item, +const int n_items) +{ +int i; + +for (i =0 ; i < n_items; i++) { +if (davinci_configure_pin_mux (item[i].pins, + item[i].n_pins) !=0 ) +return -1 ; + } + +return 0 ; +}
board/davinci/common/misc.h +13 -0
@@ -34,8 +34,21 @@ struct pinmux_config { unsigned char field; /* field number */ }; +/* pin table definition */ +struct pinmux_resource { +const struct pinmux_config *pins; +const int n_pins; +}; + +#define PINMUX_ITEM (item) { \ + .pins = item, \ + .n_pins = ARRAY_SIZE(item) \ + } +int dvevm_read_mac_address (uint8_t *buf);void dv_configure_mac_address (uint8_t *rom_enetaddr);int davinci_configure_pin_mux (const struct pinmux_config *pins,int n_pins); +int davinci_configure_pin_mux_items (const struct pinmux_resource *item, +int n_items);#endif /* __MISC_H */
PATCH 1/1 Davinci: Table driven pinmux configuration
Quoted 11 lines · Nick Thompson
Davinci: Table driven pinmux configuration
Add code to allow
pinmux_configtables to be grouped and configured as a single resource. This removes multiple calls to the pinmux configuration code fromboard_initand allows pinmuxes to be individually configured and added by data manipulation only.All related #ifdefs can the be removed from
board_initcode and since the compiler optimises away statics, #ifdefs can be reduced in the data definitions as well.
Quoted 7 lines
Signed-off-by Nick Thompson <[email protected]>---
Applies to u-boot-ti:board/davinci/common/misc.c | 31 +++++++++++++++++++++++++++++++ board/davinci/common/misc.h | 13 +++++++++++++ 2 files changed, 44 insertions(+), 0 deletions(-)
I have seen no comments on this one. Is it okay?
It's Davinci specific, so I assume this is for Sandeep's attention. Sorry to push, but it's central to several further patches.
Thanks,
Nick.