Skip to contentSkip to conversation

myri10ge: use src+dst for rss hashing

PATCH Applied Brice Goglin 2 participants 2 messages Dec 4, 2009 – Dec 9, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 myri10ge: use src+dst for rss hashing

Use a more effective rss hash by default (src + dst, rather than just src).

drivers/net/myri10ge/myri10ge.c +2 -2
@@ -75,7 +75,7 @@
 #include "myri10ge_mcp.h"
 #include "myri10ge_mcp_gen_header.h"
 
-#define MYRI10GE_VERSION_STR "1.5.1-1.451"
+#define MYRI10GE_VERSION_STR "1.5.1-1.453"
 
 MODULE_DESCRIPTION("Myricom 10G driver (10GbE)");
 MODULE_AUTHOR("Maintainer: [email protected]");
@@ -347,7 +347,7 @@
 module_param(myri10ge_max_slices, int, S_IRUGO);
 MODULE_PARM_DESC(myri10ge_max_slices, "Max tx/rx queues");
 
-static int myri10ge_rss_hash = MXGEFW_RSS_HASH_TYPE_SRC_PORT;
+static int myri10ge_rss_hash = MXGEFW_RSS_HASH_TYPE_SRC_DST_PORT;
 module_param(myri10ge_rss_hash, int, S_IRUGO);
 MODULE_PARM_DESC(myri10ge_rss_hash, "Type of RSS hashing to do");
 
maintainer Applied
#1 lore raw

From: Brice Goglin <[email protected]>
Date: Fri, 04 Dec 2009 21:00:15 +0100

Quoted 3 lines

Use a more effective rss hash by default (src + dst, rather than just src).

Applied, but please get rid of this module parameter.

We have ethtool operations to configure this stuff, make use of it instead of adding driver specific hacks.

Thank you.