Skip to contentSkip to conversation

Stop stack clobbering in microblaze-generic.

PATCH New Graeme Smecher 3 participants 5 messages Dec 7, 2009 – Dec 8, 2009

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Stop stack clobbering in microblaze-generic.

From: Graeme Smecher <[email protected]>

A typo caused the stack and malloc regions to overlap, which prevented mem_malloc_init() from returning. This commit makes the memory layout match the example described in include/configs/microblaze-generic.h

---
 include/configs/microblaze-generic.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/configs/microblaze-generic.h +1 -1
index b486c77..9b1569a 100644
@@ -146,7 +146,7 @@
 #define	CONFIG_SYS_MALLOC_BASE		(CONFIG_SYS_MONITOR_BASE - CONFIG_SYS_MALLOC_LEN)
 
 /* stack */
-#define	CONFIG_SYS_INIT_SP_OFFSET	CONFIG_SYS_MONITOR_BASE
+#define	CONFIG_SYS_INIT_SP_OFFSET	CONFIG_SYS_MALLOC_BASE
 
 /*#define	RAMENV */
 #define	FLASH
Signature · 1 line
1.6.5
#1 lore raw

PATCH 1/1 Stop stack clobbering in microblaze-generic.

Dear Michal,

Quoted 8 lines · In message <[email protected]>…

From: Graeme Smecher <[email protected]>

A typo caused the stack and malloc regions to overlap, which prevented mem_malloc_init() from returning. This commit makes the memory layout match the example described in include/configs/microblaze-generic.h

---
 include/configs/microblaze-generic.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Please send a pull request if you want this to go into v2009.11

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The universe does not have laws - it has habits, and  habits  can  be
broken.
#2 lore raw

PATCH 1/1 Stop stack clobbering in microblaze-generic.

In reply to Graeme Smecher

Hi Graeme,

Quoted 5 lines · Graeme Smecher

From: Graeme Smecher <[email protected]>

A typo caused the stack and malloc regions to overlap, which prevented mem_malloc_init() from returning. This commit makes the memory layout match the example described in include/configs/microblaze-generic.h

I added your Sign-off-by line and all microblaze patches should have "microblaze:" prefix in subject. I fixed these things and your patch is in microblaze repo.

Thanks,
Michal

Quoted 17 lines
---
 include/configs/microblaze-generic.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
include/configs/microblaze-generic.h +1 -1
index b486c77..9b1569a 100644
@@ -146,7 +146,7 @@
 #define	CONFIG_SYS_MALLOC_BASE		(CONFIG_SYS_MONITOR_BASE - CONFIG_SYS_MALLOC_LEN)
 
 /* stack */
-#define	CONFIG_SYS_INIT_SP_OFFSET	CONFIG_SYS_MONITOR_BASE
+#define	CONFIG_SYS_INIT_SP_OFFSET	CONFIG_SYS_MALLOC_BASE
 
 /*#define	RAMENV */
 #define	FLASH
Signature · 4 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian
#3 lore raw

PATCH 1/1 Stop stack clobbering in microblaze-generic.

Hi Michal,

Quoted 6 lines · Michal Simek

Hi Graeme,

Quoted 2 lines · Graeme Smecher

From: Graeme Smecher <[email protected]>

Quoted 9 lines
Quoted 4 lines

A typo caused the stack and malloc regions to overlap, which prevented mem_malloc_init() from returning. This commit makes the memory layout match the example described in include/configs/microblaze-generic.h

I added your Sign-off-by line and all microblaze patches should have "microblaze:" prefix in subject. I fixed these things and your patch is in microblaze repo.

Thanks. However, I notice (and you've probably noticed too) that the "From" address in the patch is bogus. Please let me know if you'd like me to resubmit with a valid e-mail. Sorry for the extra hassle.

best,
Graeme

#4 lore raw

PATCH 1/1 Stop stack clobbering in microblaze-generic.

Quoted 15 lines · Graeme Smecher

Hi Michal,

Quoted 12 lines · Michal Simek

Hi Graeme,

Quoted 7 lines · Graeme Smecher

From: Graeme Smecher <[email protected]>

A typo caused the stack and malloc regions to overlap, which prevented mem_malloc_init() from returning. This commit makes the memory layout match
the example described in include/configs/microblaze-generic.h

Quoted 8 lines
Quoted 4 lines

I added your Sign-off-by line and all microblaze patches should have "microblaze:" prefix in subject. I fixed these things and your patch is in microblaze repo.

Thanks. However, I notice (and you've probably noticed too) that the "From" address in the patch is bogus. Please let me know if you'd like me to resubmit with a valid e-mail. Sorry for the extra hassle.

You can check it alone.
http://git.denx.de/?p=u-boot/u-boot-microblaze.git;a=summary

No worries about,
Michal

Quoted 4 lines

best,
Graeme

Signature · 4 lines
Michal Simek, Ing. (M.Eng)
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel 2.6 Microblaze Linux - http://www.monstr.eu/fdt/
Microblaze U-BOOT custodian