trace_kprobe: shows signs of fields in format files
PATCH 1/10 trace_kprobe: shows signs of fields in format files
format files of trace_kprobe don't shows signs, it is different from all other format files, incorrect API to user.
Signed-off-by Lai Jiangshan <[email protected]>
---
kernel/trace/trace_kprobe.c +4 -3
@@ -1163,10 +1163,11 @@ static int __probe_event_show_format(struct trace_seq *s,#undef SHOW_FIELD#define SHOW_FIELD (type, item, name) \ do { \ - ret = trace_seq_printf(s, "\tfield: " #type " %s;\t" \ - "offset:%u;\tsize:%u;\n", name, \ + ret = trace_seq_printf(s, "\tfield:" #type " %s;\t" \ + "offset:%u;\tsize:%u;\tsigned:%d;\n", name,\ (unsigned int)offsetof(typeof(field), item),\ - (unsigned int)sizeof(type)); \ + (unsigned int)sizeof(type), \ + is_signed_type(type)); \ if (!ret) \ return 0; \ } while (0)
Quoted 5 lines · Lai Jiangshan
format files of
trace_kprobedon't shows signs, it is different from all other format files, incorrect API to user.Signed-off-by Lai Jiangshan<[email protected]>
Thanks Lai!
Acked-by Masami Hiramatsu <[email protected]>
Quoted 23 lines
---
kernel/trace/trace_kprobe.c +4
-3@@ -1163,10 +1163,11 @@ static int __probe_event_show_format(struct trace_seq *s,#undef SHOW_FIELD#define SHOW_FIELD (type, item, name) \ do { \ - ret = trace_seq_printf(s, "\tfield: " #type " %s;\t" \ - "offset:%u;\tsize:%u;\n", name, \ + ret = trace_seq_printf(s, "\tfield:" #type " %s;\t" \ + "offset:%u;\tsize:%u;\tsigned:%d;\n", name,\ (unsigned int)offsetof(typeof(field), item),\ - (unsigned int)sizeof(type)); \ + (unsigned int)sizeof(type), \ + is_signed_type(type)); \ if (!ret) \ return 0; \ } while (0)
Signature · 7 lines
Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: [email protected]