Skip to contentSkip to conversation

sh: Fix test of unsigned in se7722_irq_demux()

PATCH Applied Roel Kluin 2 participants 2 messages Dec 15, 2009 – Dec 16, 2009 SuperH

lore
Share & tools
lore

Roel Kluin

author
#0 lore raw

PATCH 1/1 sh: Fix test of unsigned in se7722_irq_demux()

se7722_fpga_irq[] is unsigned so the test does not work.

Signed-off-by Roel Kluin <[email protected]>

---
Found using coccinelle: http://coccinelle.lip6.fr/

arch/sh/boards/mach-se/7722/irq.c +4 -3
index 4eb31ac..b221b68 100644
@@ -57,15 +57,16 @@ static void se7722_irq_demux(unsigned int irq, struct irq_desc *desc)
  */
 void __init init_se7722_IRQ(void)
 {
-	int i;
+	int i, irq;
 
 	ctrl_outw(0, IRQ01_MASK);       /* disable all irqs */
 	ctrl_outw(0x2000, 0xb03fffec);  /* mrshpc irq enable */
 
 	for (i = 0; i < SE7722_FPGA_IRQ_NR; i++) {
-		se7722_fpga_irq[i] = create_irq();
-		if (se7722_fpga_irq[i] < 0)
+		irq = create_irq();
+		if (irq < 0)
 			return;
+		se7722_fpga_irq[i] = irq;
 
 		set_irq_chip_and_handler_name(se7722_fpga_irq[i],
 					      &se7722_irq_chip,