lgdt3305: make one-bit bitfields unsigned
PATCH 1/1 lgdt3305: make one-bit bitfields unsigned
From: Márton Németh <[email protected]>
Make one-bit bitfields unsigned which will remove the following sparse warning messages (see "make C=1"):
* lgdt3305.h:57:21: error: dubious one-bit signed bitfield
* lgdt3305.h:60:26: error: dubious one-bit signed bitfield
* lgdt3305.h:63:19: error: dubious one-bit signed bitfield
---
linux/drivers/media/dvb/frontends/lgdt3305.h +3 -3
@@ -54,13 +54,13 @@u16 usref_qam256;/* default: 0x2a80 */ /* disable i2c repeater - 0:repeater enabled 1:repeater disabled */ - int deny_i2c_rptr:1; + unsigned int deny_i2c_rptr:1;/* spectral inversion - 0:disabled 1:enabled */ - int spectral_inversion:1; + unsigned int spectral_inversion:1;/* use RF AGC loop - 0:disabled 1:enabled */ - int rf_agc_loop:1; + unsigned int rf_agc_loop:1;enum lgdt3305_mpeg_mode mpeg_mode;enum lgdt3305_tp_clock_edge tpclk_edge;
Thanks -- I'll push this in through the lgdt3305 repository... I'll send in a pull request to Mauro shortly.
-Mike
Quoted 31 lines · Németh Márton
From: Márton Németh <[email protected]>
Make one-bit bitfields unsigned which will remove the following sparse warning messages (see "make C=1"):
* lgdt3305.h:57:21: error: dubious one-bit signed bitfield
* lgdt3305.h:60:26: error: dubious one-bit signed bitfield
* lgdt3305.h:63:19: error: dubious one-bit signed bitfieldSigned-off-by Márton Németh <[email protected]>---
diff -rba8d6bf077aalinux/drivers/media/dvb/frontends/lgdt3305.hlinux/drivers/media/dvb/frontends/lgdt3305.h +3
-3@@ -54,13 +54,13 @@u16 usref_qam256;/* default: 0x2a80 */ /* disable i2c repeater - 0:repeater enabled 1:repeater disabled */ - int deny_i2c_rptr:1; + unsigned int deny_i2c_rptr:1;/* spectral inversion - 0:disabled 1:enabled */ - int spectral_inversion:1; + unsigned int spectral_inversion:1;/* use RF AGC loop - 0:disabled 1:enabled */ - int rf_agc_loop:1; + unsigned int rf_agc_loop:1;enum lgdt3305_mpeg_mode mpeg_mode;enum lgdt3305_tp_clock_edge tpclk_edge;