Skip to contentSkip to conversation

ade: fix the bug of objdump01

PATCH In review liubo 2 participants 2 messages Dec 16, 2009 – Dec 17, 2009

lore
Share & tools
lore

liubo

author
#0 lore raw

PATCH 1/3 ade: fix the bug of objdump01

- LTP needs to test "objdump", but ade's Makefile exclude it.
- objdump01 case uses *.obj instead, so s/*.o/*.obj/

This patch fixed these.

---
 testcases/commands/ade/Makefile          |    2 +-
 testcases/commands/ade/objdump/Makefile  |    4 ++--
 testcases/commands/ade/objdump/objdump01 |    2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)
testcases/commands/ade/Makefile +1 -1
index cf7a487..79de5ec 100644
@@ -25,6 +25,6 @@ top_srcdir		?= ../../..
 include $(top_srcdir)/include/mk/env_pre.mk
 
 # XXX (garrcoop): objdump's Makefile needs fixing.
-FILTER_OUT_DIRS		:= objdump
+FILTER_OUT_DIRS		:= 
 
 include $(top_srcdir)/include/mk/generic_trunk_target.mk
testcases/commands/ade/objdump/Makefile +2 -2
index 862438c..7fffc88 100644
@@ -29,8 +29,8 @@ test: CPPFLAGS += -O
 test_arch.obj: test.o
 	mv $< "$@"
 
-test_D: test.o
-	$(LINK.o) $^ $(LOADLIBES) $(LDLIBS) $(OUTPUT_OPTION) $@
+test_D: test_arch.obj
+	$(LINK.o) $^ $(LOADLIBES) $(LDLIBS) $(OUTPUT_OPTION)
 
 INSTALL_TARGETS		:= objdump01
  
testcases/commands/ade/objdump/objdump01 +1 -1
index 379a4f8..dd18e46 100755
@@ -41,7 +41,7 @@ export DUMP=/usr/bin/objdump
 do_setup()
 {
 mkdir $TCtmp
-/usr/bin/ar -cr $TCtmp/lib.a $TCsrc/test_arch.o
+/usr/bin/ar -cr $TCtmp/lib.a $TCsrc/test_arch.obj
 
 echo 1; $DUMP -f $TCsrc/test > $TCtmp/er_dump_f
 echo 2; $DUMP -h $TCsrc/test > $TCtmp/er_dump_h
Signature · 17 lines
1.6.2.2






------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community
Take advantage of Verizon's best-in-class app development support
A streamlined, 14 day to market process makes app distribution fast and easy
Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev 
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
#1 lore raw
Quoted 51 lines · liubo

- LTP needs to test "objdump", but ade's Makefile exclude it.
- objdump01 case uses *.obj instead, so s/*.o/*.obj/

This patch fixed these.

---
 testcases/commands/ade/Makefile          |    2 +- testcases/commands/ade/objdump/Makefile  |    4 ++-- testcases/commands/ade/objdump/objdump01 |    2 +-

 3 files changed, 4 insertions(+), 4 deletions(-)
testcases/commands/ade/Makefile +0 -0
index cf7a487..79de5ec 100644
@@ -25,6 +25,6 @@ top_srcdir            ?= ../../..

 include $(top_srcdir)/include/mk/env_pre.mk

 # XXX (garrcoop): objdump's Makefile needs fixing.

testcases/commands/ade/Makefile +1 -1
-FILTER_OUT_DIRS                := objdump
+FILTER_OUT_DIRS                :=

 include $(top_srcdir)/include/mk/generic_trunk_target.mk

testcases/commands/ade/objdump/Makefile +0 -0
index 862438c..7fffc88 100644
@@ -29,8 +29,8 @@ test: CPPFLAGS += -O

 test_arch.obj: test.o
       mv $< "$@"

testcases/commands/ade/objdump/Makefile +2 -2
-test_D: test.o
-       $(LINK.o) $^ $(LOADLIBES) $(LDLIBS) $(OUTPUT_OPTION) $@
+test_D: test_arch.obj
+       $(LINK.o) $^ $(LOADLIBES) $(LDLIBS) $(OUTPUT_OPTION)

 INSTALL_TARGETS                := objdump01

testcases/commands/ade/objdump/objdump01 +0 -0
index 379a4f8..dd18e46 100755
@@ -41,7 +41,7 @@ export DUMP=/usr/bin/objdump
  do_setup()
  {

 mkdir $TCtmp

testcases/commands/ade/objdump/objdump01 +1 -1
-/usr/bin/ar -cr $TCtmp/lib.a $TCsrc/test_arch.o
+/usr/bin/ar -cr $TCtmp/lib.a $TCsrc/test_arch.obj
Quoted 2 lines

 echo 1; $DUMP -f $TCsrc/test > $TCtmp/er_dump_f
 echo 2; $DUMP -h $TCsrc/test > $TCtmp/er_dump_h

This was fixed last week, IIRC.
Thanks,
-Garrett

------------------------------------------------------------------------------
This SF.Net email is sponsored by the Verizon Developer Community Take advantage of Verizon's best-in-class app development support A streamlined, 14 day to market process makes app distribution fast and easy Join now and get one step closer to millions of Verizon customers
http://p.sf.net/sfu/verizon-dev2dev
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list