Skip to contentSkip to conversation

Remove redundant vma_vm_flags from v7wbi_flush_user_tlb_range

PATCH Bahadir Balban 2 participants 2 messages Dec 18, 2009 – Dec 22, 2009 Arm (32-bit)

lore
Share & tools
lore

Bahadir Balban

author
#0 lore raw

Hi,

You don't seem to be testing for VM_EXEC as in v6 version, so vma_vm_flags seem redundant. What do you think?

---
  arch/arm/mm/tlb-v7.S |    1 -
  1 files changed, 0 insertions(+), 1 deletions(-)
arch/arm/mm/tlb-v7.S +0 -1
index a26a605..0cb1848 100644
@@ -40,7 +40,6 @@ ENTRY(v7wbi_flush_user_tlb_range)
  	asid	r3, r3				@ mask ASID
  	orr	r0, r3, r0, lsl #PAGE_SHIFT	@ Create initial MVA
  	mov	r1, r1, lsl #PAGE_SHIFT
-	vma_vm_flags r2, r2			@ get vma->vm_flags
  1:
  #ifdef CONFIG_SMP
  	mcr	p15, 0, r0, c8, c3, 1		@ TLB invalidate U MVA (shareable)
Signature · 5 lines
1.5.4.3


-- 
Bahadir Balban
#1 lore raw
Quoted 4 lines · Bahadir Balban

Hi,

You don't seem to be testing for VM_EXEC as in v6 version, so vma_vm_flags seem redundant. What do you think?

With a properly signed off patch, it could go to the patch system.