Rename mirror_device_fault_policy to mirror_image_fault policy
PATCH 1/1 Rename mirror_device_fault_policy to mirror_image_fault policy
This should be quite simple, but I have thrown in a simple testcase as well, for a good measure. There is some code duplication, but I'll address that separately, since the old codepath (which does not really do any upconversion, just logs suggestions) is still employed by vgreduce --removemissing --force. This ought to be simplified to just remove the faulty images/logs without looking at the policy or writing any hints (vgreduce --removemissing should issue a hint about lvconvert --repair instead).
This should fix RHBZ 538620.
Yours,
Petr.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mirror_image_fault_policy.diff
Type: text/x-diff
Size: 4171 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20091220/51717728/attachment.bin>
PATCH 1/1 Rename mirror_device_fault_policy to mirror_image_fault policy
Quoted 8 lines · Petr Rockai
This should be quite simple, but I have thrown in a simple testcase as well, for a good measure. There is some code duplication, but I'll address that separately, since the old codepath (which does not really do any upconversion, just logs suggestions) is still employed by vgreduce --removemissing --force. This ought to be simplified to just remove the faulty images/logs without looking at the policy or writing any hints (vgreduce --removemissing should issue a hint about lvconvert --repair instead).
ack for patch, grumble for posting it so late.
(for vgreduce simplification, take into account problems described in patch I just posted...)
Milan