Skip to contentSkip to conversation

be2net: Bug fix to avoid soft lockup in loopback test.

PATCH Applied Sarveshwar Bandi 3 participants 4 messages Dec 23, 2009 – Dec 24, 2009

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/3 be2net: Bug fix to avoid soft lockup in loopback test.

This change ensures that loopback test command gives up after 4 seconds when the hardware is not responsive. This could happen if the ports are connected properly in loopback mode.

---
 drivers/net/benet/be_cmds.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
drivers/net/benet/be_cmds.c +1 -0
index 1b68bd9..a27fdb3 100644
@@ -1501,6 +1501,7 @@ int be_cmd_loopback_test(struct be_adapt
 
 	be_cmd_hdr_prepare(&req->hdr, CMD_SUBSYSTEM_LOWLEVEL,
 			OPCODE_LOWLEVEL_LOOPBACK_TEST, sizeof(*req));
+	req->hdr.timeout = 4;
 
 	req->pattern = cpu_to_le64(pattern);
 	req->src_port = cpu_to_le32(port_num);
Signature · 1 line
1.4.0
maintainer Applied
#1 lore raw

From: Sarveshwar Bandi <[email protected]>
Date: Wed, 23 Dec 2009 20:10:36 +0530

Quoted 5 lines

This change ensures that loopback test command gives up after 4 seconds when the hardware is not responsive. This could happen if the ports are connected properly in loopback mode.

Applied.

#2 lore raw
In reply to Sarveshwar Bandi
Quoted 3 lines · Sarveshwar Bandi

This change ensures that loopback test command gives up after 4 seconds when the hardware is not responsive. This could happen if the ports are connected properly in loopback mode.

I don't understand the 2nd sentence, did you mean to say that this could happen if the ports are *not* connected properly in loopback mode?

Thanks, Jan

#3 lore raw
Quoted 3 lines · Sarveshwar bandi

Yes. thats what i meant.

- Sarvesh

OK, thanks for clarifying.

Jan