console: limit the range of VGACON_SOFT_SCROLLBACK_SIZE
Subsystems (2)
PATCH 1/1 console: limit the range of VGACON_SOFT_SCROLLBACK_SIZE
BuraphaLinux reported that we will trigger a mm warning when we CONFIG_VGACON_SOFT_SCROLLBACK_SIZE=65536, this is because mm cann't allocate so many pages. We should limit the range of CONFIG_VGACON_SOFT_SCROLLBACK_SIZE, don't give a user any chance to trigger that.
---
drivers/video/console/Kconfig +1 -0
@@ -37,6 +37,7 @@ config VGACON_SOFT_SCROLLBACK config VGACON_SOFT_SCROLLBACK_SIZE int "Scrollback Buffer Size (in KB)" depends on VGACON_SOFT_SCROLLBACK + range 1 1024 default "64" help Enter the amount of System RAM to allocate for the scrollback
Adding some Cc's in the original thread. :)
Quoted 23 lines · Amerigo Wang
BuraphaLinux reported that we will trigger a mm warning when we
CONFIG_VGACON_SOFT_SCROLLBACK_SIZE=65536, this is because mm cann't allocate so many pages. We should limit the range ofCONFIG_VGACON_SOFT_SCROLLBACK_SIZE, don't give a user any chance to trigger that.Reported-by BuraphaLinux Server <[email protected]>Signed-off-by WANG Cong <[email protected]>Cc David S. Miller <[email protected]>---
drivers/video/console/Kconfig +1
-0@@ -37,6 +37,7 @@ config VGACON_SOFT_SCROLLBACK config VGACON_SOFT_SCROLLBACK_SIZE int "Scrollback Buffer Size (in KB)" depends on VGACON_SOFT_SCROLLBACK + range 1 1024 default "64" help Enter the amount of System RAM to allocate for the scrollback
Quoted 18 lines · Amerigo Wang
BuraphaLinux reported that we will trigger a mm warning when we
CONFIG_VGACON_SOFT_SCROLLBACK_SIZE=65536, this is because mm cann't allocate so many pages. We should limit the range ofCONFIG_VGACON_SOFT_SCROLLBACK_SIZE, don't give a user any chance to trigger that.Reported-by John Gatewood Ham <[email protected]>Signed-off-by WANG Cong <[email protected]>Cc David S. Miller <[email protected]>---
drivers/video/console/Kconfig +0
-0
drivers/video/console/Kconfig config VGACON_SOFT_SCROLLBACK · line 43
Quoted 7 lines
drivers/video/console/Kconfig +1
-0@@ -37,6 +37,7 @@ config VGACON_SOFT_SCROLLBACK config VGACON_SOFT_SCROLLBACK_SIZE int "Scrollback Buffer Size (in KB)" depends on VGACON_SOFT_SCROLLBACK + range 1 1024 default "64" help Enter the amount of System RAM to allocate for the scrollback
This fixed the problem. Thank you for the fix. I texted on 2.6.32.2 with your patch added, x86_64 kernel.