Minor bug in bash completion
Hello,
I found a bug in the git bash completion.
It occurs when I press tab to complete branch name when I want to pull from the origin. Instead of completing the branch name it prompts me directly for my password on the origin remote.
I pressed tab
here (just after mem)
| srabot@khety:~/dev/ribeti.git[memcached]$ git pull origin [email protected]'s password: [email protected]'s password: cached [email protected]'s password: From git.ps.agematis.loc:/var/git/ribeti * branch memcached -> FETCH_HEAD Already up-to-date.
I'm using :
Linux khety 2.6.31-16-generic #53-Ubuntu SMP Tue Dec 8 04:01:29 UTC 2009 i686 GNU/Linux GNU bash, version 4.0.33(1)-release (i486-pc-linux-gnu)
git version 1.6.6
Best regards.
Signature · 1 line
Sylvain
Hi Sylvain,
Quoted 5 lines · Sylvain RABOT
I found a bug in the git bash completion.
It occurs when I press tab to complete branch name when I want to pull from the origin.
Instead of completing the branch name it prompts me directly for my password on the origin remote.
I don't think it's a bug. The completion script should offer the currently available refs in the remote repository after a 'git pull <remote> <TAB>'. In order to do that it contacts the remote repository for the list of refs available there. Depending on the access method, it might need to authenticate, in your case via ssh. To silence the password prompts you should change your ssh configuration to use key-based authentication when logging in to the remote repository's server (just google for 'ssh login without password').
Best,
Gábor
Quoted 21 lines · SZEDER Gábor
Hi Sylvain,
Quoted 5 lines · Sylvain RABOT
I found a bug in the git bash completion.
It occurs when I press tab to complete branch name when I want to pull from the origin.
Instead of completing the branch name it prompts me directly for my password on the origin remote.I don't think it's a bug. The completion script should offer the currently available refs in the remote repository after a 'git pull <remote> <TAB>'. In order to do that it contacts the remote repository for the list of refs available there. Depending on the access method, it might need to authenticate, in your case via ssh. To silence the password prompts you should change your ssh configuration to use key-based authentication when logging in to the remote repository's server (just google for 'ssh login without password').
Quoted 2 lines
Best,
Gábor
Haaa,
I understand now, tough, I thought that the list of origin's branches where stored somewhere in my local repository and that I needed to do a "git remote update origin" to get the current origin branches list.
Thanks for your answer.
Regards.
Signature · 1 line
Sylvain Rabot <[email protected]>
Quoted 11 lines · SZEDER Gábor
Quoted 5 lines · Sylvain RABOT
I found a bug in the git bash completion.
It occurs when I press tab to complete branch name when I want to pull from the origin.
Instead of completing the branch name it prompts me directly for my password on the origin remote.I don't think it's a bug. The completion script should offer the currently available refs in the remote repository after a 'git pull <remote> <TAB>'. In order to do that it contacts the remote repository for the list of refs available there.
It is definitely a non-bug since the user _asked_ to complete and the information necessary to do the job the user _asked_ to do is only accessible over the network connection.
I however do think this is an annoyance when it happens to you by accident. I wonder if it is worth to have a way for users to tell completion to skip the ls-remote invocation (hence not getting branches completed) depending on the type of remote.