net: Test off by one in sh_eth_reset()

PATCH Applied Roel Kluin 2 participants 2 messages Dec 30, 2009 – Jan 4, 2010

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Roel Kluin

author

2009-12-30 11:40 UTC #0 lore raw

PATCH 1/1 net: Test off by one in sh_eth_reset()

If no break occurred, cnt reaches 0 after the loop.

Signed-off-by Roel Kluin <[email protected]>

---
 drivers/net/sh_eth.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/net/sh_eth.c +1 -1

index ca62850..7402b85 100644
@@ -110,7 +110,7 @@ static void sh_eth_reset(struct net_device *ndev)
 		mdelay(1);
 		cnt--;
 	}
-	if (cnt < 0)
+	if (cnt == 0)
 		printk(KERN_ERR "Device reset fail\n");
 
 	/* Table Init */

David Miller

maintainer Applied

2010-01-04 05:43 UTC #1 lore raw

From: Roel Kluin <[email protected]>
Date: Wed, 30 Dec 2009 12:43:45 +0100

Quoted 3 lines

If no break occurred, cnt reaches 0 after the loop.
Signed-off-by Roel Kluin <[email protected]>

Applied.