tty: &&/|| confusion in mxser_get_ISA_conf()?
vi drivers/char/mxser.c +2460 and note:
if ((irq != regs[9]) || (irq != regs[10]))
Should this be an && ?
Roel
Quoted 5 lines · Roel Kluin
vi
drivers/char/mxser.c+2460 and note:if ((irq != regs[9]) || (irq != regs[10]))
Should this be an && ?
I would say not. It's a check whether irq is the same for all chips. It jumps to a true branch iff at least one irq of the 8 is different (there are 4 in each register). Does it make sense?
Signature · 1 line
js